2002-08-22 20:40:20

by Matthew Dobson

[permalink] [raw]
Subject: Re: [Lse-tech] [patch] SImple Topology API v0.3 (1/2)

The file asm/mmzone.h needs to be included in both the CONFIG_DISCONTIGMEM and
!CONFIG_DISCONTIGMEM cases (at least after my patch). This just pulls the
#include out of the #ifdefs.

Cheers!

-Matt

Christoph Hellwig wrote:
> On Thu, Aug 22, 2002 at 12:13:23PM -0700, Matthew Dobson wrote:
>
>>--- linux-2.5.27-vanilla/include/linux/mmzone.h Sat Jul 20 12:11:05 2002
>>+++ linux-2.5.27-api/include/linux/mmzone.h Wed Jul 24 17:33:41 2002
>>@@ -220,15 +20,15 @@
>> #define NODE_MEM_MAP(nid) mem_map
>> #define MAX_NR_NODES 1
>>
>>-#else /* !CONFIG_DISCONTIGMEM */
>>-
>>-#include <asm/mmzone.h>
>>+#else /* CONFIG_DISCONTIGMEM */
>>
>> /* page->zone is currently 8 bits ... */
>> #define MAX_NR_NODES (255 / MAX_NR_ZONES)
>>
>> #endif /* !CONFIG_DISCONTIGMEM */
>>
>>+#include <asm/mmzone.h>
>>+
>
>
> What is the exact purpose of this change?
>
>
>
> -------------------------------------------------------
> This sf.net email is sponsored by: OSDN - Tired of that same old
> cell phone? Get a new here for FREE!
> https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390
> _______________________________________________
> Lse-tech mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/lse-tech
>



2002-08-22 20:44:22

by Christoph Hellwig

[permalink] [raw]
Subject: Re: [Lse-tech] [patch] SImple Topology API v0.3 (1/2)

On Thu, Aug 22, 2002 at 01:41:51PM -0700, Matthew Dobson wrote:
> The file asm/mmzone.h needs to be included in both the CONFIG_DISCONTIGMEM and
> !CONFIG_DISCONTIGMEM cases (at least after my patch). This just pulls the
> #include out of the #ifdefs.

Maybe I've noticed that myself? But why do you suddenly break every port
of execept of i386,ia64, alpha and mips64? What is the reason your patch
needs this?