2002-10-01 17:35:56

by Miroslav Rudisin

[permalink] [raw]
Subject: [PATCH] default file permission for vfat

Hi,

The attached patch change default permission of files on [v]fatfs.
Default RWX have no utilization. This patch remove exec flag.

2.4.19 & 2.5.30

Thanks

--
Miroslav Rudisin


Attachments:
(No filename) (181.00 B)
patch (462.00 B)
Download all attachments

2002-10-01 18:51:52

by Willy Tarreau

[permalink] [raw]
Subject: Re: [PATCH] default file permission for vfat

On Tue, Oct 01, 2002 at 07:39:08PM +0200, Miroslav Rudisin wrote:
> Hi,
>
> The attached patch change default permission of files on [v]fatfs.
> Default RWX have no utilization. This patch remove exec flag.

Hi !

This is sometimes very useful to put init scripts on a floppy disk. I'd
prefer to keep exec flags. If you don't want files to be executable, you
still can mount the FS with the 'noexec' option.

Cheers,
Willy

2002-10-02 08:58:35

by Padraig Brady

[permalink] [raw]
Subject: Re: [PATCH] default file permission for vfat

Willy Tarreau wrote:
> On Tue, Oct 01, 2002 at 07:39:08PM +0200, Miroslav Rudisin wrote:
>
>>Hi,
>>
>>The attached patch change default permission of files on [v]fatfs.
>>Default RWX have no utilization. This patch remove exec flag.
>
> Hi !
>
> This is sometimes very useful to put init scripts on a floppy disk.

Not the common case and you can use different format floppies for this anyway.

> I'd prefer to keep exec flags. If you don't want files to be executable, you
> still can mount the FS with the 'noexec' option.

Not since: http://www.uwsg.iu.edu/hypermail/linux/kernel/0109.3/0363.html
Ideal would be to have a umask and dmask option (that applied to everything
not just vfat)

See also: http://kt.zork.net/kernel-traffic/kt20020415_162.html#1

P?draig.

2002-10-02 09:40:57

by Willy Tarreau

[permalink] [raw]
Subject: Re: [PATCH] default file permission for vfat

On Wed, Oct 02, 2002 at 10:02:48AM +0100, Padraig Brady wrote:
> Willy Tarreau wrote:
> >On Tue, Oct 01, 2002 at 07:39:08PM +0200, Miroslav Rudisin wrote:
> >
> >>Hi,
> >>
> >>The attached patch change default permission of files on [v]fatfs.
> >>Default RWX have no utilization. This patch remove exec flag.
> >
> >Hi !
> >
> >This is sometimes very useful to put init scripts on a floppy disk.
>
> Not the common case and you can use different format floppies for this
> anyway.

not when you want your customers to be able to edit their firewall config
with their M$ PC !

Willy

2002-10-02 10:32:35

by GOMBAS Gabor

[permalink] [raw]
Subject: Re: [PATCH] default file permission for vfat

On Wed, Oct 02, 2002 at 11:46:12AM +0200, Willy Tarreau wrote:

> not when you want your customers to be able to edit their firewall config
> with their M$ PC !

Copy them to tmpfs, do "chmod +x", execute them.

Gabor

--
Gabor Gombas Eotvos Lorand University
E-mail: [email protected] Hungary

2002-10-02 20:49:01

by Stas Sergeev

[permalink] [raw]
Subject: Re: [PATCH] default file permission for vfat

Hello.

Miroslav Rudisin wrote:
> The attached patch change default permission of files on [v]fatfs.
> Default RWX have no utilization. This patch remove exec flag.
Thank you very much!
Since the "noexec" option was broken, this
patch is extremely usefull.
I would like to see it included, but, as I
don't know the details, I pretend to say nothing
except that it is very usefull for me.