2002-12-09 21:37:16

by John Kim

Subject: [PATCH] 2.4.20 compile fix for drivers/scsi/t128.c

Patch below fixes following compile breakage:

gcc -D__KERNEL__ -I/usr/src/linux-2.4.20/include -Wall -Wstrict-prototypes
-Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
-march=athlon -nostdinc -iwithprefix
include -DKBUILD_BASENAME=t128 -c -o t128.o t128.c
t128.c:148: signatures causes a section type conflict
NCR5380.c:458: warning: `NCR5380_print_phase' defined but not used
NCR5380.c:402: warning: `NCR5380_print' defined but not used
make[3]: *** [t128.o] Error 1
make[3]: Leaving directory `/usr/src/linux-2.4.20/drivers/scsi'
make[2]: *** [first_rule] Error 2
make[2]: Leaving directory `/usr/src/linux-2.4.20/drivers/scsi'
make[1]: *** [_subdir_scsi] Error 2
make[1]: Leaving directory `/usr/src/linux-2.4.20/drivers'
make: *** [_dir_drivers] Error 2



diff -Naur linux-2.4.20/drivers/scsi/t128.c linux-2.4.20-new/drivers/scsi/t128.c
--- linux-2.4.20/drivers/scsi/t128.c 2001-12-21 12:41:55.000000000 -0500
+++ linux-2.4.20-new/drivers/scsi/t128.c 2002-12-09 12:52:21.000000000 -0500
@@ -142,7 +142,7 @@

#define NO_BASES (sizeof (bases) / sizeof (struct base))

-static const struct signature {
+static struct signature {
const char *string;
int offset;
} signatures[] __initdata = {

2002-12-09 23:36:42

by Andreas Steinmetz

Subject: Re: [PATCH] 2.4.20 compile fix for drivers/scsi/t128.c

I did already submit this, it's in the AC tree and via Alan in Marcelo's
BK tree:

http://linux.bkbits.net:8080/linux-2.4/diffs/drivers/scsi/[email protected]?nav=index.html|ChangeSet@-7d|[email protected]

John Kim wrote:
> Patch below fixes following compile breakage:
>
> gcc -D__KERNEL__ -I/usr/src/linux-2.4.20/include -Wall -Wstrict-prototypes
> -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
> -march=athlon -nostdinc -iwithprefix
> include -DKBUILD_BASENAME=t128 -c -o t128.o t128.c
> t128.c:148: signatures causes a section type conflict
> NCR5380.c:458: warning: `NCR5380_print_phase' defined but not used
> NCR5380.c:402: warning: `NCR5380_print' defined but not used
> make[3]: *** [t128.o] Error 1
> make[3]: Leaving directory `/usr/src/linux-2.4.20/drivers/scsi'
> make[2]: *** [first_rule] Error 2
> make[2]: Leaving directory `/usr/src/linux-2.4.20/drivers/scsi'
> make[1]: *** [_subdir_scsi] Error 2
> make[1]: Leaving directory `/usr/src/linux-2.4.20/drivers'
> make: *** [_dir_drivers] Error 2
>
>
>
> diff -Naur linux-2.4.20/drivers/scsi/t128.c linux-2.4.20-new/drivers/scsi/t128.c
> --- linux-2.4.20/drivers/scsi/t128.c 2001-12-21 12:41:55.000000000 -0500
> +++ linux-2.4.20-new/drivers/scsi/t128.c 2002-12-09 12:52:21.000000000 -0500
> @@ -142,7 +142,7 @@
>
> #define NO_BASES (sizeof (bases) / sizeof (struct base))
>
> -static const struct signature {
> +static struct signature {
> const char *string;
> int offset;
> } signatures[] __initdata = {
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>

--
Andreas Steinmetz
D.O.M. Datenverarbeitung GmbH