2003-01-23 22:35:58

by Andrew Grover

[permalink] [raw]
Subject: [PATCH] ACPI update (20030122)

Hi all,

The latest ACPI patch is now available at http://sf.net/projects/acpi .
Non-Linux packages will be available within 24 hours from
http://developer.intel.com/technology/iapc/acpi/downloads.htm .

The patches are big primarily because we finally got with the program
and moved our headers from drivers/acpi/include to include/acpi.

Regards -- Andy

22 January 2003. Summary of changes for version 20030122.


1) ACPI CA Core Subsystem:

Added a check for constructs of the form: Store (Local0,
Local0) where Local0 is not initialized. Apparently, some
BIOS programmers believe that this is a NOOP. Since this
store doesn't do anything anyway, the new prototype behavior
will ignore this error. This is a case where we can relax the
strict checking in the interpreter in the name of
compatibility.


2) Linux

The AcpiSrc Source Conversion Utility has been released with
the Unix package for the first time. This is the utility
that is used to convert the ACPI CA base source code to the
Linux version.

(Both) Handle P_BLK lengths shorter than 6 more gracefully

(Both) Move more headers to include/acpi, and delete an unused
header.

(Both) Move drivers/acpi/include directory to include/acpi

(Both) Boot functions don't use cmdline, so don't pass it
around

(Both) Remove include of unused header (Adrian Bunk)

(Both) acpiphp.h includes both linux/acpi.h and acpi_bus.h.
Since the former now also includes the latter, acpiphp.h only needs the
one, now.

(2.5) Make it possible to select method of bios restoring
after S3 resume. [=> no more ugly ifdefs] (Pavel Machek)

(2.5) Make proc write interfaces work (Pavel Machek)

(2.5) Properly init/clean up in cpufreq/acpi (Dominik
Brodowski)

(2.5) Break out ACPI Perf code into its own module, under
cpufreq (Dominik Brodowski)

(2.4) S4BIOS support (Ducrot Bruno)

(2.4) Fix acpiphp_glue.c for latest ACPI struct changes
(Sergio Visinoni)


3) iASL Compiler:

Added support to disassemble SSDT and PSDTs.

Implemented support to obtain SSDTs from the Windows registry
if available.

-----------------------------
Andrew Grover
Intel Labs / Mobile Architecture
[email protected]


2003-01-23 23:40:13

by Halil Demirezen

[permalink] [raw]
Subject: Re: [PATCH] ACPI update (20030122)

That seems that you've rewritten the acpi.c :)




On Thu, Jan 23, 2003 at 02:44:55PM -0800, Grover, Andrew wrote:
> Hi all,
>
> The latest ACPI patch is now available at http://sf.net/projects/acpi .
> Non-Linux packages will be available within 24 hours from
> http://developer.intel.com/technology/iapc/acpi/downloads.htm .
>
> The patches are big primarily because we finally got with the program
> and moved our headers from drivers/acpi/include to include/acpi.
>
> Regards -- Andy
>
> 22 January 2003. Summary of changes for version 20030122.
>
>
> 1) ACPI CA Core Subsystem:
>
> Added a check for constructs of the form: Store (Local0,
> Local0) where Local0 is not initialized. Apparently, some
> BIOS programmers believe that this is a NOOP. Since this
> store doesn't do anything anyway, the new prototype behavior
> will ignore this error. This is a case where we can relax the
> strict checking in the interpreter in the name of
> compatibility.
>
>
> 2) Linux
>
> The AcpiSrc Source Conversion Utility has been released with
> the Unix package for the first time. This is the utility
> that is used to convert the ACPI CA base source code to the
> Linux version.
>
> (Both) Handle P_BLK lengths shorter than 6 more gracefully
>
> (Both) Move more headers to include/acpi, and delete an unused
> header.
>
> (Both) Move drivers/acpi/include directory to include/acpi
>
> (Both) Boot functions don't use cmdline, so don't pass it
> around
>
> (Both) Remove include of unused header (Adrian Bunk)
>
> (Both) acpiphp.h includes both linux/acpi.h and acpi_bus.h.
> Since the former now also includes the latter, acpiphp.h only needs the
> one, now.
>
> (2.5) Make it possible to select method of bios restoring
> after S3 resume. [=> no more ugly ifdefs] (Pavel Machek)
>
> (2.5) Make proc write interfaces work (Pavel Machek)
>
> (2.5) Properly init/clean up in cpufreq/acpi (Dominik
> Brodowski)
>
> (2.5) Break out ACPI Perf code into its own module, under
> cpufreq (Dominik Brodowski)
>
> (2.4) S4BIOS support (Ducrot Bruno)
>
> (2.4) Fix acpiphp_glue.c for latest ACPI struct changes
> (Sergio Visinoni)
>
>
> 3) iASL Compiler:
>
> Added support to disassemble SSDT and PSDTs.
>
> Implemented support to obtain SSDTs from the Windows registry
> if available.
>
> -----------------------------
> Andrew Grover
> Intel Labs / Mobile Architecture
> [email protected]
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

2003-01-23 23:54:46

by Dave Jones

[permalink] [raw]
Subject: Re: [PATCH] ACPI update (20030122)

On Thu, Jan 23, 2003 at 02:44:55PM -0800, Grover, Andrew wrote:

> The latest ACPI patch is now available at http://sf.net/projects/acpi .
> Non-Linux packages will be available within 24 hours from
> http://developer.intel.com/technology/iapc/acpi/downloads.htm .

I've noticed that with .59 some of my boxes no longer have
functioning NICs unless I boot with acpi=off. Packets get
transmitted, but nothing ever gets received.
Seen this with a 3c509, an 8139, and an e100.

Known bug? Fixed in this patch ?

Dave

--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs

2003-01-24 00:00:10

by Andrew Grover

[permalink] [raw]
Subject: RE: [PATCH] ACPI update (20030122)

> From: Dave Jones [mailto:[email protected]]
> I've noticed that with .59 some of my boxes no longer have
> functioning NICs unless I boot with acpi=off. Packets get
> transmitted, but nothing ever gets received.
> Seen this with a 3c509, an 8139, and an e100.
>
> Known bug? Fixed in this patch ?

Known bug. Not fixed in this patch. Are you sure this is new in recent
kernels?

Regards -- Andy

2003-01-24 00:53:47

by Dave Jones

[permalink] [raw]
Subject: Re: [PATCH] ACPI update (20030122)

On Thu, Jan 23, 2003 at 04:09:07PM -0800, Grover, Andrew wrote:

> > Known bug? Fixed in this patch ?
> Known bug. Not fixed in this patch. Are you sure this is new in recent
> kernels?

Only seems to started biting me this last week for some reason.

Dave

--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs

2003-01-24 02:06:20

by Sergio Visinoni

[permalink] [raw]
Subject: [TRIVIAL] Re: [PATCH] ACPI update (20030122)

* Grover, Andrew ([email protected]) wrote:
> (2.4) S4BIOS support (Ducrot Bruno)

Attached is the missing s4bios portion (the
acpi_enter_sleep_state_s4bios function ) + fixes to make it
build correctly on a 2.4.20 tree.

It should apply correctly on 2.4.21-pre3 as well (not tested).

Greetings,
Sergio Visinoni


Attachments:
(No filename) (319.00 B)
acpi-20030122-missing-s4bios.patch (2.62 kB)
Download all attachments

2003-01-24 13:07:30

by Alvaro Lopes

[permalink] [raw]
Subject: Re: [PATCH] ACPI update (20030122)

Grover, Andrew wrote:

>Hi all,
>
>The latest ACPI patch is now available at http://sf.net/projects/acpi .
>Non-Linux packages will be available within 24 hours from
>http://developer.intel.com/technology/iapc/acpi/downloads.htm .
>
>
Still not working properly :/

Right now with 2.4.21-pre3 keventd 'eats' all my cpu.

Perhaps same problem I got with 2.5.59 (kernel does nothing but handle
IRQ's from acpi), but at least with 2.4 it gets to boot.

--

?lvaro Lopes
---------------------
A .sig is just a .sig


2003-01-24 15:41:57

by Bruno Ducrot

[permalink] [raw]
Subject: Re: [ACPI] [TRIVIAL] Re: [PATCH] ACPI update (20030122)

On Fri, Jan 24, 2003 at 03:22:22AM +0100, Sergio Visinoni wrote:
> * Grover, Andrew ([email protected]) wrote:
> > (2.4) S4BIOS support (Ducrot Bruno)
>
> Attached is the missing s4bios portion (the
> acpi_enter_sleep_state_s4bios function ) + fixes to make it
> build correctly on a 2.4.20 tree.
>
> It should apply correctly on 2.4.21-pre3 as well (not tested).
>

It should be OK (I think..)

Appart the following chunk:

--- linux-2.4.20/drivers/acpi/hardware/hwsleep.c.s4bios~ 2003-01-24 02:35:41.000000000 +0100
+++ linux-2.4.20/drivers/acpi/hardware/hwsleep.c 2003-01-24 02:35:53.000000000 +0100
@@ -339,6 +387,8 @@

ACPI_FUNCTION_TRACE ("acpi_leave_sleep_state");

+ /* Be sure to have BM arbitration */
+ status = acpi_set_register (ACPI_BITREG_ARB_DISABLE, 0, ACPI_MTX_LOCK);

/* Ensure enter_sleep_state_prep -> enter_sleep_state ordering */

@@ -371,8 +421,5 @@
return_ACPI_STATUS (status);
}

- /* Disable BM arbitration */
- status = acpi_set_register (ACPI_BITREG_ARB_DISABLE, 0, ACPI_MTX_LOCK);
-
return_ACPI_STATUS (status);
}


which is a bug fix for a different purpose.

We can not trust the bios when we have to enter the _WAK method.
Those we re-enable the BM arbitration before (the comment Disable
is actually a mistake).

Cheers,


--
Ducrot Bruno

-- Which is worse: ignorance or apathy?
-- Don't know. Don't care.