2003-05-13 17:12:16

by Simon Kelley

[permalink] [raw]
Subject: [PATCH] eliminates irqN: nobody cared! and backtrace on inserting 16bit PCMCIA card.

diff -urN linux-2.5.69.orig/drivers/pcmcia/rsrc_mgr.c linux-2.5.69/drivers/pcmcia/rsrc_mgr.c
--- linux-2.5.69.orig/drivers/pcmcia/rsrc_mgr.c Mon May 5 00:53:32 2003
+++ linux-2.5.69/drivers/pcmcia/rsrc_mgr.c Tue May 13 18:18:35 2003
@@ -601,7 +601,7 @@

#ifdef CONFIG_PCMCIA_PROBE

-static irqreturn_t fake_irq(int i, void *d, struct pt_regs *r) { return IRQ_NONE; }
+static irqreturn_t fake_irq(int i, void *d, struct pt_regs *r) { return IRQ_HANDLED; }
static inline int check_irq(int irq)
{
if (request_irq(irq, fake_irq, 0, "bogus", NULL) != 0)


2003-05-13 18:44:52

by Russell King

[permalink] [raw]
Subject: Re: [PATCH] eliminates irqN: nobody cared! and backtrace on inserting 16bit PCMCIA card.

On Tue, May 13, 2003 at 06:25:44PM +0100, Simon Kelley wrote:
> diff -urN linux-2.5.69.orig/drivers/pcmcia/rsrc_mgr.c linux-2.5.69/drivers/pcmcia/rsrc_mgr.c
> --- linux-2.5.69.orig/drivers/pcmcia/rsrc_mgr.c Mon May 5 00:53:32 2003
> +++ linux-2.5.69/drivers/pcmcia/rsrc_mgr.c Tue May 13 18:18:35 2003
> @@ -601,7 +601,7 @@
>
> #ifdef CONFIG_PCMCIA_PROBE
>
> -static irqreturn_t fake_irq(int i, void *d, struct pt_regs *r) { return IRQ_NONE; }
> +static irqreturn_t fake_irq(int i, void *d, struct pt_regs *r) { return IRQ_HANDLED; }
> static inline int check_irq(int irq)
> {
> if (request_irq(irq, fake_irq, 0, "bogus", NULL) != 0)
>

Oh damn, and I was hoping to kill fake_irq and make it use no_action()
instead!

--
Russell King ([email protected]) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html