2003-05-22 21:15:17

by Jeremy Buseman

[permalink] [raw]
Subject: scsi.h

Summary: When compiling cdrtools with 2.5.69-bk13
scsi.h causes errors at line 229 and 230.

__________________________________
Do you Yahoo!?
The New Yahoo! Search - Faster. Easier. Bingo.
http://search.yahoo.com


2003-05-23 00:59:50

by Douglas Gilbert

[permalink] [raw]
Subject: Re: scsi.h

Jeremy Buseman wrote on lkml:
> Summary: When compiling cdrtools with 2.5.69-bk13
> scsi.h causes errors at line 229 and 230.

That is the "u8" typedef that I tried to change to
something a little saner a while back.

Do we have any volunteers to discuss this matter with
Joerg Schilling? Even if he changes his next release,
he can't do much about the earlier releases.

As mentioned in the "RFC: move hosts.h and scsi.c" thread
started by Jeff Garzik on the lsml, some existing apps
(cdrecord/cdrtools and perhaps SANE) assume that the headers
in /usr/src/linux/include/scsi can be included safely in
their low level transports.
This was true but is no longer in the lk 2.5 series.

An ugly transition header included at the top of that
"scsi.h" could address this problem but my guess is some
will dislike this idea:

/* deprecated, this transition header will be removed in lk 2.8 */
#ifndef __KERNEL__
#define u8 int8_t
#define __user
....
#endif


Playing both sides of this debate, I recently added "__user"
qualifiers in sg.h (not yet released).

Doug Gilbert

2003-05-23 07:36:21

by ismail (cartman) donmez

[permalink] [raw]
Subject: Re: scsi.h

On Friday 23 May 2003 00:28, Jeremy Buseman wrote:
> Summary: When compiling cdrtools with 2.5.69-bk13
> scsi.h causes errors at line 229 and 230.
>

Add

typedef unsigned char u8;

to scsihack.c under cdrtools source to the ifdef __LINUX__ part. This is a
cdrtools bug not a kernel one.

Regards,
/ismail donmez

--
Microsoft Windows : Made for Internet
The Internet : Made For UniX