2003-06-02 15:18:12

by Stuart MacDonald

Subject: Redundant code?

Seems to me the following is redundant code, since get_fd_set also
memsets the fds.res_* bitmaps.

..Stu

--- linux-2.5.70/fs/select.c 2003-05-26 21:00:21.000000000 -0400
+++ linux-2.5.70-new/fs/select.c 2003-06-02 11:40:24.000000000 -0400
@@ -344,9 +344,6 @@
(ret = get_fd_set(n, outp, fds.out)) ||
(ret = get_fd_set(n, exp, fds.ex)))
goto out;
- zero_fd_set(n, fds.res_in);
- zero_fd_set(n, fds.res_out);
- zero_fd_set(n, fds.res_ex);

ret = do_select(n, &fds, &timeout);

2003-06-02 15:28:49

by Brian Gerst

Subject: Re: Redundant code?

Stuart MacDonald wrote:
> Seems to me the following is redundant code, since get_fd_set also
> memsets the fds.res_* bitmaps.
>
> ..Stu
>
> --- linux-2.5.70/fs/select.c 2003-05-26 21:00:21.000000000 -0400
> +++ linux-2.5.70-new/fs/select.c 2003-06-02 11:40:24.000000000 -0400
> @@ -344,9 +344,6 @@
> (ret = get_fd_set(n, outp, fds.out)) ||
> (ret = get_fd_set(n, exp, fds.ex)))
> goto out;
> - zero_fd_set(n, fds.res_in);
> - zero_fd_set(n, fds.res_out);
> - zero_fd_set(n, fds.res_ex);
>
> ret = do_select(n, &fds, &timeout);
>
>

fds.in != fds.res_in

--
Brian Gerst

2003-06-02 15:44:25

by Stuart MacDonald

Subject: RE: Redundant code?

From: [email protected]
> Stuart MacDonald wrote:
> > --- linux-2.5.70/fs/select.c 2003-05-26
> 21:00:21.000000000 -0400
> > +++ linux-2.5.70-new/fs/select.c 2003-06-02
> 11:40:24.000000000 -0400
> > @@ -344,9 +344,6 @@
> > (ret = get_fd_set(n, outp, fds.out)) ||
> > (ret = get_fd_set(n, exp, fds.ex)))
> > goto out;
> > - zero_fd_set(n, fds.res_in);
> > - zero_fd_set(n, fds.res_out);
> > - zero_fd_set(n, fds.res_ex);
> >
> > ret = do_select(n, &fds, &timeout);
>
> fds.in != fds.res_in

<smacks forehead> You are correct.

..Stu