2003-06-14 21:49:55

by Pete Clements

Subject: 2.5.71 fails compile (net/built-in.o)

FYI:


CPP arch/i386/vmlinux.lds.s
GEN .version
CHK include/linux/compile.h
UPD include/linux/compile.h
CC init/version.o
LD init/built-in.o
LD .tmp_vmlinux1
net/built-in.o: In function `flow_cache_init':
net/built-in.o(.init.text+0x282): undefined reference to `register_cpu_notifier'
make: *** [.tmp_vmlinux1] Error 1

--
Pete Clements
[email protected]

2003-06-14 22:09:15

by Andrew Morton

Subject: Re: 2.5.71 fails compile (net/built-in.o)

Pete Clements <[email protected]> wrote:
>
> FYI:
>
>
> CPP arch/i386/vmlinux.lds.s
> GEN .version
> CHK include/linux/compile.h
> UPD include/linux/compile.h
> CC init/version.o
> LD init/built-in.o
> LD .tmp_vmlinux1
> net/built-in.o: In function `flow_cache_init':
> net/built-in.o(.init.text+0x282): undefined reference to `register_cpu_notifier'


--- 25/net/core/flow.c~flow-warning-fix 2003-06-14 15:13:37.000000000 -0700
+++ 25-akpm/net/core/flow.c 2003-06-14 15:14:04.000000000 -0700
@@ -18,6 +18,7 @@
#include <linux/percpu.h>
#include <linux/bitops.h>
#include <linux/notifier.h>
+#include <linux/cpu.h>
#include <net/flow.h>
#include <asm/atomic.h>
#include <asm/semaphore.h>

2003-06-14 22:08:59

by John Weber

Subject: Re: 2.5.71 fails compile (net/built-in.o)

Pete Clements wrote:
> FYI:
>
>
> CPP arch/i386/vmlinux.lds.s
> GEN .version
> CHK include/linux/compile.h
> UPD include/linux/compile.h
> CC init/version.o
> LD init/built-in.o
> LD .tmp_vmlinux1
> net/built-in.o: In function `flow_cache_init':
> net/built-in.o(.init.text+0x282): undefined reference to `register_cpu_notifier'
> make: *** [.tmp_vmlinux1] Error 1
>
Just a missing #include in net/core/flow.c

--- flow.old 2003-06-14 18:17:35.000000000 -0400
+++ flow.c 2003-06-14 18:13:03.000000000 -0400
@@ -5,6 +5,7 @@
*/

#include <linux/kernel.h>
+#include <linux/cpu.h>
#include <linux/list.h>
#include <linux/jhash.h>
#include <linux/interrupt.h>