2020-04-21 03:25:09

by Jianyong Wu

Subject: [RFC PATCH v11 1/9] psci: export psci conduit get helper.

Export arm_smccc_1_1_get_conduit then modules can use smccc helper which
adopts it.

Signed-off-by: Jianyong Wu <[email protected]>
---
drivers/firmware/psci/psci.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c
index 2937d44b5df4..fd3c88f21b6a 100644
--- a/drivers/firmware/psci/psci.c
+++ b/drivers/firmware/psci/psci.c
@@ -64,6 +64,7 @@ enum arm_smccc_conduit arm_smccc_1_1_get_conduit(void)

return psci_ops.conduit;
}
+EXPORT_SYMBOL(arm_smccc_1_1_get_conduit);

typedef unsigned long (psci_fn)(unsigned long, unsigned long,
unsigned long, unsigned long);
--
2.17.1

2020-04-21 09:42:38

by Mark Rutland

Subject: Re: [RFC PATCH v11 1/9] psci: export psci conduit get helper.

On Tue, Apr 21, 2020 at 11:22:56AM +0800, Jianyong Wu wrote:
> Export arm_smccc_1_1_get_conduit then modules can use smccc helper which
> adopts it.
>
> Signed-off-by: Jianyong Wu <[email protected]>

Nit: please say 'smccc conduit' in the commit title.

Otherwise, I see not problem with this provided an in-tree module uses
this, so:

Acked-by: Mark Rutland <[email protected]>

Mark.

> ---
> drivers/firmware/psci/psci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c
> index 2937d44b5df4..fd3c88f21b6a 100644
> --- a/drivers/firmware/psci/psci.c
> +++ b/drivers/firmware/psci/psci.c
> @@ -64,6 +64,7 @@ enum arm_smccc_conduit arm_smccc_1_1_get_conduit(void)
>
> return psci_ops.conduit;
> }
> +EXPORT_SYMBOL(arm_smccc_1_1_get_conduit);
>
> typedef unsigned long (psci_fn)(unsigned long, unsigned long,
> unsigned long, unsigned long);
> --
> 2.17.1
>

2020-04-21 09:53:03

by Jianyong Wu

Subject: Re: [RFC PATCH v11 1/9] psci: export psci conduit get helper.

Hi Mark,


On 2020/4/21, 5:41 PM, "Mark Rutland" <[email protected]> wrote:

On Tue, Apr 21, 2020 at 11:22:56AM +0800, Jianyong Wu wrote:
> Export arm_smccc_1_1_get_conduit then modules can use smccc helper which
> adopts it.
>
> Signed-off-by: Jianyong Wu <[email protected]>

Nit: please say 'smccc conduit' in the commit title.

Ok, I will fix it next version.

Otherwise, I see not problem with this provided an in-tree module uses
this, so:

Acked-by: Mark Rutland <[email protected]>

Thanks! Glad to get this.

Best regards
Jianyong

Mark.

> ---
> drivers/firmware/psci/psci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c
> index 2937d44b5df4..fd3c88f21b6a 100644
> --- a/drivers/firmware/psci/psci.c
> +++ b/drivers/firmware/psci/psci.c
> @@ -64,6 +64,7 @@ enum arm_smccc_conduit arm_smccc_1_1_get_conduit(void)
>
> return psci_ops.conduit;
> }
> +EXPORT_SYMBOL(arm_smccc_1_1_get_conduit);
>
> typedef unsigned long (psci_fn)(unsigned long, unsigned long,
> unsigned long, unsigned long);
> --
> 2.17.1
>