2024-03-22 05:29:17

by Shawn Sung (宋孝謙)

Subject: [PATCH v6 11/14] drm/mediatek: Support "None" alpha blending in Mixer

From: Hsiao Chien Sung <[email protected]>

Support "None" blend mode on MediaTek's chips.

Please refer to the description of the commit
"drm/mediatek: Support alpha blending in display driver"
for more information.

Signed-off-by: Hsiao Chien Sung <[email protected]>
---
drivers/gpu/drm/mediatek/mtk_ethdr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_ethdr.c b/drivers/gpu/drm/mediatek/mtk_ethdr.c
index 4b12ca285e84b..951e3e82a6a1a 100644
--- a/drivers/gpu/drm/mediatek/mtk_ethdr.c
+++ b/drivers/gpu/drm/mediatek/mtk_ethdr.c
@@ -178,7 +178,8 @@ void mtk_ethdr_layer_config(struct device *dev, unsigned int idx,
if (state->base.pixel_blend_mode != DRM_MODE_BLEND_COVERAGE)
mix_con |= PREMULTI_SOURCE;

- if (state->base.fb && !state->base.fb->format->has_alpha) {
+ if (state->base.pixel_blend_mode == DRM_MODE_BLEND_PIXEL_NONE ||
+ (state->base.fb && !state->base.fb->format->has_alpha)) {
/*
* Mixer doesn't support CONST_BLD mode,
* use a trick to make the output equivalent
--
2.18.0

2024-03-25 10:28:42

by CK Hu (胡俊光)

Subject: Re: [PATCH v6 11/14] drm/mediatek: Support "None" alpha blending in Mixer

Hi, Shawn:

On Fri, 2024-03-22 at 13:28 +0800, Shawn Sung wrote:
> From: Hsiao Chien Sung <[email protected]>
>
> Support "None" blend mode on MediaTek's chips.
>
> Please refer to the description of the commit
> "drm/mediatek: Support alpha blending in display driver"
> for more information.

But I would like you to describe the information in this patch instead
of referring to another patch. This patch could describe more detail,
and the integration patch could describe more brief.

Regards,
CK

>
> Signed-off-by: Hsiao Chien Sung <[email protected]>
> ---
> drivers/gpu/drm/mediatek/mtk_ethdr.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_ethdr.c
> b/drivers/gpu/drm/mediatek/mtk_ethdr.c
> index 4b12ca285e84b..951e3e82a6a1a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_ethdr.c
> +++ b/drivers/gpu/drm/mediatek/mtk_ethdr.c
> @@ -178,7 +178,8 @@ void mtk_ethdr_layer_config(struct device *dev,
> unsigned int idx,
> if (state->base.pixel_blend_mode != DRM_MODE_BLEND_COVERAGE)
> mix_con |= PREMULTI_SOURCE;
>
> - if (state->base.fb && !state->base.fb->format->has_alpha) {
> + if (state->base.pixel_blend_mode == DRM_MODE_BLEND_PIXEL_NONE
> ||
> + (state->base.fb && !state->base.fb->format->has_alpha)) {
> /*
> * Mixer doesn't support CONST_BLD mode,
> * use a trick to make the output equivalent

2024-03-28 02:56:23

by Shawn Sung (宋孝謙)

Subject: Re: [PATCH v6 11/14] drm/mediatek: Support "None" alpha blending in Mixer

Hi CK,

On Mon, 2024-03-25 at 02:03 +0000, CK Hu (胡俊光) wrote:
> Hi, Shawn:
>
> On Fri, 2024-03-22 at 13:28 +0800, Shawn Sung wrote:
> > From: Hsiao Chien Sung <[email protected]>
> >
> > Support "None" blend mode on MediaTek's chips.
> >
> > Please refer to the description of the commit
> > "drm/mediatek: Support alpha blending in display driver"
> > for more information.
>
> But I would like you to describe the information in this patch
> instead
> of referring to another patch. This patch could describe more detail,
> and the integration patch could describe more brief.
>

Got it. Will try to add more information to all the related patches.

Thanks,
Shawn