2022-06-20 17:42:42

by Nam Cao

Subject: [PATCH 0/2] get rid of useless header file

The stuffs in basic_types.h are either not used, or already defined in
the kernel. Get rid of it.

Nam Cao (2):
staging: r8188eu: replace N_BYTE_ALIGMENT with ALIGN
staging: r8188eu: remove basic_types.h

drivers/staging/r8188eu/core/rtw_recv.c | 2 +-
drivers/staging/r8188eu/core/rtw_xmit.c | 6 +++---
drivers/staging/r8188eu/hal/rtl8188eu_recv.c | 2 +-
drivers/staging/r8188eu/include/basic_types.h | 19 -------------------
.../staging/r8188eu/include/osdep_service.h | 1 -
drivers/staging/r8188eu/os_dep/xmit_linux.c | 2 +-
6 files changed, 6 insertions(+), 26 deletions(-)
delete mode 100644 drivers/staging/r8188eu/include/basic_types.h

--
2.25.1

2022-06-20 17:51:09

by Nam Cao

Subject: [PATCH 2/2] staging: r8188eu: remove basic_types.h

Remove file basic_types.h because the content of this file is not used
anywhere.

Signed-off-by: Nam Cao <[email protected]>
---
drivers/staging/r8188eu/include/basic_types.h | 19 -------------------
.../staging/r8188eu/include/osdep_service.h | 1 -
2 files changed, 20 deletions(-)
delete mode 100644 drivers/staging/r8188eu/include/basic_types.h

diff --git a/drivers/staging/r8188eu/include/basic_types.h b/drivers/staging/r8188eu/include/basic_types.h
deleted file mode 100644
index 0b71e2c6e41a..000000000000
--- a/drivers/staging/r8188eu/include/basic_types.h
+++ /dev/null
@@ -1,19 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */
-/* Copyright(c) 2007 - 2011 Realtek Corporation. */
-
-#ifndef __BASIC_TYPES_H__
-#define __BASIC_TYPES_H__
-
-#include <linux/types.h>
-#define NDIS_OID uint
-
-typedef void (*proc_t)(void *);
-
-/* port from fw */
-/* TODO: Macros Below are Sync from SD7-Driver. It is necessary
- * to check correctness */
-
-#define N_BYTE_ALIGMENT(__value, __aligment) ((__aligment == 1) ? \
- (__value) : (((__value + __aligment - 1) / __aligment) * __aligment))
-
-#endif /* __BASIC_TYPES_H__ */
diff --git a/drivers/staging/r8188eu/include/osdep_service.h b/drivers/staging/r8188eu/include/osdep_service.h
index f1a703643e74..1d97d5be46d5 100644
--- a/drivers/staging/r8188eu/include/osdep_service.h
+++ b/drivers/staging/r8188eu/include/osdep_service.h
@@ -5,7 +5,6 @@
#define __OSDEP_SERVICE_H_

#include <linux/sched/signal.h>
-#include "basic_types.h"

#define _FAIL 0
#define _SUCCESS 1
--
2.25.1

2022-06-20 20:06:12

by Larry Finger

Subject: Re: [PATCH 0/2] get rid of useless header file

On 6/20/22 12:19, Nam Cao wrote:
> The stuffs in basic_types.h are either not used, or already defined in
> the kernel. Get rid of it.
>
> Nam Cao (2):
> staging: r8188eu: replace N_BYTE_ALIGMENT with ALIGN
> staging: r8188eu: remove basic_types.h
>
> drivers/staging/r8188eu/core/rtw_recv.c | 2 +-
> drivers/staging/r8188eu/core/rtw_xmit.c | 6 +++---
> drivers/staging/r8188eu/hal/rtl8188eu_recv.c | 2 +-
> drivers/staging/r8188eu/include/basic_types.h | 19 -------------------
> .../staging/r8188eu/include/osdep_service.h | 1 -
> drivers/staging/r8188eu/os_dep/xmit_linux.c | 2 +-
> 6 files changed, 6 insertions(+), 26 deletions(-)
> delete mode 100644 drivers/staging/r8188eu/include/basic_types.h
>

For future patch sets, please include the "staging: r8188eu:" part of the
subject of the cover letter. It makes it easier to sort out the rest of the
patches; however,it is not necessary to resubmit this one.

The two patchesw are fine.

Acked-by: Larry Finger <[email protected]>

Thanks,

Larry