Subject: [PATCH] iio: event: Remove negative error code from iio_event_poll

Negative return values are not supported by iio_event_poll since
its return type is unsigned int.

Signed-off-by: Cristina Opriceana <[email protected]>
---
drivers/iio/industrialio-event.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/industrialio-event.c b/drivers/iio/industrialio-event.c
index b2f63f9..eb44dab 100644
--- a/drivers/iio/industrialio-event.c
+++ b/drivers/iio/industrialio-event.c
@@ -80,7 +80,7 @@ EXPORT_SYMBOL(iio_push_event);
* @wait: Poll table pointer to add the wait queue on
*
* Return: (POLLIN | POLLRDNORM) if data is available for reading
- * or a negative error code on failure
+ * or 0 on failure
*/
static unsigned int iio_event_poll(struct file *filep,
struct poll_table_struct *wait)
@@ -90,7 +90,7 @@ static unsigned int iio_event_poll(struct file *filep,
unsigned int events = 0;

if (!indio_dev->info)
- return -ENODEV;
+ return events;

poll_wait(filep, &ev_int->wait, wait);

--
1.9.1


2015-08-08 16:20:43

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH] iio: event: Remove negative error code from iio_event_poll

On 03/08/15 11:00, Cristina Opriceana wrote:
> Negative return values are not supported by iio_event_poll since
> its return type is unsigned int.
>
> Signed-off-by: Cristina Opriceana <[email protected]>
As with the other one, the docs aren't yet there in the fixes tree where
I have applied this (by hand). I've also added the fixes line and
marked it for stable.

Could you resend the docs updates after that patch has worked it's
way through to the togreg branch of iio.git

(I'll try and remember this as well!)

Thanks,

Jonathan
> ---
> drivers/iio/industrialio-event.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/industrialio-event.c b/drivers/iio/industrialio-event.c
> index b2f63f9..eb44dab 100644
> --- a/drivers/iio/industrialio-event.c
> +++ b/drivers/iio/industrialio-event.c
> @@ -80,7 +80,7 @@ EXPORT_SYMBOL(iio_push_event);
> * @wait: Poll table pointer to add the wait queue on
> *
> * Return: (POLLIN | POLLRDNORM) if data is available for reading
> - * or a negative error code on failure
> + * or 0 on failure
> */
> static unsigned int iio_event_poll(struct file *filep,
> struct poll_table_struct *wait)
> @@ -90,7 +90,7 @@ static unsigned int iio_event_poll(struct file *filep,
> unsigned int events = 0;
>
> if (!indio_dev->info)
> - return -ENODEV;
> + return events;
>
> poll_wait(filep, &ev_int->wait, wait);
>
>