2023-06-28 08:32:27

by Cindy Lu

Subject: [RFC 1/4] vduse: Add the struct to save the vq reconnect info

From: Your Name <[email protected]>

this struct is to save the reconnect info struct, in this
struct saved the page info that alloc to save the
reconnect info

Signed-off-by: Cindy Lu <[email protected]>
---
drivers/vdpa/vdpa_user/vduse_dev.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c
index 26b7e29cb900..f845dc46b1db 100644
--- a/drivers/vdpa/vdpa_user/vduse_dev.c
+++ b/drivers/vdpa/vdpa_user/vduse_dev.c
@@ -72,6 +72,12 @@ struct vduse_umem {
struct page **pages;
struct mm_struct *mm;
};
+struct vdpa_reconnect_info {
+ u32 index;
+ phys_addr_t addr;
+ unsigned long vaddr;
+ phys_addr_t size;
+};

struct vduse_dev {
struct vduse_vdpa *vdev;
@@ -106,6 +112,7 @@ struct vduse_dev {
u32 vq_align;
struct vduse_umem *umem;
struct mutex mem_lock;
+ struct vdpa_reconnect_info reconnect_info[64];
};

struct vduse_dev_msg {
--
2.34.3

2023-06-28 08:50:09

by Jason Wang

Subject: Re: [RFC 1/4] vduse: Add the struct to save the vq reconnect info

On Wed, Jun 28, 2023 at 2:59 PM Cindy Lu <[email protected]> wrote:
>
> From: Your Name <[email protected]>

It looks to me your git is not properly configured.

>
> this struct is to save the reconnect info struct, in this
> struct saved the page info that alloc to save the
> reconnect info
>
> Signed-off-by: Cindy Lu <[email protected]>
> ---
> drivers/vdpa/vdpa_user/vduse_dev.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c
> index 26b7e29cb900..f845dc46b1db 100644
> --- a/drivers/vdpa/vdpa_user/vduse_dev.c
> +++ b/drivers/vdpa/vdpa_user/vduse_dev.c
> @@ -72,6 +72,12 @@ struct vduse_umem {
> struct page **pages;
> struct mm_struct *mm;
> };
> +struct vdpa_reconnect_info {
> + u32 index;
> + phys_addr_t addr;
> + unsigned long vaddr;
> + phys_addr_t size;
> +};

Please add comments to explain each field. And I think this should be
a part of uAPI?

Thanks

>
> struct vduse_dev {
> struct vduse_vdpa *vdev;
> @@ -106,6 +112,7 @@ struct vduse_dev {
> u32 vq_align;
> struct vduse_umem *umem;
> struct mutex mem_lock;
> + struct vdpa_reconnect_info reconnect_info[64];
> };
>
> struct vduse_dev_msg {
> --
> 2.34.3
>

2023-07-01 09:48:57

by Cindy Lu

Subject: Re: [RFC 1/4] vduse: Add the struct to save the vq reconnect info

On Wed, Jun 28, 2023 at 4:04 PM Jason Wang <[email protected]> wrote:
>
> On Wed, Jun 28, 2023 at 2:59 PM Cindy Lu <[email protected]> wrote:
> >
> > From: Your Name <[email protected]>
>
> It looks to me your git is not properly configured.
>
> >
> > this struct is to save the reconnect info struct, in this
> > struct saved the page info that alloc to save the
> > reconnect info
> >
> > Signed-off-by: Cindy Lu <[email protected]>
> > ---
> > drivers/vdpa/vdpa_user/vduse_dev.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c
> > index 26b7e29cb900..f845dc46b1db 100644
> > --- a/drivers/vdpa/vdpa_user/vduse_dev.c
> > +++ b/drivers/vdpa/vdpa_user/vduse_dev.c
> > @@ -72,6 +72,12 @@ struct vduse_umem {
> > struct page **pages;
> > struct mm_struct *mm;
> > };
> > +struct vdpa_reconnect_info {
> > + u32 index;
> > + phys_addr_t addr;
> > + unsigned long vaddr;
> > + phys_addr_t size;
> > +};
>
> Please add comments to explain each field. And I think this should be
> a part of uAPI?
>
> Thanks
>
Will add the new ioctl for this information
Thanks
Cindy
> >
> > struct vduse_dev {
> > struct vduse_vdpa *vdev;
> > @@ -106,6 +112,7 @@ struct vduse_dev {
> > u32 vq_align;
> > struct vduse_umem *umem;
> > struct mutex mem_lock;
> > + struct vdpa_reconnect_info reconnect_info[64];
> > };
> >
> > struct vduse_dev_msg {
> > --
> > 2.34.3
> >
>

2023-07-03 06:44:27

by Jason Wang

Subject: Re: [RFC 1/4] vduse: Add the struct to save the vq reconnect info

On Sat, Jul 1, 2023 at 5:25 PM Cindy Lu <[email protected]> wrote:
>
> On Wed, Jun 28, 2023 at 4:04 PM Jason Wang <[email protected]> wrote:
> >
> > On Wed, Jun 28, 2023 at 2:59 PM Cindy Lu <[email protected]> wrote:
> > >
> > > From: Your Name <[email protected]>
> >
> > It looks to me your git is not properly configured.
> >
> > >
> > > this struct is to save the reconnect info struct, in this
> > > struct saved the page info that alloc to save the
> > > reconnect info
> > >
> > > Signed-off-by: Cindy Lu <[email protected]>
> > > ---
> > > drivers/vdpa/vdpa_user/vduse_dev.c | 7 +++++++
> > > 1 file changed, 7 insertions(+)
> > >
> > > diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c
> > > index 26b7e29cb900..f845dc46b1db 100644
> > > --- a/drivers/vdpa/vdpa_user/vduse_dev.c
> > > +++ b/drivers/vdpa/vdpa_user/vduse_dev.c
> > > @@ -72,6 +72,12 @@ struct vduse_umem {
> > > struct page **pages;
> > > struct mm_struct *mm;
> > > };
> > > +struct vdpa_reconnect_info {
> > > + u32 index;
> > > + phys_addr_t addr;
> > > + unsigned long vaddr;
> > > + phys_addr_t size;
> > > +};
> >
> > Please add comments to explain each field. And I think this should be
> > a part of uAPI?
> >
> > Thanks
> >
> Will add the new ioctl for this information

I may miss something but having this to be part of the uAPI seems more
than enough.

Or what would this new ioctl do?

Thanks

> Thanks
> Cindy
> > >
> > > struct vduse_dev {
> > > struct vduse_vdpa *vdev;
> > > @@ -106,6 +112,7 @@ struct vduse_dev {
> > > u32 vq_align;
> > > struct vduse_umem *umem;
> > > struct mutex mem_lock;
> > > + struct vdpa_reconnect_info reconnect_info[64];
> > > };
> > >
> > > struct vduse_dev_msg {
> > > --
> > > 2.34.3
> > >
> >
>

2023-07-11 14:38:48

by Maxime Coquelin

Subject: Re: [RFC 1/4] vduse: Add the struct to save the vq reconnect info

Hello Cindy,

On 6/28/23 08:59, Cindy Lu wrote:
> From: Your Name <[email protected]>
>
> this struct is to save the reconnect info struct, in this
> struct saved the page info that alloc to save the
> reconnect info
>
> Signed-off-by: Cindy Lu <[email protected]>
> ---
> drivers/vdpa/vdpa_user/vduse_dev.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c
> index 26b7e29cb900..f845dc46b1db 100644
> --- a/drivers/vdpa/vdpa_user/vduse_dev.c
> +++ b/drivers/vdpa/vdpa_user/vduse_dev.c
> @@ -72,6 +72,12 @@ struct vduse_umem {
> struct page **pages;
> struct mm_struct *mm;
> };
> +struct vdpa_reconnect_info {
> + u32 index;
> + phys_addr_t addr;
> + unsigned long vaddr;
> + phys_addr_t size;
> +};
>
> struct vduse_dev {
> struct vduse_vdpa *vdev;
> @@ -106,6 +112,7 @@ struct vduse_dev {
> u32 vq_align;
> struct vduse_umem *umem;
> struct mutex mem_lock;
> + struct vdpa_reconnect_info reconnect_info[64];

Why 64?
Shouldn't it be part of struct vduse_virtqueue instead?

> };
>
> struct vduse_dev_msg {