2023-11-28 08:47:05

by Varadarajan Narayanan

Subject: [PATCH v1 1/2] regulator: qcom_smd: Add LDO5 MP5496 regulator

From: Varadarajan Narayanan <[email protected]>

Add support for LDO5 regulator. This is used by IPQ9574 USB.

Signed-off-by: Varadarajan Narayanan <[email protected]>
---
drivers/regulator/qcom_smd-regulator.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c
index 09c471a0ba2e..d1be9568025e 100644
--- a/drivers/regulator/qcom_smd-regulator.c
+++ b/drivers/regulator/qcom_smd-regulator.c
@@ -796,6 +796,7 @@ static const struct rpm_regulator_data rpm_mp5496_regulators[] = {
{ "s1", QCOM_SMD_RPM_SMPA, 1, &mp5496_smps, "s1" },
{ "s2", QCOM_SMD_RPM_SMPA, 2, &mp5496_smps, "s2" },
{ "l2", QCOM_SMD_RPM_LDOA, 2, &mp5496_ldoa2, "l2" },
+ { "l5", QCOM_SMD_RPM_LDOA, 5, &mp5496_ldoa2, "l5" },
{}
};

--
2.34.1

2023-11-28 08:53:03

by Krzysztof Kozlowski

Subject: Re: [PATCH v1 1/2] regulator: qcom_smd: Add LDO5 MP5496 regulator

On 28/11/2023 09:46, Varadarajan Narayanan wrote:
> From: Varadarajan Narayanan <[email protected]>
>
> Add support for LDO5 regulator. This is used by IPQ9574 USB.
>
> Signed-off-by: Varadarajan Narayanan <[email protected]>
> ---
> drivers/regulator/qcom_smd-regulator.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c
> index 09c471a0ba2e..d1be9568025e 100644
> --- a/drivers/regulator/qcom_smd-regulator.c
> +++ b/drivers/regulator/qcom_smd-regulator.c
> @@ -796,6 +796,7 @@ static const struct rpm_regulator_data rpm_mp5496_regulators[] = {
> { "s1", QCOM_SMD_RPM_SMPA, 1, &mp5496_smps, "s1" },
> { "s2", QCOM_SMD_RPM_SMPA, 2, &mp5496_smps, "s2" },
> { "l2", QCOM_SMD_RPM_LDOA, 2, &mp5496_ldoa2, "l2" },
> + { "l5", QCOM_SMD_RPM_LDOA, 5, &mp5496_ldoa2, "l5" },

Binding says there is no l5 (neither l2...), so please update it.

Best regards,
Krzysztof