2023-10-16 20:05:07

by Arnd Bergmann

Subject: [PATCH] fbdev: sa1100fb: mark sa1100fb_init() static

From: Arnd Bergmann <[email protected]>

This is a global function that is only referenced as an initcall. This causes
a warning:

drivers/video/fbdev/sa1100fb.c:1218:12: error: no previous prototype for 'sa1100fb_init' [-Werror=missing-prototypes]

Make it static instead.

Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/video/fbdev/sa1100fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/sa1100fb.c b/drivers/video/fbdev/sa1100fb.c
index 63e12a7c1100e..e14eb634cb944 100644
--- a/drivers/video/fbdev/sa1100fb.c
+++ b/drivers/video/fbdev/sa1100fb.c
@@ -1215,7 +1215,7 @@ static struct platform_driver sa1100fb_driver = {
},
};

-int __init sa1100fb_init(void)
+static int __init sa1100fb_init(void)
{
if (fb_get_options("sa1100fb", NULL))
return -ENODEV;
--
2.39.2

2023-10-16 21:07:23

by Helge Deller

Subject: Re: [PATCH] fbdev: sa1100fb: mark sa1100fb_init() static

On 10/16/23 22:04, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> This is a global function that is only referenced as an initcall. This causes
> a warning:
>
> drivers/video/fbdev/sa1100fb.c:1218:12: error: no previous prototype for 'sa1100fb_init' [-Werror=missing-prototypes]
>
> Make it static instead.
>
> Signed-off-by: Arnd Bergmann <[email protected]>

applied.

Thanks!
Helge

> ---
> drivers/video/fbdev/sa1100fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/sa1100fb.c b/drivers/video/fbdev/sa1100fb.c
> index 63e12a7c1100e..e14eb634cb944 100644
> --- a/drivers/video/fbdev/sa1100fb.c
> +++ b/drivers/video/fbdev/sa1100fb.c
> @@ -1215,7 +1215,7 @@ static struct platform_driver sa1100fb_driver = {
> },
> };
>
> -int __init sa1100fb_init(void)
> +static int __init sa1100fb_init(void)
> {
> if (fb_get_options("sa1100fb", NULL))
> return -ENODEV;