2018-01-31 19:33:11

by Giulio Benetti

[permalink] [raw]
Subject: [PATCH] arm: dts: sun7i: include correct ccu clock header

Include correct clock header sun7i-a20-ccu.h
instead of sun4i-a20-ccu.h.

Including sun4i header instead of sun7i
prevents using sun7i specific defines.

Substitute header inclusion in sun7i-a20.dtsi
using right one.

Signed-off-by: Giulio Benetti <[email protected]>
---
arch/arm/boot/dts/sun7i-a20.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index 1aa05a0..d0865d2 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -47,7 +47,7 @@
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/thermal/thermal.h>
#include <dt-bindings/dma/sun4i-a10.h>
-#include <dt-bindings/clock/sun4i-a10-ccu.h>
+#include <dt-bindings/clock/sun7i-a20-ccu.h>
#include <dt-bindings/reset/sun4i-a10-ccu.h>

/ {
--
2.7.4



2018-02-01 15:19:52

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH] arm: dts: sun7i: include correct ccu clock header

Hi,

On Wed, Jan 31, 2018 at 08:31:26PM +0100, Giulio Benetti wrote:
> Include correct clock header sun7i-a20-ccu.h
> instead of sun4i-a20-ccu.h.

You should wrap at 72 characters.

> Including sun4i header instead of sun7i
> prevents using sun7i specific defines.
>
> Substitute header inclusion in sun7i-a20.dtsi
> using right one.

This sentence is redundant with the first one.

Dropped the first one, corrected the wrapping and applied, thanks

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachments:
(No filename) (581.00 B)
 signature.asc (849.00 B)
 Download all attachments

2018-02-01 15:38:53

by Giulio Benetti

[permalink] [raw]
Subject: Re: [PATCH] arm: dts: sun7i: include correct ccu clock header

Il 01/02/2018 16:19, Maxime Ripard ha scritto:
> Hi,
>
> On Wed, Jan 31, 2018 at 08:31:26PM +0100, Giulio Benetti wrote:
>> Include correct clock header sun7i-a20-ccu.h
>> instead of sun4i-a20-ccu.h.
>
> You should wrap at 72 characters.

Ok, keep in mind for next patches. Thanks

>
>> Including sun4i header instead of sun7i
>> prevents using sun7i specific defines.
>>
>> Substitute header inclusion in sun7i-a20.dtsi
>> using right one.
>
> This sentence is redundant with the first one.

Yes, you're right. Thanks

>
> Dropped the first one, corrected the wrapping and applied, thanks
>
> Maxime
>


--
Giulio Benetti
R&D Manager &
Advanced Research

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642