2021-05-19 18:10:40

by Yang Yingliang

Subject: [PATCH -next] scsi: qedf: use vzalloc() instead of vmalloc()/memset(0)

Use vzalloc() instead of vmalloc() and memset(0) to simpify
the code.

Signed-off-by: Yang Yingliang <[email protected]>
---
drivers/scsi/qedf/qedf_dbg.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/qedf/qedf_dbg.c b/drivers/scsi/qedf/qedf_dbg.c
index e0387e495261..0d2aed82882a 100644
--- a/drivers/scsi/qedf/qedf_dbg.c
+++ b/drivers/scsi/qedf/qedf_dbg.c
@@ -106,11 +106,10 @@ qedf_dbg_info(struct qedf_dbg_ctx *qedf, const char *func, u32 line,
int
qedf_alloc_grc_dump_buf(u8 **buf, uint32_t len)
{
- *buf = vmalloc(len);
+ *buf = vzalloc(len);
if (!(*buf))
return -ENOMEM;

- memset(*buf, 0, len);
return 0;
}

--
2.25.1

2021-05-19 18:22:51

by Himanshu Madhani

Subject: Re: [PATCH -next] scsi: qedf: use vzalloc() instead of vmalloc()/memset(0)

On 5/18/21 8:20 AM, Yang Yingliang wrote:
> Use vzalloc() instead of vmalloc() and memset(0) to simpify
> the code.
>
> Signed-off-by: Yang Yingliang <[email protected]>
> ---
> drivers/scsi/qedf/qedf_dbg.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/qedf/qedf_dbg.c b/drivers/scsi/qedf/qedf_dbg.c
> index e0387e495261..0d2aed82882a 100644
> --- a/drivers/scsi/qedf/qedf_dbg.c
> +++ b/drivers/scsi/qedf/qedf_dbg.c
> @@ -106,11 +106,10 @@ qedf_dbg_info(struct qedf_dbg_ctx *qedf, const char *func, u32 line,
> int
> qedf_alloc_grc_dump_buf(u8 **buf, uint32_t len)
> {
> - *buf = vmalloc(len);
> + *buf = vzalloc(len);
> if (!(*buf))
> return -ENOMEM;
>
> - memset(*buf, 0, len);
> return 0;
> }
>
>

Looks Good.

Reviewed-by: Himanshu Madhani <[email protected]>

--
Himanshu Madhani Oracle Linux Engineering

2021-05-21 20:32:29

by Martin K. Petersen

Subject: Re: [PATCH -next] scsi: qedf: use vzalloc() instead of vmalloc()/memset(0)

Yang,

> Use vzalloc() instead of vmalloc() and memset(0) to simpify the code.

Applied to 5.14/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2021-05-26 04:33:33

by Martin K. Petersen

Subject: Re: [PATCH -next] scsi: qedf: use vzalloc() instead of vmalloc()/memset(0)

On Tue, 18 May 2021 21:20:18 +0800, Yang Yingliang wrote:

> Use vzalloc() instead of vmalloc() and memset(0) to simpify
> the code.

Applied to 5.14/scsi-queue, thanks!

[1/1] scsi: qedf: use vzalloc() instead of vmalloc()/memset(0)
https://git.kernel.org/mkp/scsi/c/2a38d2a8b4a6

--
Martin K. Petersen Oracle Linux Engineering