2018-03-16 05:39:00

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warning after merge of the tip tree

Hi all,

After merging the tip tree, yesterday's linux-next build (x86_64 allnoconfig)
produced this warning:

kernel/cpu.c:129:13: warning: 'cpuhp_is_ap_state' defined but not used [-Wunused-function]
static bool cpuhp_is_ap_state(enum cpuhp_state state)
^~~~~~~~~~~~~~~~~

Introduced by commit

17a2f1ced028 ("cpu/hotplug: Merge cpuhp_bp_states and cpuhp_ap_states")

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2018-03-16 05:55:27

by Dou Liyang

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the tip tree

Hi Stephen,

At 03/16/2018 01:37 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the tip tree, yesterday's linux-next build (x86_64 allnoconfig)
> produced this warning:
>
> kernel/cpu.c:129:13: warning: 'cpuhp_is_ap_state' defined but not used [-Wunused-function]
> static bool cpuhp_is_ap_state(enum cpuhp_state state)
> ^~~~~~~~~~~~~~~~~
>

Yes, Jiangshan has replaced it with cpuhp_hp_states. So it is obsolete,
it should be removed.

Thanks,
dou.
> Introduced by commit
>
> 17a2f1ced028 ("cpu/hotplug: Merge cpuhp_bp_states and cpuhp_ap_states")
>



2018-03-16 06:05:28

by Dou Liyang

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the tip tree

Hi Stephen,

At 03/16/2018 01:52 PM, Dou Liyang wrote:
> Hi Stephen,
>
> At 03/16/2018 01:37 PM, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the tip tree, yesterday's linux-next build (x86_64
>> allnoconfig)
>> produced this warning:
>>
>> kernel/cpu.c:129:13: warning: 'cpuhp_is_ap_state' defined but not used
>> [-Wunused-function]
>> ? static bool cpuhp_is_ap_state(enum cpuhp_state state)
>> ????????????? ^~~~~~~~~~~~~~~~~
>>
>
> Yes, Jiangshan has replaced it with cpuhp_hp_states. So it is obsolete,
> it should be removed.
>

I made a mistake, It also be called by cpuhp_thread_fun() and
cpuhp_issue_call(), let me have a look carefully.

Thanks,
dou.

> Thanks,
> ????dou.
>> Introduced by commit
>>
>> ?? 17a2f1ced028 ("cpu/hotplug: Merge cpuhp_bp_states and
>> cpuhp_ap_states")
>>



2018-03-16 07:56:42

by Thomas Gleixner

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the tip tree

On Fri, 16 Mar 2018, Stephen Rothwell wrote:

> Hi all,
>
> After merging the tip tree, yesterday's linux-next build (x86_64 allnoconfig)
> produced this warning:
>
> kernel/cpu.c:129:13: warning: 'cpuhp_is_ap_state' defined but not used [-Wunused-function]
> static bool cpuhp_is_ap_state(enum cpuhp_state state)
> ^~~~~~~~~~~~~~~~~
>
> Introduced by commit
>
> 17a2f1ced028 ("cpu/hotplug: Merge cpuhp_bp_states and cpuhp_ap_states")

Fix is queued already. Did not make it into the branch you pull yet.

Thanks,

tglx