2023-12-15 10:03:03

by Wang Jinchao

[permalink] [raw]
Subject: [PATCH] drm/nouveau/fifo: remove duplicated including

rm second including of chid.h

Signed-off-by: Wang Jinchao <[email protected]>
---
drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c
index 87a62d4ff4bd..7d4716dcd512 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c
@@ -24,7 +24,6 @@
#include "chan.h"
#include "chid.h"
#include "cgrp.h"
-#include "chid.h"
#include "runl.h"
#include "priv.h"

--
2.40.0



2024-01-08 17:23:37

by Danilo Krummrich

[permalink] [raw]
Subject: Re: [PATCH] drm/nouveau/fifo: remove duplicated including

Hi Wang,

there is another patch [1] to fix this, which already made it upstream.

- Danilo

[1] https://patchwork.freedesktop.org/patch/msgid/[email protected]

On 12/15/23 11:02, Wang Jinchao wrote:
> rm second including of chid.h
>
> Signed-off-by: Wang Jinchao <[email protected]>
> ---
> drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c
> index 87a62d4ff4bd..7d4716dcd512 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c
> @@ -24,7 +24,6 @@
> #include "chan.h"
> #include "chid.h"
> #include "cgrp.h"
> -#include "chid.h"
> #include "runl.h"
> #include "priv.h"
>