2019-06-20 17:23:50

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: [PATCH v2 01/22] ABI: sysfs-bus-pci-devices-aer_stats uses an invalid tag

According with Documentation/ABI/, the right tag to describe
an ABI symbol is "What:", and not "Where:".

Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---
.../ABI/testing/sysfs-bus-pci-devices-aer_stats | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats b/Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats
index 4b0318c99507..ff229d71961c 100644
--- a/Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats
+++ b/Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats
@@ -9,7 +9,7 @@ errors may be "seen" / reported by the link partner and not the
problematic endpoint itself (which may report all counters as 0 as it never
saw any problems).

-Where: /sys/bus/pci/devices/<dev>/aer_dev_correctable
+What: /sys/bus/pci/devices/<dev>/aer_dev_correctable
Date: July 2018
Kernel Version: 4.19.0
Contact: [email protected], [email protected]
@@ -31,7 +31,7 @@ Header Log Overflow 0
TOTAL_ERR_COR 2
-------------------------------------------------------------------------

-Where: /sys/bus/pci/devices/<dev>/aer_dev_fatal
+What: /sys/bus/pci/devices/<dev>/aer_dev_fatal
Date: July 2018
Kernel Version: 4.19.0
Contact: [email protected], [email protected]
@@ -62,7 +62,7 @@ TLP Prefix Blocked Error 0
TOTAL_ERR_FATAL 0
-------------------------------------------------------------------------

-Where: /sys/bus/pci/devices/<dev>/aer_dev_nonfatal
+What: /sys/bus/pci/devices/<dev>/aer_dev_nonfatal
Date: July 2018
Kernel Version: 4.19.0
Contact: [email protected], [email protected]
@@ -103,19 +103,19 @@ collectors) that are AER capable. These indicate the number of error messages as
device, so these counters include them and are thus cumulative of all the error
messages on the PCI hierarchy originating at that root port.

-Where: /sys/bus/pci/devices/<dev>/aer_stats/aer_rootport_total_err_cor
+What: /sys/bus/pci/devices/<dev>/aer_stats/aer_rootport_total_err_cor
Date: July 2018
Kernel Version: 4.19.0
Contact: [email protected], [email protected]
Description: Total number of ERR_COR messages reported to rootport.

-Where: /sys/bus/pci/devices/<dev>/aer_stats/aer_rootport_total_err_fatal
+What: /sys/bus/pci/devices/<dev>/aer_stats/aer_rootport_total_err_fatal
Date: July 2018
Kernel Version: 4.19.0
Contact: [email protected], [email protected]
Description: Total number of ERR_FATAL messages reported to rootport.

-Where: /sys/bus/pci/devices/<dev>/aer_stats/aer_rootport_total_err_nonfatal
+What: /sys/bus/pci/devices/<dev>/aer_stats/aer_rootport_total_err_nonfatal
Date: July 2018
Kernel Version: 4.19.0
Contact: [email protected], [email protected]
--
2.21.0


2019-06-20 18:23:10

by Bjorn Helgaas

[permalink] [raw]
Subject: Re: [PATCH v2 01/22] ABI: sysfs-bus-pci-devices-aer_stats uses an invalid tag

On Thu, Jun 20, 2019 at 12:23 PM Mauro Carvalho Chehab
<[email protected]> wrote:
>
> According with Documentation/ABI/, the right tag to describe
> an ABI symbol is "What:", and not "Where:".
>
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>

Acked-by: Bjorn Helgaas <[email protected]>

I assume somebody else will merge this series as a whole.

> ---
> .../ABI/testing/sysfs-bus-pci-devices-aer_stats | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats b/Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats
> index 4b0318c99507..ff229d71961c 100644
> --- a/Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats
> +++ b/Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats
> @@ -9,7 +9,7 @@ errors may be "seen" / reported by the link partner and not the
> problematic endpoint itself (which may report all counters as 0 as it never
> saw any problems).
>
> -Where: /sys/bus/pci/devices/<dev>/aer_dev_correctable
> +What: /sys/bus/pci/devices/<dev>/aer_dev_correctable
> Date: July 2018
> Kernel Version: 4.19.0
> Contact: [email protected], [email protected]
> @@ -31,7 +31,7 @@ Header Log Overflow 0
> TOTAL_ERR_COR 2
> -------------------------------------------------------------------------
>
> -Where: /sys/bus/pci/devices/<dev>/aer_dev_fatal
> +What: /sys/bus/pci/devices/<dev>/aer_dev_fatal
> Date: July 2018
> Kernel Version: 4.19.0
> Contact: [email protected], [email protected]
> @@ -62,7 +62,7 @@ TLP Prefix Blocked Error 0
> TOTAL_ERR_FATAL 0
> -------------------------------------------------------------------------
>
> -Where: /sys/bus/pci/devices/<dev>/aer_dev_nonfatal
> +What: /sys/bus/pci/devices/<dev>/aer_dev_nonfatal
> Date: July 2018
> Kernel Version: 4.19.0
> Contact: [email protected], [email protected]
> @@ -103,19 +103,19 @@ collectors) that are AER capable. These indicate the number of error messages as
> device, so these counters include them and are thus cumulative of all the error
> messages on the PCI hierarchy originating at that root port.
>
> -Where: /sys/bus/pci/devices/<dev>/aer_stats/aer_rootport_total_err_cor
> +What: /sys/bus/pci/devices/<dev>/aer_stats/aer_rootport_total_err_cor
> Date: July 2018
> Kernel Version: 4.19.0
> Contact: [email protected], [email protected]
> Description: Total number of ERR_COR messages reported to rootport.
>
> -Where: /sys/bus/pci/devices/<dev>/aer_stats/aer_rootport_total_err_fatal
> +What: /sys/bus/pci/devices/<dev>/aer_stats/aer_rootport_total_err_fatal
> Date: July 2018
> Kernel Version: 4.19.0
> Contact: [email protected], [email protected]
> Description: Total number of ERR_FATAL messages reported to rootport.
>
> -Where: /sys/bus/pci/devices/<dev>/aer_stats/aer_rootport_total_err_nonfatal
> +What: /sys/bus/pci/devices/<dev>/aer_stats/aer_rootport_total_err_nonfatal
> Date: July 2018
> Kernel Version: 4.19.0
> Contact: [email protected], [email protected]
> --
> 2.21.0
>