2022-11-16 18:46:49

by Georgi Vlaev

Subject: [PATCH v4 1/5] dt-bindings: ti, sci: Add lpm region and firmware-name

From: Dave Gerlach <[email protected]>

Add documentation for the lpm region which tells the ti-sci driver where
to load the FS Stub low power mode firmware and also the firmware-name
which tells the driver which binary to load. Both of these are optional
for normal system operation but required to enabled suspend-to-mem usage
of Deep Sleep state.

Signed-off-by: Dave Gerlach <[email protected]>
Signed-off-by: Vibhore Vardhan <[email protected]>
Signed-off-by: Georgi Vlaev <[email protected]>
---
.../bindings/arm/keystone/ti,sci.yaml | 21 +++++++++++++++----
1 file changed, 17 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
index 34f5f877d444..4c5213de24bc 100644
--- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
+++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
@@ -42,12 +42,19 @@ properties:
- const: ti,am654-sci

reg-names:
- description: |
- Specifies the debug messages memory mapped region that is optionally
- made available from TI-SCI controller.
- const: debug_messages
+ items:
+ - const: debug_messages
+ - const: lpm
+ minItems: 1

reg:
+ items:
+ - description: |
+ Specifies the debug messages memory mapped region that is optionally
+ made available from TI-SCI controller.
+ - description: |
+ Specifies the lpm memory mapped region where the FS Stub low power
+ firmware is to be loaded.
minItems: 1

mbox-names:
@@ -83,6 +90,12 @@ properties:
type: object
$ref: /schemas/reset/ti,sci-reset.yaml#

+ firmware-name:
+ description: |
+ Name of binary of FS Stub low power firmware located on the
+ firmware search path.
+ $ref: /schemas/types.yaml#/definitions/string
+
required:
- compatible
- mbox-names
--
2.30.2

2022-11-18 14:28:48

by Krzysztof Kozlowski

Subject: Re: [PATCH v4 1/5] dt-bindings: ti, sci: Add lpm region and firmware-name

On 16/11/2022 19:13, Georgi Vlaev wrote:
> From: Dave Gerlach <[email protected]>
>
> Add documentation for the lpm region which tells the ti-sci driver where
> to load the FS Stub low power mode firmware and also the firmware-name
> which tells the driver which binary to load. Both of these are optional
> for normal system operation but required to enabled suspend-to-mem usage
> of Deep Sleep state.
>

I think you got here Rob's tag after sending v4.

Reviewed-by: Rob Herring <[email protected]>

Best regards,
Krzysztof

2022-11-21 22:59:52

by Georgi Vlaev

Subject: Re: [PATCH v4 1/5] dt-bindings: ti, sci: Add lpm region and firmware-name

Hi,

On 11/18/22 14:59, Krzysztof Kozlowski wrote:
> On 16/11/2022 19:13, Georgi Vlaev wrote:
>> From: Dave Gerlach <[email protected]>
>>
>> Add documentation for the lpm region which tells the ti-sci driver where
>> to load the FS Stub low power mode firmware and also the firmware-name
>> which tells the driver which binary to load. Both of these are optional
>> for normal system operation but required to enabled suspend-to-mem usage
>> of Deep Sleep state.
>>
>
> I think you got here Rob's tag after sending v4.
>
> Reviewed-by: Rob Herring <[email protected]>
>

I will pick it up in v5.
Thanks.

> Best regards,
> Krzysztof
>

--
Regards,
Georgi