2022-11-22 15:53:56

by Andy Shevchenko

Subject: [PATCH v3 4/4] xhci: Convert to use list_count()

The list API now provides the list_count() to help with counting
existing nodes in the list. Utilise it.

Signed-off-by: Andy Shevchenko <[email protected]>
---
v3: no change
v2: no change
drivers/usb/host/xhci-ring.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index ad81e9a508b1..817c31e3b0c8 100644
--- a/drivers/usb/host/xhci-ring.c
+++ b/drivers/usb/host/xhci-ring.c
@@ -2532,7 +2532,6 @@ static int handle_tx_event(struct xhci_hcd *xhci,
union xhci_trb *ep_trb;
int status = -EINPROGRESS;
struct xhci_ep_ctx *ep_ctx;
- struct list_head *tmp;
u32 trb_comp_code;
int td_num = 0;
bool handling_skipped_tds = false;
@@ -2580,10 +2579,8 @@ static int handle_tx_event(struct xhci_hcd *xhci,
}

/* Count current td numbers if ep->skip is set */
- if (ep->skip) {
- list_for_each(tmp, &ep_ring->td_list)
- td_num++;
- }
+ if (ep->skip)
+ td_num += list_count(&ep_ring->td_list);

/* Look for common error cases */
switch (trb_comp_code) {
--
2.35.1

2022-11-23 15:04:43

by Mathias Nyman

Subject: Re: [PATCH v3 4/4] xhci: Convert to use list_count()

On 22.11.2022 17.35, Andy Shevchenko wrote:
> The list API now provides the list_count() to help with counting
> existing nodes in the list. Utilise it.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> v3: no change
> v2: no change
> drivers/usb/host/xhci-ring.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>

Acked-by: Mathias Nyman <[email protected]>