2022-07-08 18:45:55

by Jonathan Toppins

[permalink] [raw]
Subject: [PATCH iproute2 next v4 2/2] bond: add mac_filter option

Add ability to set bonding option `mac_filter`. Values greater than zero
represent the maximum hashtable size the mac filter is allowed to grow
to, zero disables the filter.

Signed-off-by: Jonathan Toppins <[email protected]>
---

Notes:
v4:
* rebase onto latest next branch

include/uapi/linux/if_link.h | 1 +
ip/iplink_bond.c | 15 +++++++++++++++
2 files changed, 16 insertions(+)

diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
index e0fbbfeeb3a1..529ae4faa7e2 100644
--- a/include/uapi/linux/if_link.h
+++ b/include/uapi/linux/if_link.h
@@ -934,6 +934,7 @@ enum {
IFLA_BOND_AD_LACP_ACTIVE,
IFLA_BOND_MISSED_MAX,
IFLA_BOND_NS_IP6_TARGET,
+ IFLA_BOND_MAC_FILTER,
__IFLA_BOND_MAX,
};

diff --git a/ip/iplink_bond.c b/ip/iplink_bond.c
index 7943499e0adf..fb7236c58253 100644
--- a/ip/iplink_bond.c
+++ b/ip/iplink_bond.c
@@ -157,6 +157,7 @@ static void print_explain(FILE *f)
" [ ad_actor_sys_prio SYSPRIO ]\n"
" [ ad_actor_system LLADDR ]\n"
" [ arp_missed_max MISSED_MAX ]\n"
+ " [ mac_filter HASH_SIZE ]\n"
"\n"
"BONDMODE := balance-rr|active-backup|balance-xor|broadcast|802.3ad|balance-tlb|balance-alb\n"
"ARP_VALIDATE := none|active|backup|all|filter|filter_active|filter_backup\n"
@@ -410,6 +411,14 @@ static int bond_parse_opt(struct link_util *lu, int argc, char **argv,
}
addattr8(n, 1024, IFLA_BOND_TLB_DYNAMIC_LB,
tlb_dynamic_lb);
+ } else if (matches(*argv, "mac_filter") == 0) {
+ __u8 mac_filter;
+ NEXT_ARG();
+ if (get_u8(&mac_filter, *argv, 0)) {
+ invarg("invalid mac_filter", *argv);
+ return -1;
+ }
+ addattr8(n, 1024, IFLA_BOND_MAC_FILTER, mac_filter);
} else if (matches(*argv, "help") == 0) {
explain();
return -1;
@@ -491,6 +500,12 @@ static void bond_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
"arp_missed_max %u ",
rta_getattr_u8(tb[IFLA_BOND_MISSED_MAX]));

+ if (tb[IFLA_BOND_MAC_FILTER])
+ print_uint(PRINT_ANY,
+ "mac_filter",
+ "mac_filter %u ",
+ rta_getattr_u8(tb[IFLA_BOND_MAC_FILTER]));
+
if (tb[IFLA_BOND_ARP_IP_TARGET]) {
struct rtattr *iptb[BOND_MAX_ARP_TARGETS + 1];

--
2.31.1