Hi ChiYuan,
On 11/2/20 3:42 AM, cy_huang wrote:
> From: ChiYuan Huang <[email protected]>
>
> Add support for RT4505 flash LED controller. It can support up to 1.5A
> flash current with hardware timeout and low input voltage protection.
>
> Signed-off-by: ChiYuan Huang <[email protected]>
> ---
> Changes since v1 to v2
>
> - Create flash directory into drvers/leds.
> - Coding style fix to meet 80 charactors per line limit.
> - Refine the description in the Kconfig help text.
> - Change all descriptions for 'led' text to uppercase 'LED'.
>
> ---
> drivers/leds/Kconfig | 2 +
> drivers/leds/Makefile | 3 +
> drivers/leds/flash/Kconfig | 17 ++
> drivers/leds/flash/Makefile | 2 +
> drivers/leds/flash/leds-rt4505.c | 430 +++++++++++++++++++++++++++++++++++++++
> 5 files changed, 454 insertions(+)
> create mode 100644 drivers/leds/flash/Kconfig
> create mode 100644 drivers/leds/flash/Makefile
> create mode 100644 drivers/leds/flash/leds-rt4505.c
Acked-by: Jacek Anaszewski <[email protected]>
--
Best regards,
Jacek Anaszewski
Hi, Jacek:
Jacek Anaszewski <[email protected]> 於 2020年11月3日 週二 上午4:44寫道：
>
> Hi ChiYuan,
>
> On 11/2/20 3:42 AM, cy_huang wrote:
> > From: ChiYuan Huang <[email protected]>
> >
> > Add support for RT4505 flash LED controller. It can support up to 1.5A
> > flash current with hardware timeout and low input voltage protection.
> >
> > Signed-off-by: ChiYuan Huang <[email protected]>
> > ---
> > Changes since v1 to v2
> >
> > - Create flash directory into drvers/leds.
> > - Coding style fix to meet 80 charactors per line limit.
> > - Refine the description in the Kconfig help text.
> > - Change all descriptions for 'led' text to uppercase 'LED'.
> >
> > ---
> > drivers/leds/Kconfig | 2 +
> > drivers/leds/Makefile | 3 +
> > drivers/leds/flash/Kconfig | 17 ++
> > drivers/leds/flash/Makefile | 2 +
> > drivers/leds/flash/leds-rt4505.c | 430 +++++++++++++++++++++++++++++++++++++++
> > 5 files changed, 454 insertions(+)
> > create mode 100644 drivers/leds/flash/Kconfig
> > create mode 100644 drivers/leds/flash/Makefile
> > create mode 100644 drivers/leds/flash/leds-rt4505.c
>
> Acked-by: Jacek Anaszewski <[email protected]>
>
Any problem with this patch? Do I need to submit it again?
> --
> Best regards,
> Jacek Anaszewski
Hi!
> > > create mode 100644 drivers/leds/flash/Kconfig
> > > create mode 100644 drivers/leds/flash/Makefile
> > > create mode 100644 drivers/leds/flash/leds-rt4505.c
> >
> > Acked-by: Jacek Anaszewski <[email protected]>
> >
> Any problem with this patch? Do I need to submit it again?
It won't apply on current next.
So please: Merge ACKs, reorder it so that docs goes first, port it to
To gitolite.kernel.org:pub/scm/linux/kernel/git/pavel/linux-leds.git
34731ed13e8a..85674b0e40d9 for-next -> for-next
and resubmit.
Thanks you,
Pavel
--
http://www.livejournal.com/~pavelmachek
Pavel Machek <[email protected]> 於 2021年3月25日 週四 下午6:01寫道：
>
> Hi!
>
> > > > create mode 100644 drivers/leds/flash/Kconfig
> > > > create mode 100644 drivers/leds/flash/Makefile
> > > > create mode 100644 drivers/leds/flash/leds-rt4505.c
> > >
> > > Acked-by: Jacek Anaszewski <[email protected]>
> > >
> > Any problem with this patch? Do I need to submit it again?
>
> It won't apply on current next.
>
> So please: Merge ACKs, reorder it so that docs goes first, port it to
>
> To gitolite.kernel.org:pub/scm/linux/kernel/git/pavel/linux-leds.git
> 34731ed13e8a..85674b0e40d9 for-next -> for-next
>
> and resubmit.
Thx. It's clear.
So the next I need to do is
1. Merge ACKs
2. Reorder this patch from the docs first
After done, do I need to change the patch revision from v2 to v3
before submitng it?
>
> Thanks you,
> Pavel
> --
> http://www.livejournal.com/~pavelmachek
On Thu 2021-03-25 18:19:03, ChiYuan Huang wrote:
> Pavel Machek <[email protected]> 於 2021年3月25日 週四 下午6:01寫道：
> >
> > Hi!
> >
> > > > > create mode 100644 drivers/leds/flash/Kconfig
> > > > > create mode 100644 drivers/leds/flash/Makefile
> > > > > create mode 100644 drivers/leds/flash/leds-rt4505.c
> > > >
> > > > Acked-by: Jacek Anaszewski <[email protected]>
> > > >
> > > Any problem with this patch? Do I need to submit it again?
> >
> > It won't apply on current next.
> >
> > So please: Merge ACKs, reorder it so that docs goes first, port it to
> >
> > To gitolite.kernel.org:pub/scm/linux/kernel/git/pavel/linux-leds.git
> > 34731ed13e8a..85674b0e40d9 for-next -> for-next
> >
> > and resubmit.
>
> Thx. It's clear.
> So the next I need to do is
> 1. Merge ACKs
> 2. Reorder this patch from the docs first
>
> After done, do I need to change the patch revision from v2 to v3
> before submitng it?
Most important step is
0. port it to the for-next tree.
And yes, you can increase patch revision.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek