2023-08-01 02:05:25

by Lin Ma

[permalink] [raw]
Subject: Re: [PATCH net] net: dcb: choose correct policy to parse DCB_ATTR_BCN

Hello Markus,

>
> …
> > This patch use correct dcbnl_bcn_nest policy to parse the
> > tb[DCB_ATTR_BCN] nested TLV.
>
> Are imperative change descriptions still preferred?
>
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc3#n94
>
> Regards,
> Markus

Yeah, thanks for reminding me. I haven't been paying attention to that and I will remember this ever since. :D

Regards,
Lin


2023-08-01 06:49:44

by Dan Carpenter

[permalink] [raw]
Subject: Re: [PATCH net] net: dcb: choose correct policy to parse DCB_ATTR_BCN

On Tue, Aug 01, 2023 at 09:34:17AM +0800, Lin Ma wrote:
> Hello Markus,
>
> >
> > …
> > > This patch use correct dcbnl_bcn_nest policy to parse the
> > > tb[DCB_ATTR_BCN] nested TLV.
> >
> > Are imperative change descriptions still preferred?
> >
> > See also:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc3#n94
> >
> > Regards,
> > Markus
>
> Yeah, thanks for reminding me. I haven't been paying attention to that
> and I will remember this ever since. :D

Simon reviewed the patch already. Don't listen to Markus. He's banned
from vger.

https://lore.kernel.org/all/2023073123-poser-panhandle-1cb7@gregkh/

regards,
dan carpenter