2021-08-11 08:56:27

by Geert Uytterhoeven

Subject: [PATCH] memblock: Add missing debug code to memblock_add_node()

All other memblock APIs built on top of memblock_add_range() contain
debug code to print their parameters.

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
mm/memblock.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/mm/memblock.c b/mm/memblock.c
index de7b553baa50004c..57a9849a5d820c34 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -665,6 +665,11 @@ static int __init_memblock memblock_add_range(struct memblock_type *type,
int __init_memblock memblock_add_node(phys_addr_t base, phys_addr_t size,
int nid)
{
+ phys_addr_t end = base + size - 1;
+
+ memblock_dbg("%s: [%pa-%pa] nid=%d %pS\n", __func__,
+ &base, &end, nid, (void *)_RET_IP_);
+
return memblock_add_range(&memblock.memory, base, size, nid, 0);
}

--
2.25.1

2021-08-11 09:39:58

by David Hildenbrand

Subject: Re: [PATCH] memblock: Add missing debug code to memblock_add_node()

On 11.08.21 10:54, Geert Uytterhoeven wrote:
> All other memblock APIs built on top of memblock_add_range() contain
> debug code to print their parameters.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> mm/memblock.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/mm/memblock.c b/mm/memblock.c
> index de7b553baa50004c..57a9849a5d820c34 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -665,6 +665,11 @@ static int __init_memblock memblock_add_range(struct memblock_type *type,
> int __init_memblock memblock_add_node(phys_addr_t base, phys_addr_t size,
> int nid)
> {
> + phys_addr_t end = base + size - 1;
> +
> + memblock_dbg("%s: [%pa-%pa] nid=%d %pS\n", __func__,
> + &base, &end, nid, (void *)_RET_IP_);
> +
> return memblock_add_range(&memblock.memory, base, size, nid, 0);
> }
>
>

Reviewed-by: David Hildenbrand <[email protected]>

--
Thanks,

David / dhildenb

2021-08-11 13:10:12

by Mike Rapoport

Subject: Re: [PATCH] memblock: Add missing debug code to memblock_add_node()

On Wed, Aug 11, 2021 at 10:54:36AM +0200, Geert Uytterhoeven wrote:
> All other memblock APIs built on top of memblock_add_range() contain
> debug code to print their parameters.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Applied for 5.15,
Thanks!

--
Sincerely yours,
Mike.