2021-03-23 16:44:15

by Wong Vee Khee

Subject: [PATCH net-next 1/2] net: phy: add genphy_c45_loopback

Add generic code to enable C45 PHY loopback into the common phy-c45.c
file. This will allow C45 PHY drivers aceess this by setting
.set_loopback.

Suggested-by: Heiner Kallweit <[email protected]>
Signed-off-by: Wong Vee Khee <[email protected]>
---
drivers/net/phy/phy-c45.c | 8 ++++++++
include/linux/phy.h | 1 +
2 files changed, 9 insertions(+)

diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c
index 077f2929c45e..91e3acb9e397 100644
--- a/drivers/net/phy/phy-c45.c
+++ b/drivers/net/phy/phy-c45.c
@@ -560,6 +560,14 @@ int gen10g_config_aneg(struct phy_device *phydev)
}
EXPORT_SYMBOL_GPL(gen10g_config_aneg);

+int genphy_c45_loopback(struct phy_device *phydev, bool enable)
+{
+ return phy_modify_mmd(phydev, MDIO_MMD_PCS, MDIO_CTRL1,
+ MDIO_PCS_CTRL1_LOOPBACK,
+ enable ? MDIO_PCS_CTRL1_LOOPBACK : 0);
+}
+EXPORT_SYMBOL_GPL(genphy_c45_loopback);
+
struct phy_driver genphy_c45_driver = {
.phy_id = 0xffffffff,
.phy_id_mask = 0xffffffff,
diff --git a/include/linux/phy.h b/include/linux/phy.h
index 1a12e4436b5b..8e2cf84b2318 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -1532,6 +1532,7 @@ int genphy_c45_read_mdix(struct phy_device *phydev);
int genphy_c45_pma_read_abilities(struct phy_device *phydev);
int genphy_c45_read_status(struct phy_device *phydev);
int genphy_c45_config_aneg(struct phy_device *phydev);
+int genphy_c45_loopback(struct phy_device *phydev, bool enable);

/* Generic C45 PHY driver */
extern struct phy_driver genphy_c45_driver;
--
2.25.1

2021-03-25 02:56:21

by Heiner Kallweit

Subject: Re: [PATCH net-next 1/2] net: phy: add genphy_c45_loopback

On 23.03.2021 17:46, Wong Vee Khee wrote:
> Add generic code to enable C45 PHY loopback into the common phy-c45.c
> file. This will allow C45 PHY drivers aceess this by setting
> .set_loopback.
>
> Suggested-by: Heiner Kallweit <[email protected]>
> Signed-off-by: Wong Vee Khee <[email protected]>
> ---
> drivers/net/phy/phy-c45.c | 8 ++++++++
> include/linux/phy.h | 1 +
> 2 files changed, 9 insertions(+)
>

LGTM

Reviewed-by: Heiner Kallweit <[email protected]>

2021-03-25 03:30:55

by Andrew Lunn

Subject: Re: [PATCH net-next 1/2] net: phy: add genphy_c45_loopback

On Wed, Mar 24, 2021 at 12:46:40AM +0800, Wong Vee Khee wrote:
> Add generic code to enable C45 PHY loopback into the common phy-c45.c
> file. This will allow C45 PHY drivers aceess this by setting
> .set_loopback.
>
> Suggested-by: Heiner Kallweit <[email protected]>
> Signed-off-by: Wong Vee Khee <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew