2020-05-04 11:37:30

by Jason Yan

Subject: [PATCH] dmaengine: qcom_hidma: use true,false for bool variable

Fix the following coccicheck warning:

drivers/dma/qcom/hidma.c:553:1-17: WARNING: Assignment of 0/1 to bool
variable

Signed-off-by: Jason Yan <[email protected]>
---
drivers/dma/qcom/hidma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c
index 87490e125bc3..0a6d3ea08c78 100644
--- a/drivers/dma/qcom/hidma.c
+++ b/drivers/dma/qcom/hidma.c
@@ -550,7 +550,7 @@ static void hidma_free_chan_resources(struct dma_chan *dmach)
kfree(mdesc);
}

- mchan->allocated = 0;
+ mchan->allocated = false;
spin_unlock_irqrestore(&mchan->lock, irqflags);
}

--
2.21.1

2020-05-04 20:05:26

by Sinan Kaya

Subject: Re: [PATCH] dmaengine: qcom_hidma: use true,false for bool variable

On 5/4/2020 7:34 AM, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/dma/qcom/hidma.c:553:1-17: WARNING: Assignment of 0/1 to bool
> variable
>
> Signed-off-by: Jason Yan <[email protected]>
> ---
> drivers/dma/qcom/hidma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c
> index 87490e125bc3..0a6d3ea08c78 100644
> --- a/drivers/dma/qcom/hidma.c
> +++ b/drivers/dma/qcom/hidma.c
> @@ -550,7 +550,7 @@ static void hidma_free_chan_resources(struct dma_chan *dmach)
> kfree(mdesc);
> }
>
> - mchan->allocated = 0;
> + mchan->allocated = false;
> spin_unlock_irqrestore(&mchan->lock, irqflags);
> }

Acked By: Sinan Kaya <[email protected]>

2020-05-13 11:37:27

by Vinod Koul

Subject: Re: [PATCH] dmaengine: qcom_hidma: use true,false for bool variable

On 04-05-20, 19:34, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/dma/qcom/hidma.c:553:1-17: WARNING: Assignment of 0/1 to bool
> variable

Applied, thanks

--
~Vinod