2021-07-19 21:11:57

by Daniel Díaz

[permalink] [raw]
Subject: Re: [PATCH 5.4 000/148] 5.4.134-rc2 review

Hello!


On 7/19/21 1:45 PM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.4.134 release.
> There are 148 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 21 Jul 2021 18:42:54 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.134-rc2.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

Perf fails to compile in 5.4 on Arm, Arm64, i386 and x86 (GCC 11 and GCC 7.3):

builtin-report.c:669:12: error: 'process_attr' used but never defined [-Werror]
669 | static int process_attr(struct perf_tool *tool __maybe_unused,
| ^~~~~~~~~~~~
cc1: all warnings being treated as errors
make[3]: *** [/builds/linux/tools/build/Makefile.build:96: /home/tuxbuild/.cache/tuxmake/builds/current/builtin-report.o] Error 1

Greetings!

Daniel Díaz
[email protected]


2021-07-20 00:21:26

by Daniel Díaz

[permalink] [raw]
Subject: Re: [PATCH 5.4 000/148] 5.4.134-rc2 review

Hello!

On 7/19/21 3:46 PM, Daniel Díaz wrote:
> On 7/19/21 1:45 PM, Greg Kroah-Hartman wrote:
>> This is the start of the stable review cycle for the 5.4.134 release.
>> There are 148 patches in this series, all will be posted as a response
>> to this one.  If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Wed, 21 Jul 2021 18:42:54 +0000.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>>     https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.134-rc2.gz
>> or in the git tree and branch at:
>>     git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
>> and the diffstat can be found below.
>>
>> thanks,
>>
>> greg k-h
>
> Perf fails to compile in 5.4 on Arm, Arm64, i386 and x86 (GCC 11 and GCC 7.3):
>
>   builtin-report.c:669:12: error: 'process_attr' used but never defined [-Werror]
>     669 | static int process_attr(struct perf_tool *tool __maybe_unused,
>         |            ^~~~~~~~~~~~
>   cc1: all warnings being treated as errors
>   make[3]: *** [/builds/linux/tools/build/Makefile.build:96: /home/tuxbuild/.cache/tuxmake/builds/current/builtin-report.o] Error 1

Bisection points to ee7531fb817c ("perf report: Fix --task and --stat with pipe input" [upstream commit 892ba7f18621a02af4428c58d97451f64685dba4]).

Greetings!

Daniel Díaz
[email protected]

2021-07-20 06:24:15

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 5.4 000/148] 5.4.134-rc2 review

On Mon, Jul 19, 2021 at 05:46:26PM -0500, Daniel D?az wrote:
> Hello!
>
> On 7/19/21 3:46 PM, Daniel D?az wrote:
> > On 7/19/21 1:45 PM, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 5.4.134 release.
> > > There are 148 patches in this series, all will be posted as a response
> > > to this one.? If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Wed, 21 Jul 2021 18:42:54 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > > ????https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.134-rc2.gz
> > > or in the git tree and branch at:
> > > ????git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Perf fails to compile in 5.4 on Arm, Arm64, i386 and x86 (GCC 11 and GCC 7.3):
> >
> > ? builtin-report.c:669:12: error: 'process_attr' used but never defined [-Werror]
> > ??? 669 | static int process_attr(struct perf_tool *tool __maybe_unused,
> > ??????? |??????????? ^~~~~~~~~~~~
> > ? cc1: all warnings being treated as errors
> > ? make[3]: *** [/builds/linux/tools/build/Makefile.build:96: /home/tuxbuild/.cache/tuxmake/builds/current/builtin-report.o] Error 1
>
> Bisection points to ee7531fb817c ("perf report: Fix --task and --stat with pipe input" [upstream commit 892ba7f18621a02af4428c58d97451f64685dba4]).

Thanks, now dropped.

greg k-h