2023-09-12 21:10:38

by Konrad Dybcio

Subject: [PATCH v2 13/14] arm64: dts: qcom: msm8996: Remove PNoC clock from MSS

The PNoC clock is a clock for the entire PNoC bus, managed from
within the interconnect driver. Attaching it to MSS was a total hack.
Get rid of it and take the liberty to make the clock-names entries
more readable.

Signed-off-by: Konrad Dybcio <[email protected]>
---
arch/arm64/boot/dts/qcom/msm8996.dtsi | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index 7061a8e12c81..51db5ddcef88 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -2479,10 +2479,15 @@ mss_pil: remoteproc@2080000 {
<&gcc GCC_MSS_GPLL0_DIV_CLK>,
<&gcc GCC_MSS_SNOC_AXI_CLK>,
<&gcc GCC_MSS_MNOC_BIMC_AXI_CLK>,
- <&rpmcc RPM_SMD_PCNOC_CLK>,
<&rpmcc RPM_SMD_QDSS_CLK>;
- clock-names = "iface", "bus", "mem", "xo", "gpll0_mss",
- "snoc_axi", "mnoc_axi", "pnoc", "qdss";
+ clock-names = "iface",
+ "bus",
+ "mem",
+ "xo",
+ "gpll0_mss",
+ "snoc_axi",
+ "mnoc_axi",
+ "qdss";

resets = <&gcc GCC_MSS_RESTART>;
reset-names = "mss_restart";

--
2.42.0

2023-09-13 14:12:31

by Yassine Oudjana

Subject: Re: [PATCH v2 13/14] arm64: dts: qcom: msm8996: Remove PNoC clock from MSS

On 12/09/2023 4:31 pm, Konrad Dybcio wrote:
> The PNoC clock is a clock for the entire PNoC bus, managed from
> within the interconnect driver. Attaching it to MSS was a total hack.
> Get rid of it and take the liberty to make the clock-names entries
> more readable.
>
> Signed-off-by: Konrad Dybcio <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index 7061a8e12c81..51db5ddcef88 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -2479,10 +2479,15 @@ mss_pil: remoteproc@2080000 {
> <&gcc GCC_MSS_GPLL0_DIV_CLK>,
> <&gcc GCC_MSS_SNOC_AXI_CLK>,
> <&gcc GCC_MSS_MNOC_BIMC_AXI_CLK>,
> - <&rpmcc RPM_SMD_PCNOC_CLK>,
> <&rpmcc RPM_SMD_QDSS_CLK>;
> - clock-names = "iface", "bus", "mem", "xo", "gpll0_mss",
> - "snoc_axi", "mnoc_axi", "pnoc", "qdss";
> + clock-names = "iface",
> + "bus",
> + "mem",
> + "xo",
> + "gpll0_mss",
> + "snoc_axi",
> + "mnoc_axi",
> + "qdss";
>
> resets = <&gcc GCC_MSS_RESTART>;
> reset-names = "mss_restart";

Tested-by: Yassine Oudjana <[email protected]>