2022-04-26 05:42:10

by Oleksij Rempel

[permalink] [raw]
Subject: [PATCH v3 1/4] dt-bindings: arm: stm32: Add compatible strings for Protonic T1L boards

This boards are based on STM32MP151AAD3 and use 10BaseT1L for
communication.

- PRTT1C - 10BaseT1L switch
- PRTT1S - 10BaseT1L CO2 sensor board
- PRTT1A - 10BaseT1L multi functional controller

Signed-off-by: Oleksij Rempel <[email protected]>
---
Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
index fa0a1b84122e..3a10be1c73d5 100644
--- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
+++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
@@ -14,6 +14,14 @@ properties:
const: "/"
compatible:
oneOf:
+ - description: ST STM32MP151 based Boards
+ items:
+ - enum:
+ - prt,prtt1a # Protonic PRTT1A
+ - prt,prtt1c # Protonic PRTT1C
+ - prt,prtt1s # Protonic PRTT1S
+ - const: st,stm32mp151
+
- description: DH STM32MP1 SoM based Boards
items:
- enum:
--
2.30.2


2022-04-26 09:47:41

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v3 1/4] dt-bindings: arm: stm32: Add compatible strings for Protonic T1L boards

On 26/04/2022 08:35, Oleksij Rempel wrote:
> On Mon, Apr 25, 2022 at 04:06:45PM +0200, Krzysztof Kozlowski wrote:
>> On 25/04/2022 15:53, Krzysztof Kozlowski wrote:
>>> On 25/04/2022 15:28, Oleksij Rempel wrote:
>>>> This boards are based on STM32MP151AAD3 and use 10BaseT1L for
>>>> communication.
>>>>
>>>> - PRTT1C - 10BaseT1L switch
>>>> - PRTT1S - 10BaseT1L CO2 sensor board
>>>> - PRTT1A - 10BaseT1L multi functional controller
>>>>
>>>> Signed-off-by: Oleksij Rempel <[email protected]>
>>>> ---
>>>
>>>
>>> Acked-by: Krzysztof Kozlowski <[email protected]>
>>
>> Although the order is still messed up. I through you will move the entry
>> just slightly up, not to the beginning, so maybe just rebase on top of:
>> https://lore.kernel.org/all/[email protected]/
>
> I put it according to the SoC version. st,stm32mp151 would be the first
> entry before stm32mp153. What order do you prefer, where should I put my
> boards?

153 is defined lower. The first entry in the file is a trap. :)


Best regards,
Krzysztof