2022-06-17 23:44:42

by Nícolas F. R. A. Prado

[permalink] [raw]
Subject: [PATCH 0/2] dtbs_check warning fixes for idle-states nodes in mt8192.dtsi


A couple of simple changes to get rid of dtbs_check warnings on
idle-states nodes in mt8192.dtsi.


Nícolas F. R. A. Prado (2):
arm64: dts: mt8192: Fix idle-states nodes naming scheme
arm64: dts: mt8192: Fix idle-states entry-method

arch/arm64/boot/dts/mediatek/mt8192.dtsi | 26 ++++++++++++------------
1 file changed, 13 insertions(+), 13 deletions(-)

--
2.36.1


2022-06-17 23:45:12

by Nícolas F. R. A. Prado

[permalink] [raw]
Subject: [PATCH 1/2] arm64: dts: mt8192: Fix idle-states nodes naming scheme

Tweak the name of the idle-states subnodes so that they follow the
binding pattern, getting rid of dtbs_check warnings.

Only the usage of "-" in the name was necessary, but "off" was also
exchanged for "sleep" since that seems to be a more common wording in
other dts files.

Fixes: 9260918d3a4f ("arm64: dts: mt8192: Add cpu-idle-states")
Signed-off-by: Nícolas F. R. A. Prado <[email protected]>

---

arch/arm64/boot/dts/mediatek/mt8192.dtsi | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
index 733aec2e7f77..c739e910883a 100644
--- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
@@ -43,7 +43,7 @@ cpu0: cpu@0 {
reg = <0x000>;
enable-method = "psci";
clock-frequency = <1701000000>;
- cpu-idle-states = <&cpuoff_l &clusteroff_l>;
+ cpu-idle-states = <&cpu_sleep_l &cluster_sleep_l>;
next-level-cache = <&l2_0>;
capacity-dmips-mhz = <530>;
};
@@ -54,7 +54,7 @@ cpu1: cpu@100 {
reg = <0x100>;
enable-method = "psci";
clock-frequency = <1701000000>;
- cpu-idle-states = <&cpuoff_l &clusteroff_l>;
+ cpu-idle-states = <&cpu_sleep_l &cluster_sleep_l>;
next-level-cache = <&l2_0>;
capacity-dmips-mhz = <530>;
};
@@ -65,7 +65,7 @@ cpu2: cpu@200 {
reg = <0x200>;
enable-method = "psci";
clock-frequency = <1701000000>;
- cpu-idle-states = <&cpuoff_l &clusteroff_l>;
+ cpu-idle-states = <&cpu_sleep_l &cluster_sleep_l>;
next-level-cache = <&l2_0>;
capacity-dmips-mhz = <530>;
};
@@ -76,7 +76,7 @@ cpu3: cpu@300 {
reg = <0x300>;
enable-method = "psci";
clock-frequency = <1701000000>;
- cpu-idle-states = <&cpuoff_l &clusteroff_l>;
+ cpu-idle-states = <&cpu_sleep_l &cluster_sleep_l>;
next-level-cache = <&l2_0>;
capacity-dmips-mhz = <530>;
};
@@ -87,7 +87,7 @@ cpu4: cpu@400 {
reg = <0x400>;
enable-method = "psci";
clock-frequency = <2171000000>;
- cpu-idle-states = <&cpuoff_b &clusteroff_b>;
+ cpu-idle-states = <&cpu_sleep_b &cluster_sleep_b>;
next-level-cache = <&l2_1>;
capacity-dmips-mhz = <1024>;
};
@@ -98,7 +98,7 @@ cpu5: cpu@500 {
reg = <0x500>;
enable-method = "psci";
clock-frequency = <2171000000>;
- cpu-idle-states = <&cpuoff_b &clusteroff_b>;
+ cpu-idle-states = <&cpu_sleep_b &cluster_sleep_b>;
next-level-cache = <&l2_1>;
capacity-dmips-mhz = <1024>;
};
@@ -109,7 +109,7 @@ cpu6: cpu@600 {
reg = <0x600>;
enable-method = "psci";
clock-frequency = <2171000000>;
- cpu-idle-states = <&cpuoff_b &clusteroff_b>;
+ cpu-idle-states = <&cpu_sleep_b &cluster_sleep_b>;
next-level-cache = <&l2_1>;
capacity-dmips-mhz = <1024>;
};
@@ -120,7 +120,7 @@ cpu7: cpu@700 {
reg = <0x700>;
enable-method = "psci";
clock-frequency = <2171000000>;
- cpu-idle-states = <&cpuoff_b &clusteroff_b>;
+ cpu-idle-states = <&cpu_sleep_b &cluster_sleep_b>;
next-level-cache = <&l2_1>;
capacity-dmips-mhz = <1024>;
};
@@ -173,7 +173,7 @@ l3_0: l3-cache {

idle-states {
entry-method = "arm,psci";
- cpuoff_l: cpuoff_l {
+ cpu_sleep_l: cpu-sleep-l {
compatible = "arm,idle-state";
arm,psci-suspend-param = <0x00010001>;
local-timer-stop;
@@ -181,7 +181,7 @@ cpuoff_l: cpuoff_l {
exit-latency-us = <140>;
min-residency-us = <780>;
};
- cpuoff_b: cpuoff_b {
+ cpu_sleep_b: cpu-sleep-b {
compatible = "arm,idle-state";
arm,psci-suspend-param = <0x00010001>;
local-timer-stop;
@@ -189,7 +189,7 @@ cpuoff_b: cpuoff_b {
exit-latency-us = <145>;
min-residency-us = <720>;
};
- clusteroff_l: clusteroff_l {
+ cluster_sleep_l: cluster-sleep-l {
compatible = "arm,idle-state";
arm,psci-suspend-param = <0x01010002>;
local-timer-stop;
@@ -197,7 +197,7 @@ clusteroff_l: clusteroff_l {
exit-latency-us = <155>;
min-residency-us = <860>;
};
- clusteroff_b: clusteroff_b {
+ cluster_sleep_b: cluster-sleep-b {
compatible = "arm,idle-state";
arm,psci-suspend-param = <0x01010002>;
local-timer-stop;
--
2.36.1

2022-06-17 23:47:18

by Nícolas F. R. A. Prado

[permalink] [raw]
Subject: [PATCH 2/2] arm64: dts: mt8192: Fix idle-states entry-method

The entry-method property of the idle-states node should be "psci" as
described in the idle-states binding, since this is already the value of
enable-method in the CPU nodes. Fix it to get rid of a dtbs_check
warning.

Fixes: 9260918d3a4f ("arm64: dts: mt8192: Add cpu-idle-states")
Signed-off-by: Nícolas F. R. A. Prado <[email protected]>
---

arch/arm64/boot/dts/mediatek/mt8192.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
index c739e910883a..d5cae38c842a 100644
--- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
@@ -172,7 +172,7 @@ l3_0: l3-cache {
};

idle-states {
- entry-method = "arm,psci";
+ entry-method = "psci";
cpu_sleep_l: cpu-sleep-l {
compatible = "arm,idle-state";
arm,psci-suspend-param = <0x00010001>;
--
2.36.1

Subject: Re: [PATCH 1/2] arm64: dts: mt8192: Fix idle-states nodes naming scheme

Il 18/06/22 01:31, Nícolas F. R. A. Prado ha scritto:
> Tweak the name of the idle-states subnodes so that they follow the
> binding pattern, getting rid of dtbs_check warnings.
>
> Only the usage of "-" in the name was necessary, but "off" was also
> exchanged for "sleep" since that seems to be a more common wording in
> other dts files.
>
> Fixes: 9260918d3a4f ("arm64: dts: mt8192: Add cpu-idle-states")
> Signed-off-by: Nícolas F. R. A. Prado <[email protected]>
>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>

Subject: Re: [PATCH 2/2] arm64: dts: mt8192: Fix idle-states entry-method

Il 18/06/22 01:31, Nícolas F. R. A. Prado ha scritto:
> The entry-method property of the idle-states node should be "psci" as
> described in the idle-states binding, since this is already the value of
> enable-method in the CPU nodes. Fix it to get rid of a dtbs_check
> warning.
>
> Fixes: 9260918d3a4f ("arm64: dts: mt8192: Add cpu-idle-states")
> Signed-off-by: Nícolas F. R. A. Prado <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>

2022-06-22 14:12:30

by Matthias Brugger

[permalink] [raw]
Subject: Re: [PATCH 0/2] dtbs_check warning fixes for idle-states nodes in mt8192.dtsi



On 18/06/2022 01:31, Nícolas F. R. A. Prado wrote:
>
> A couple of simple changes to get rid of dtbs_check warnings on
> idle-states nodes in mt8192.dtsi.
>
>
> Nícolas F. R. A. Prado (2):
> arm64: dts: mt8192: Fix idle-states nodes naming scheme
> arm64: dts: mt8192: Fix idle-states entry-method

Both applied, thanks!

>
> arch/arm64/boot/dts/mediatek/mt8192.dtsi | 26 ++++++++++++------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>