2024-04-23 10:09:28

by MD Danish Anwar

Subject: [PATCH] arm64: dts: ti: k3-am64-main: Add PRU system events for virtio

From: Suman Anna <[email protected]>

PRU system events "vring" have been added to each PRU and RTU node
in each of the ICSSG0 and ICSSG1 remote processor subsystems to
enable the virtio/rpmsg communication between MPU and that PRU/RTU core.
No events have been added to the Tx_PRU cores at present. The
additions are done in the base k3-am64main.dtsi, and so are inherited
by all the K3 AM64x boards.

The PRU system events is the preferred approach over using TI
mailboxes, as it eliminates an external peripheral access from
the PRU/RTU-side, and keeps the interrupt generation internal to
the ICSSG. The difference from MPU would be minimal in using one
versus the other.

Mailboxes can still be used if desired, but currently there is
no support on firmware-side for K3 SoCs to use mailboxes. Either
approach would require that an appropriate firmware image is
loaded/booted on the PRU.

Signed-off-by: Suman Anna <[email protected]>
Signed-off-by: Kishon Vijay Abraham I <[email protected]>
Signed-off-by: MD Danish Anwar <[email protected]>
---
This patch is based on linux-next tag next-20240423

arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
index 6f9aa5e02138..f8370dd03350 100644
--- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
@@ -1283,6 +1283,9 @@ pru0_0: pru@34000 {
<0x22400 0x100>;
reg-names = "iram", "control", "debug";
firmware-name = "am64x-pru0_0-fw";
+ interrupt-parent = <&icssg0_intc>;
+ interrupts = <16 2 2>;
+ interrupt-names = "vring";
};

rtu0_0: rtu@4000 {
@@ -1292,6 +1295,9 @@ rtu0_0: rtu@4000 {
<0x23400 0x100>;
reg-names = "iram", "control", "debug";
firmware-name = "am64x-rtu0_0-fw";
+ interrupt-parent = <&icssg0_intc>;
+ interrupts = <20 4 4>;
+ interrupt-names = "vring";
};

tx_pru0_0: txpru@a000 {
@@ -1310,6 +1316,9 @@ pru0_1: pru@38000 {
<0x24400 0x100>;
reg-names = "iram", "control", "debug";
firmware-name = "am64x-pru0_1-fw";
+ interrupt-parent = <&icssg0_intc>;
+ interrupts = <18 3 3>;
+ interrupt-names = "vring";
};

rtu0_1: rtu@6000 {
@@ -1319,6 +1328,9 @@ rtu0_1: rtu@6000 {
<0x23c00 0x100>;
reg-names = "iram", "control", "debug";
firmware-name = "am64x-rtu0_1-fw";
+ interrupt-parent = <&icssg0_intc>;
+ interrupts = <22 5 5>;
+ interrupt-names = "vring";
};

tx_pru0_1: txpru@c000 {
@@ -1436,6 +1448,9 @@ pru1_0: pru@34000 {
<0x22400 0x100>;
reg-names = "iram", "control", "debug";
firmware-name = "am64x-pru1_0-fw";
+ interrupt-parent = <&icssg1_intc>;
+ interrupts = <16 2 2>;
+ interrupt-names = "vring";
};

rtu1_0: rtu@4000 {
@@ -1445,6 +1460,9 @@ rtu1_0: rtu@4000 {
<0x23400 0x100>;
reg-names = "iram", "control", "debug";
firmware-name = "am64x-rtu1_0-fw";
+ interrupt-parent = <&icssg1_intc>;
+ interrupts = <20 4 4>;
+ interrupt-names = "vring";
};

tx_pru1_0: txpru@a000 {
@@ -1463,6 +1481,9 @@ pru1_1: pru@38000 {
<0x24400 0x100>;
reg-names = "iram", "control", "debug";
firmware-name = "am64x-pru1_1-fw";
+ interrupt-parent = <&icssg1_intc>;
+ interrupts = <18 3 3>;
+ interrupt-names = "vring";
};

rtu1_1: rtu@6000 {
@@ -1472,6 +1493,9 @@ rtu1_1: rtu@6000 {
<0x23c00 0x100>;
reg-names = "iram", "control", "debug";
firmware-name = "am64x-rtu1_1-fw";
+ interrupt-parent = <&icssg1_intc>;
+ interrupts = <22 5 5>;
+ interrupt-names = "vring";
};

tx_pru1_1: txpru@c000 {
--
2.34.1

2024-04-24 07:00:45

by Ravi Gunasekaran

Subject: Re: [PATCH] arm64: dts: ti: k3-am64-main: Add PRU system events for virtio

On 4/23/2024 3:36 PM, MD Danish Anwar wrote:
> From: Suman Anna <[email protected]>
>
> PRU system events "vring" have been added to each PRU and RTU node
> in each of the ICSSG0 and ICSSG1 remote processor subsystems to
> enable the virtio/rpmsg communication between MPU and that PRU/RTU core.
> No events have been added to the Tx_PRU cores at present. The
> additions are done in the base k3-am64main.dtsi, and so are inherited
> by all the K3 AM64x boards.
>
> The PRU system events is the preferred approach over using TI
> mailboxes, as it eliminates an external peripheral access from
> the PRU/RTU-side, and keeps the interrupt generation internal to
> the ICSSG. The difference from MPU would be minimal in using one
> versus the other.
>
> Mailboxes can still be used if desired, but currently there is
> no support on firmware-side for K3 SoCs to use mailboxes. Either
> approach would require that an appropriate firmware image is
> loaded/booted on the PRU.
>
> Signed-off-by: Suman Anna <[email protected]>
> Signed-off-by: Kishon Vijay Abraham I <[email protected]>
> Signed-off-by: MD Danish Anwar <[email protected]>
> ---
> This patch is based on linux-next tag next-20240423
>
> arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
>

Acked-by: Ravi Gunasekaran <[email protected]>

Regards,
Ravi