2021-01-19 04:51:39

by Stanimir Varbanov

[permalink] [raw]
Subject: Re: [PATCH 2/2] media: dt-bindings: media: venus: Add sdm660 DT schema



On 1/17/21 9:23 PM, AngeloGioacchino Del Regno wrote:
> Il 17/01/21 16:45, Rob Herring ha scritto:
>> On Fri, 15 Jan 2021 19:52:52 +0100, AngeloGioacchino Del Regno wrote:
>>> Add new qcom,sdm660-venus DT binding schema.
>>>
>>> Signed-off-by: AngeloGioacchino Del Regno
>>> <[email protected]>
>>> ---
>>> ? .../bindings/media/qcom,sdm660-venus.yaml???? | 164 ++++++++++++++++++
>>> ? 1 file changed, 164 insertions(+)
>>> ? create mode 100644
>>> Documentation/devicetree/bindings/media/qcom,sdm660-venus.yaml
>>>
>>> base-commit: 012bd807cf654b992cdc4db7eab85c1e95f9d571
>>> prerequisite-patch-id: 734bdefdb043a8f91a48916246cc9a36fb5966e5
>>> prerequisite-patch-id: 999517c02973237996492a41ed5bfc2990083932
>>> prerequisite-patch-id: a48910425fac61948a7a26bec4d40d63e3368569
>>> prerequisite-patch-id: b1a1a4216eed0d04dd16e6e8e1053dee185d06d8
>>> prerequisite-patch-id: dff12be2631cc21ef1c3c930fba49d979f5055fe
>>>
>>
>> My bot found errors running 'make dt_binding_check' on your patch:
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> Documentation/devicetree/bindings/media/qcom,sdm660-venus.example.dts:20:18:
>> fatal error: dt-bindings/clock/qcom,mmcc-sdm660.h: No such file or
>> directory
>> ??? 20 |???????? #include <dt-bindings/clock/qcom,mmcc-sdm660.h>
>> ?????? |????????????????? ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> compilation terminated.
>> make[1]: *** [scripts/Makefile.lib:344:
>> Documentation/devicetree/bindings/media/qcom,sdm660-venus.example.dt.yaml]
>> Error 1
>> make[1]: *** Waiting for unfinished jobs....
>> make: *** [Makefile:1370: dt_binding_check] Error 2
>>
>> See https://patchwork.ozlabs.org/patch/1427279
>>
>> This check can fail if there are any dependencies. The base for a patch
>> series is generally the most recent rc1.
>>
>> If you already ran 'make dt_binding_check' and didn't see the above
>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>> date:
>>
>> pip3 install dtschema --upgrade
>>
>> Please check and re-submit.
>>
>
> Yes, because this depends on the commits that are mentioned in the tags.
> Is there any better way to add a dependency on another patch series?
>

What is the status of mmcc-sdm660 clk driver? I guess we have to
postpone this until clock driver is ready for merge?

> - Angelo

--
regards,
Stan