2023-07-26 17:37:51

by Colin Ian King

Subject: [PATCH][next] net: ethernet: slicoss: remove redundant increment of pointer data

The pointer data is being incremented but this change to the pointer
is not used afterwards. The increment is redundant and can be removed.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/ethernet/alacritech/slicoss.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/alacritech/slicoss.c b/drivers/net/ethernet/alacritech/slicoss.c
index a30d0f172986..78231c85234d 100644
--- a/drivers/net/ethernet/alacritech/slicoss.c
+++ b/drivers/net/ethernet/alacritech/slicoss.c
@@ -1520,10 +1520,8 @@ static void slic_get_ethtool_stats(struct net_device *dev,

static void slic_get_strings(struct net_device *dev, u32 stringset, u8 *data)
{
- if (stringset == ETH_SS_STATS) {
+ if (stringset == ETH_SS_STATS)
memcpy(data, slic_stats_strings, sizeof(slic_stats_strings));
- data += sizeof(slic_stats_strings);
- }
}

static void slic_get_drvinfo(struct net_device *dev,
--
2.39.2

2023-07-26 20:09:21

by Lino Sanfilippo

Subject: Re: [PATCH][next] net: ethernet: slicoss: remove redundant increment of pointer data

Hi,

On 26.07.23 18:45, Colin Ian King wrote:
> The pointer data is being incremented but this change to the pointer
> is not used afterwards. The increment is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/net/ethernet/alacritech/slicoss.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/alacritech/slicoss.c b/drivers/net/ethernet/alacritech/slicoss.c
> index a30d0f172986..78231c85234d 100644
> --- a/drivers/net/ethernet/alacritech/slicoss.c
> +++ b/drivers/net/ethernet/alacritech/slicoss.c
> @@ -1520,10 +1520,8 @@ static void slic_get_ethtool_stats(struct net_device *dev,
>
> static void slic_get_strings(struct net_device *dev, u32 stringset, u8 *data)
> {
> - if (stringset == ETH_SS_STATS) {
> + if (stringset == ETH_SS_STATS)
> memcpy(data, slic_stats_strings, sizeof(slic_stats_strings));
> - data += sizeof(slic_stats_strings);
> - }
> }
>
> static void slic_get_drvinfo(struct net_device *dev,

FWIW
Acked-by: Lino Sanfilippo <[email protected]>

Best Regards,
Lino

2023-07-28 23:59:16

by patchwork-bot+netdevbpf

Subject: Re: [PATCH][next] net: ethernet: slicoss: remove redundant increment of pointer data

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:

On Wed, 26 Jul 2023 17:45:22 +0100 you wrote:
> The pointer data is being incremented but this change to the pointer
> is not used afterwards. The increment is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/net/ethernet/alacritech/slicoss.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

Here is the summary with links:
- [next] net: ethernet: slicoss: remove redundant increment of pointer data
https://git.kernel.org/netdev/net-next/c/3bdd85e2e350

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html