These are first set of patches for removing NON-SMP data from smp.h as suggested by Ingo.
The following changes since commit b97d41dd7df418cacfa01e399d35927bbdff600f:
Ingo Molnar (1):
Merge branch 'out-of-tree'
Jaswinder Singh Rajput (7):
x86: smp.h remove obsolete function declaration
x86: smp.h move zap_low_mappings declartion to tlbflush.h
x86: smp.h move prefill_possible_map declartion to cpu.h
x86: smp.h move stack_processor_id declartion to cpu.h
x86: smp.h move safe_smp_processor_id declartion to cpu.h
x86: smp.h move cpu_physical_id declartion to cpu.h
x86: smp.h move boot_cpu_id declartion to cpu.h
arch/x86/include/asm/cpu.h | 21 +++++++++++++++++++++
arch/x86/include/asm/smp.h | 19 -------------------
arch/x86/include/asm/tlbflush.h | 2 ++
arch/x86/kernel/cpu/common.c | 2 +-
arch/x86/kernel/io_apic.c | 1 +
arch/x86/kernel/setup.c | 2 +-
arch/x86/kernel/smpboot.c | 1 -
arch/x86/mach-voyager/setup.c | 1 +
arch/x86/mm/init_32.c | 1 -
drivers/pci/intr_remapping.c | 1 +
10 files changed, 28 insertions(+), 23 deletions(-)
Thanks
--
JSR
* Jaswinder Singh Rajput <[email protected]> wrote:
> These are first set of patches for removing NON-SMP data from smp.h as suggested by Ingo.
>
> The following changes since commit b97d41dd7df418cacfa01e399d35927bbdff600f:
> Ingo Molnar (1):
> Merge branch 'out-of-tree'
>
> Jaswinder Singh Rajput (7):
> x86: smp.h remove obsolete function declaration
> x86: smp.h move zap_low_mappings declartion to tlbflush.h
> x86: smp.h move prefill_possible_map declartion to cpu.h
> x86: smp.h move stack_processor_id declartion to cpu.h
> x86: smp.h move safe_smp_processor_id declartion to cpu.h
> x86: smp.h move cpu_physical_id declartion to cpu.h
> x86: smp.h move boot_cpu_id declartion to cpu.h
>
> arch/x86/include/asm/cpu.h | 21 +++++++++++++++++++++
> arch/x86/include/asm/smp.h | 19 -------------------
> arch/x86/include/asm/tlbflush.h | 2 ++
> arch/x86/kernel/cpu/common.c | 2 +-
> arch/x86/kernel/io_apic.c | 1 +
> arch/x86/kernel/setup.c | 2 +-
> arch/x86/kernel/smpboot.c | 1 -
> arch/x86/mach-voyager/setup.c | 1 +
> arch/x86/mm/init_32.c | 1 -
> drivers/pci/intr_remapping.c | 1 +
> 10 files changed, 28 insertions(+), 23 deletions(-)
applied to tip/x86/cleanups:
a1d2aa6: x86: smp.h move boot_cpu_id declartion to cpu.h
17b986a: x86: smp.h move cpu_physical_id declartion to cpu.h
e3b687f: x86: smp.h move safe_smp_processor_id declartion to cpu.h
d32195e: x86: smp.h move stack_processor_id declartion to cpu.h
6e5385d: x86: smp.h move prefill_possible_map declartion to cpu.h
dacf733: x86: smp.h move zap_low_mappings declartion to tlbflush.h
7760ec7: x86: smp.h remove obsolete function declaration
thanks!
Ingo
* Ingo Molnar <[email protected]> wrote:
> applied to tip/x86/cleanups:
excluded it again from tip/master, due to this build failure:
arch/x86/kernel/crash.c: In function ‘native_machine_crash_shutdown’:
arch/x86/kernel/crash.c:108: error: implicit declaration of function
‘safe_smp_processor_id’
which happens with the first attached config,
and this build failure:
arch/x86/kernel/cpu/common.c: In function ‘cpu_init’:
arch/x86/kernel/cpu/common.c:1108: error: ‘cpu_initialized_mask’ undeclared (first use in this function)
arch/x86/kernel/cpu/common.c:1108: error: (Each undeclared identifier is reported only once
arch/x86/kernel/cpu/common.c:1108: error: for each function it appears in.)
which happens with the second config.
(the configs are not oldconfig-clean - just type enter for all questions
that come up to get to the right config)
Ingo
Hello Ingo,
On Wed, Jan 7, 2009 at 7:03 PM, Ingo Molnar <[email protected]> wrote:
>
> * Ingo Molnar <[email protected]> wrote:
>
>> applied to tip/x86/cleanups:
>
> excluded it again from tip/master, due to this build failure:
>
Please accept only first 4 patches:
1. x86: smp.h remove obsolete function declaration
2. x86: smp.h move zap_low_mappings declartion to tlbflush.h
3. x86: smp.h move prefill_possible_map declartion to cpu.h
4. x86: smp.h move stack_processor_id declartion to cpu.h
Then it will easier for me to to focus on only few things.
Thanks
--
JSR
* Jaswinder Singh Rajput <[email protected]> wrote:
> Hello Ingo,
>
> On Wed, Jan 7, 2009 at 7:03 PM, Ingo Molnar <[email protected]> wrote:
> >
> > * Ingo Molnar <[email protected]> wrote:
> >
> >> applied to tip/x86/cleanups:
> >
> > excluded it again from tip/master, due to this build failure:
> >
>
> Please accept only first 4 patches:
>
> 1. x86: smp.h remove obsolete function declaration
> 2. x86: smp.h move zap_low_mappings declartion to tlbflush.h
> 3. x86: smp.h move prefill_possible_map declartion to cpu.h
> 4. x86: smp.h move stack_processor_id declartion to cpu.h
>
> Then it will easier for me to to focus on only few things.
ok, i dropped the others.
Ingo
* Ingo Molnar <[email protected]> wrote:
>
> * Jaswinder Singh Rajput <[email protected]> wrote:
>
> > Hello Ingo,
> >
> > On Wed, Jan 7, 2009 at 7:03 PM, Ingo Molnar <[email protected]> wrote:
> > >
> > > * Ingo Molnar <[email protected]> wrote:
> > >
> > >> applied to tip/x86/cleanups:
> > >
> > > excluded it again from tip/master, due to this build failure:
> > >
> >
> > Please accept only first 4 patches:
> >
> > 1. x86: smp.h remove obsolete function declaration
> > 2. x86: smp.h move zap_low_mappings declartion to tlbflush.h
> > 3. x86: smp.h move prefill_possible_map declartion to cpu.h
> > 4. x86: smp.h move stack_processor_id declartion to cpu.h
> >
> > Then it will easier for me to to focus on only few things.
>
> ok, i dropped the others.
i dropped the rest too, due to:
arch/x86/kernel/cpu/common.c:983: error: implicit declaration of function 'stack_smp_processor_id'
config attached. Please resend the whole lot once you have those configs
working and if you are reasonably sure similar bugs are not in other
places.
Ingo
* Ingo Molnar <[email protected]> wrote:
>
> * Ingo Molnar <[email protected]> wrote:
>
> >
> > * Jaswinder Singh Rajput <[email protected]> wrote:
> >
> > > Hello Ingo,
> > >
> > > On Wed, Jan 7, 2009 at 7:03 PM, Ingo Molnar <[email protected]> wrote:
> > > >
> > > > * Ingo Molnar <[email protected]> wrote:
> > > >
> > > >> applied to tip/x86/cleanups:
> > > >
> > > > excluded it again from tip/master, due to this build failure:
> > > >
> > >
> > > Please accept only first 4 patches:
> > >
> > > 1. x86: smp.h remove obsolete function declaration
> > > 2. x86: smp.h move zap_low_mappings declartion to tlbflush.h
> > > 3. x86: smp.h move prefill_possible_map declartion to cpu.h
> > > 4. x86: smp.h move stack_processor_id declartion to cpu.h
> > >
> > > Then it will easier for me to to focus on only few things.
> >
> > ok, i dropped the others.
>
> i dropped the rest too, due to:
>
> arch/x86/kernel/cpu/common.c:983: error: implicit declaration of function 'stack_smp_processor_id'
>
> config attached. Please resend the whole lot once you have those configs
> working and if you are reasonably sure similar bugs are not in other
> places.
note, i kept these:
6e5385d: x86: smp.h move prefill_possible_map declartion to cpu.h
dacf733: x86: smp.h move zap_low_mappings declartion to tlbflush.h
7760ec7: x86: smp.h remove obsolete function declaration
as they seem fairly safe.
Ingo
On Wed, Jan 7, 2009 at 8:45 PM, Ingo Molnar <[email protected]> wrote:
>
> note, i kept these:
>
> 6e5385d: x86: smp.h move prefill_possible_map declartion to cpu.h
> dacf733: x86: smp.h move zap_low_mappings declartion to tlbflush.h
> 7760ec7: x86: smp.h remove obsolete function declaration
>
> as they seem fairly safe.
>
OK, thanks.
I will prepare new lot of remaining 4 patches.
Due to some problem in mailer server it sending my old patches, please
ignore them.
Thanks
--
JSR
On Wed, 2009-01-07 at 16:15 +0100, Ingo Molnar wrote:
> note, i kept these:
>
> 6e5385d: x86: smp.h move prefill_possible_map declartion to cpu.h
> dacf733: x86: smp.h move zap_low_mappings declartion to tlbflush.h
> 7760ec7: x86: smp.h remove obsolete function declaration
>
> as they seem fairly safe.
I send new 4 patches:
[PATCH -tip 1/4 V2] x86: smp.h move stack_processor_id declartion to cpu.h
[PATCH -tip 2/4 V2] x86: smp.h move safe_smp_processor_id declartion to cpu.h
[PATCH -tip 3/4 V2] x86: smp.h move cpu_physical_id declartion to cpu.h
[PATCH -tip 4/4 V2] x86: smp.h move boot_cpu_id declartion to cpu.h
Please accept them.
Thanks,
--
JSR
* Jaswinder Singh Rajput <[email protected]> wrote:
> On Wed, 2009-01-07 at 16:15 +0100, Ingo Molnar wrote:
> > note, i kept these:
> >
> > 6e5385d: x86: smp.h move prefill_possible_map declartion to cpu.h
> > dacf733: x86: smp.h move zap_low_mappings declartion to tlbflush.h
> > 7760ec7: x86: smp.h remove obsolete function declaration
> >
> > as they seem fairly safe.
>
> I send new 4 patches:
>
> [PATCH -tip 1/4 V2] x86: smp.h move stack_processor_id declartion to cpu.h
> [PATCH -tip 2/4 V2] x86: smp.h move safe_smp_processor_id declartion to cpu.h
> [PATCH -tip 3/4 V2] x86: smp.h move cpu_physical_id declartion to cpu.h
> [PATCH -tip 4/4 V2] x86: smp.h move boot_cpu_id declartion to cpu.h
>
> Please accept them.
Just to make sure: they should solve the 3 failures i reported?
Ingo
On Wed, Jan 7, 2009 at 11:05 PM, Ingo Molnar <[email protected]> wrote:>> * Jaswinder Singh Rajput <[email protected]> wrote:>>> I send new 4 patches:>>>> [PATCH -tip 1/4 V2] x86: smp.h move stack_processor_id declartion to cpu.h>> [PATCH -tip 2/4 V2] x86: smp.h move safe_smp_processor_id declartion to cpu.h>> [PATCH -tip 3/4 V2] x86: smp.h move cpu_physical_id declartion to cpu.h>> [PATCH -tip 4/4 V2] x86: smp.h move boot_cpu_id declartion to cpu.h>>>> Please accept them.>> Just to make sure: they should solve the 3 failures i reported?>
Yes.
I am sorry for earlier errors messages.
Thanks--JSR????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay? ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?
* Jaswinder Singh Rajput <[email protected]> wrote:
> On Wed, Jan 7, 2009 at 11:05 PM, Ingo Molnar <[email protected]> wrote:
> >
> > * Jaswinder Singh Rajput <[email protected]> wrote:
> >
> >> I send new 4 patches:
> >>
> >> [PATCH -tip 1/4 V2] x86: smp.h move stack_processor_id declartion to cpu.h
> >> [PATCH -tip 2/4 V2] x86: smp.h move safe_smp_processor_id declartion to cpu.h
> >> [PATCH -tip 3/4 V2] x86: smp.h move cpu_physical_id declartion to cpu.h
> >> [PATCH -tip 4/4 V2] x86: smp.h move boot_cpu_id declartion to cpu.h
> >>
> >> Please accept them.
> >
> > Just to make sure: they should solve the 3 failures i reported?
> >
>
> Yes.
ok, great.
> I am sorry for earlier errors messages.
no need to be sorry about that - we knew that this is a spaghetti of
historic dependencies. We'll likely need a few more tries before we reach
the desired end result.
Ingo
* Jaswinder Singh Rajput <[email protected]> wrote:
> On Wed, Jan 7, 2009 at 11:05 PM, Ingo Molnar <[email protected]> wrote:
> >
> > * Jaswinder Singh Rajput <[email protected]> wrote:
> >
> >> I send new 4 patches:
> >>
> >> [PATCH -tip 1/4 V2] x86: smp.h move stack_processor_id declartion to cpu.h
> >> [PATCH -tip 2/4 V2] x86: smp.h move safe_smp_processor_id declartion to cpu.h
> >> [PATCH -tip 3/4 V2] x86: smp.h move cpu_physical_id declartion to cpu.h
> >> [PATCH -tip 4/4 V2] x86: smp.h move boot_cpu_id declartion to cpu.h
> >>
> >> Please accept them.
> >
> > Just to make sure: they should solve the 3 failures i reported?
> >
>
> Yes.
ok, i've applied the remaining bits and they are holding up quite well so
far in tip/master testing:
6d652ea: x86: smp.h move boot_cpu_id declartion to cpu.h
af8968a: x86: smp.h move cpu_physical_id declartion to cpu.h
96b89dc: x86: smp.h move safe_smp_processor_id declartion to cpu.h
f472cdb: x86: smp.h move stack_processor_id declartion to cpu.h
Ingo
Ingo