Hello Andy,
On -tip git I am getting this error:
$ ./scripts/checkpatch.pl 000*
Can't use an undefined value as an ARRAY reference at
./scripts/checkpatch.pl line 451.
But earlier it was working great. Is this a feature or a bug.
Thanks,
--
JSR
* Jaswinder Singh Rajput <[email protected]> wrote:
> Hello Andy,
>
> On -tip git I am getting this error:
>
> $ ./scripts/checkpatch.pl 000*
> Can't use an undefined value as an ARRAY reference at
> ./scripts/checkpatch.pl line 451.
>
> But earlier it was working great. Is this a feature or a bug.
bug.
One for the akpm bucket i think, Andrew pushed v26 checkpatch to Linus
yesterday:
57b9c6d: checkpatch: version: 0.26
21caa13: checkpatch: fix the perlcritic errors
2b6db5c: checkpatch: struct file_operations should normally be const
b53c8e1: checkpatch: ensure we actually detect if assignments split across lines
2d1bafd: checkpatch: do not report nr_static as a static declaration
4635f4f: checkpatch: track #ifdef/#else/#endif when tracking blocks
8b1b337: checkpatch: fix continuation detection when handling spacing on operators
8054576: checkpatch: loosen spacing on typedef function checks
080ba92: checkpatch: try to catch missing VMLINUX_SYMBOL() in vmlinux.lds.h
86f9d05: checkpatch: allow parentheses on return for comparisons
1e85572: checkpatch: Add warning for p0-patches
2a5a2c2: checkpatch: update copyrights
50a7dcf: checkpatch: version: 0.25
6586386: checkpatch: dissallow spaces between stars in pointer types
fae17da: checkpatch: comment ends inside strings is most likely not an open comment
8e761b0: checkpatch: detect multiple bitfield declarations
5fe3af1: checkpatch: __weak is an official attribute
383099f: checkpatch: structure member assignments are not complex
83242e0: checkpatch: widen implied comment detection to allow multiple stars
721c1cb: checkpatch: comment detection may miss an implied comment on the last hunk
691d77b6: checkpatch: add checks for in_atomic()
one of those is causing this new warning.
Ingo
On Wed, Jan 07, 2009 at 06:24:55PM +0530, Jaswinder Singh Rajput wrote:
> Hello Andy,
>
> On -tip git I am getting this error:
>
> $ ./scripts/checkpatch.pl 000*
> Can't use an undefined value as an ARRAY reference at
> ./scripts/checkpatch.pl line 451.
>
> But earlier it was working great. Is this a feature or a bug.
That looks wrong indeed. Assuming that is the same version I have here
then that is a bug in the #else preprocessor handling. Could you send
me the specific patch which is throwing this error.
Thanks.
-apw
On Wed, Jan 7, 2009 at 6:37 PM, Andy Whitcroft <[email protected]> wrote:
> On Wed, Jan 07, 2009 at 06:24:55PM +0530, Jaswinder Singh Rajput wrote:
>> Hello Andy,
>>
>> On -tip git I am getting this error:
>>
>> $ ./scripts/checkpatch.pl 000*
>> Can't use an undefined value as an ARRAY reference at
>> ./scripts/checkpatch.pl line 451.
>>
>> But earlier it was working great. Is this a feature or a bug.
>
> That looks wrong indeed. Assuming that is the same version I have here
> then that is a bug in the #else preprocessor handling. Could you send
> me the specific patch which is throwing this error.
>
./scripts/checkpatch.pl
0007-x86-smp.h-move-boot_cpu_id-declartion-to-cpu.h.patch
Can't use an undefined value as an ARRAY reference at
./scripts/checkpatch.pl line 453.
I am attaching this file you can also save this file from LKML
--
JSR
On Wed, Jan 7, 2009 at 6:34 PM, Ingo Molnar <[email protected]> wrote:
>
> * Jaswinder Singh Rajput <[email protected]> wrote:
>
>> Hello Andy,
>>
>> On -tip git I am getting this error:
>>
>> $ ./scripts/checkpatch.pl 000*
>> Can't use an undefined value as an ARRAY reference at
>> ./scripts/checkpatch.pl line 451.
>>
>> But earlier it was working great. Is this a feature or a bug.
>
> bug.
>
> One for the akpm bucket i think, Andrew pushed v26 checkpatch to Linus
> yesterday:
>
> 57b9c6d: checkpatch: version: 0.26
> 21caa13: checkpatch: fix the perlcritic errors
> 2b6db5c: checkpatch: struct file_operations should normally be const
> b53c8e1: checkpatch: ensure we actually detect if assignments split across lines
> 2d1bafd: checkpatch: do not report nr_static as a static declaration
> 4635f4f: checkpatch: track #ifdef/#else/#endif when tracking blocks
> 8b1b337: checkpatch: fix continuation detection when handling spacing on operators
> 8054576: checkpatch: loosen spacing on typedef function checks
> 080ba92: checkpatch: try to catch missing VMLINUX_SYMBOL() in vmlinux.lds.h
> 86f9d05: checkpatch: allow parentheses on return for comparisons
> 1e85572: checkpatch: Add warning for p0-patches
> 2a5a2c2: checkpatch: update copyrights
> 50a7dcf: checkpatch: version: 0.25
> 6586386: checkpatch: dissallow spaces between stars in pointer types
> fae17da: checkpatch: comment ends inside strings is most likely not an open comment
> 8e761b0: checkpatch: detect multiple bitfield declarations
> 5fe3af1: checkpatch: __weak is an official attribute
> 383099f: checkpatch: structure member assignments are not complex
> 83242e0: checkpatch: widen implied comment detection to allow multiple stars
> 721c1cb: checkpatch: comment detection may miss an implied comment on the last hunk
> 691d77b6: checkpatch: add checks for in_atomic()
>
> one of those is causing this new warning.
>
it seems error to me :
./scripts/checkpatch.pl
0007-x86-smp.h-move-boot_cpu_id-declartion-to-cpu.h.patch
Can't use an undefined value as an ARRAY reference at
./scripts/checkpatch.pl line 453.
yesterday it was working great.
Thanks
--
JSR
On Wed, Jan 07, 2009 at 06:57:04PM +0530, Jaswinder Singh Rajput wrote:
> On Wed, Jan 7, 2009 at 6:37 PM, Andy Whitcroft <[email protected]> wrote:
> > On Wed, Jan 07, 2009 at 06:24:55PM +0530, Jaswinder Singh Rajput wrote:
> >> Hello Andy,
> >>
> >> On -tip git I am getting this error:
> >>
> >> $ ./scripts/checkpatch.pl 000*
> >> Can't use an undefined value as an ARRAY reference at
> >> ./scripts/checkpatch.pl line 451.
> >>
> >> But earlier it was working great. Is this a feature or a bug.
> >
> > That looks wrong indeed. Assuming that is the same version I have here
> > then that is a bug in the #else preprocessor handling. Could you send
> > me the specific patch which is throwing this error.
> >
>
> ./scripts/checkpatch.pl
> 0007-x86-smp.h-move-boot_cpu_id-declartion-to-cpu.h.patch
> Can't use an undefined value as an ARRAY reference at
> ./scripts/checkpatch.pl line 453.
>
> I am attaching this file you can also save this file from LKML
Thanks thats great. I think I have this fixed in my tree now. Can you
test with the version at the url below:
http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing
-apw
On Thu, Jan 8, 2009 at 5:20 AM, Andy Whitcroft <[email protected]> wrote:
>
> Thanks thats great. I think I have this fixed in my tree now. Can you
> test with the version at the url below:
>
> http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing
>
Thanks Andy, this works for me.
--
JSR
* Jaswinder Singh Rajput <[email protected]> wrote:
> On Thu, Jan 8, 2009 at 5:20 AM, Andy Whitcroft <[email protected]> wrote:
> >
> > Thanks thats great. I think I have this fixed in my tree now. Can you
> > test with the version at the url below:
> >
> > http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing
> >
>
> Thanks Andy, this works for me.
Could we please push this fix upstream ASAP?
Ingo
On Thu, Jan 08, 2009 at 03:54:10PM +0100, Ingo Molnar wrote:
>
> * Jaswinder Singh Rajput <[email protected]> wrote:
>
> > On Thu, Jan 8, 2009 at 5:20 AM, Andy Whitcroft <[email protected]> wrote:
> > >
> > > Thanks thats great. I think I have this fixed in my tree now. Can you
> > > test with the version at the url below:
> > >
> > > http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing
> > >
> >
> > Thanks Andy, this works for me.
>
> Could we please push this fix upstream ASAP?
Sure. Thing. I only have a couple of patches in my queue.
-apw