2009-01-26 01:59:42

by Nick Andrew

[permalink] [raw]
Subject: [TRIVIAL PATCH 00/20] Fix misspelling of "firmware"

Fix more misspellings of "firmware" which I noticed in v2.6.29-rc2. All are
comment changes.

Nick.
---

Nick Andrew (20):
Fix misspelling of firmware in iwl-agn.c
Fix misspelling of firmware in iwl3945-base.c
Fix misspelling of firmware in hpmain.c
Fix misspelling of firmware in head_64.S
Fix misspelling of firmware in aica.c
Fix misspelling of firmware in pss.c
Fix misspelling of firmware in disk.c
Fix misspelling of firmware in libata.h
Fix misspelling of firmware in ChangeLog.history
Fix misspelling of firmware in ueagle-atm.c
Fix misspelling of firmware in pci.c
Fix misspelling of firmware in cmd.c
Fix misspelling of firmware in ipw2200.c
Fix misspelling of firmware in ipw2100.c
Fix misspelling of firmware in tg3.c
Fix misspelling of firmware in sb1250-mac.c
Fix misspelling of firmware in thinkpad_acpi.c
Fix misspelling of "firmware" in ip27-smp.c
Fix misspelling of "firmware" in firmware.txt
Fix misspelling of "firmware" in ia64-kvm.txt


Documentation/ia64/kvm.txt | 2 +-
.../dts-bindings/fsl/cpm_qe/qe/firmware.txt | 2 +-
arch/mips/sgi-ip27/ip27-smp.c | 2 +-
arch/sparc/kernel/head_64.S | 2 +-
drivers/net/sb1250-mac.c | 2 +-
drivers/net/tg3.c | 2 +-
drivers/net/wireless/ipw2x00/ipw2100.c | 2 +-
drivers/net/wireless/ipw2x00/ipw2200.c | 2 +-
drivers/net/wireless/iwlwifi/iwl-agn.c | 2 +-
drivers/net/wireless/iwlwifi/iwl3945-base.c | 2 +-
drivers/net/wireless/libertas/cmd.c | 2 +-
drivers/pci/pci.c | 2 +-
drivers/platform/x86/thinkpad_acpi.c | 2 +-
drivers/staging/otus/hal/hpmain.c | 2 +-
drivers/usb/atm/ueagle-atm.c | 2 +-
drivers/usb/serial/ChangeLog.history | 2 +-
include/linux/libata.h | 2 +-
kernel/power/disk.c | 4 ++--
sound/oss/pss.c | 2 +-
sound/sh/aica.c | 2 +-
20 files changed, 21 insertions(+), 21 deletions(-)

--
PGP Key ID = 0x418487E7 http://www.nick-andrew.net/
PGP Key fingerprint = B3ED 6894 8E49 1770 C24A 67E3 6266 6EB9 4184 87E7


2009-01-26 02:02:01

by Nick Andrew

[permalink] [raw]
Subject: [TRIVIAL PATCH 03/20] Fix misspelling of "firmware" in ip27-smp.c

Fix misspelling of "firmware" in ip27-smp.c

Signed-off-by: Nick Andrew <[email protected]>
---

arch/mips/sgi-ip27/ip27-smp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/arch/mips/sgi-ip27/ip27-smp.c b/arch/mips/sgi-ip27/ip27-smp.c
index 5b47d6b..cbcd7eb 100644
--- a/arch/mips/sgi-ip27/ip27-smp.c
+++ b/arch/mips/sgi-ip27/ip27-smp.c
@@ -221,7 +221,7 @@ static void __init ip27_smp_setup(void)
* Assumption to be fixed: we're always booted on logical / physical
* processor 0. While we're always running on logical processor 0
* this still means this is physical processor zero; it might for
- * example be disabled in the firwware.
+ * example be disabled in the firmware.
*/
alloc_cpupda(0, 0);
}

2009-01-26 02:02:25

by Nick Andrew

[permalink] [raw]
Subject: [TRIVIAL PATCH 04/20] Fix misspelling of firmware in thinkpad_acpi.c

Fix misspelling of firmware in thinkpad_acpi.c

Signed-off-by: Nick Andrew <[email protected]>
---

drivers/platform/x86/thinkpad_acpi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index bcbc051..54e0cbc 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -5811,7 +5811,7 @@ static struct ibm_struct volume_driver_data = {
* ThinkPads from this same time period (and earlier) probably lack the
* tachometer as well.
*
- * Unfortunately a lot of ThinkPads with new-style ECs but whose firwmare
+ * Unfortunately a lot of ThinkPads with new-style ECs but whose firmware
* was never fixed by IBM to report the EC firmware version string
* probably support the tachometer (like the early X models), so
* detecting it is quite hard. We need more data to know for sure.

2009-01-26 02:02:40

by Nick Andrew

[permalink] [raw]
Subject: [TRIVIAL PATCH 05/20] Fix misspelling of firmware in sb1250-mac.c

Fix misspelling of firmware in sb1250-mac.c

Signed-off-by: Nick Andrew <[email protected]>
---

drivers/net/sb1250-mac.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/drivers/net/sb1250-mac.c b/drivers/net/sb1250-mac.c
index 31e38fa..7fe82c5 100644
--- a/drivers/net/sb1250-mac.c
+++ b/drivers/net/sb1250-mac.c
@@ -2299,7 +2299,7 @@ static int sbmac_init(struct platform_device *pldev, long long base)
eaddr = sc->sbm_hwaddr;

/*
- * Read the ethernet address. The firwmare left this programmed
+ * Read the ethernet address. The firmware left this programmed
* for us in the ethernet address register for each mac.
*/

2009-01-26 02:02:59

by Nick Andrew

[permalink] [raw]
Subject: [TRIVIAL PATCH 06/20] Fix misspelling of firmware in tg3.c

Fix misspelling of firmware in tg3.c

Signed-off-by: Nick Andrew <[email protected]>
---

drivers/net/tg3.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 5e2dbae..96ede2a 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -11130,7 +11130,7 @@ static int __devinit tg3_phy_probe(struct tg3 *tp)
return tg3_phy_init(tp);

/* Reading the PHY ID register can conflict with ASF
- * firwmare access to the PHY hardware.
+ * firmware access to the PHY hardware.
*/
err = 0;
if ((tp->tg3_flags & TG3_FLAG_ENABLE_ASF) ||

2009-01-26 02:03:25

by Nick Andrew

[permalink] [raw]
Subject: [TRIVIAL PATCH 07/20] Fix misspelling of firmware in ipw2100.c

Fix misspelling of firmware in ipw2100.c

Signed-off-by: Nick Andrew <[email protected]>
---

drivers/net/wireless/ipw2x00/ipw2100.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/drivers/net/wireless/ipw2x00/ipw2100.c b/drivers/net/wireless/ipw2x00/ipw2100.c
index 823c2bf..9170c23 100644
--- a/drivers/net/wireless/ipw2x00/ipw2100.c
+++ b/drivers/net/wireless/ipw2x00/ipw2100.c
@@ -2355,7 +2355,7 @@ static void ipw2100_corruption_detected(struct ipw2100_priv *priv, int i)
i * sizeof(struct ipw2100_status));

#ifdef IPW2100_DEBUG_C3
- /* Halt the fimrware so we can get a good image */
+ /* Halt the firmware so we can get a good image */
write_register(priv->net_dev, IPW_REG_RESET_REG,
IPW_AUX_HOST_RESET_REG_STOP_MASTER);
j = 5;

2009-01-26 02:03:56

by Nick Andrew

[permalink] [raw]
Subject: [TRIVIAL PATCH 08/20] Fix misspelling of firmware in ipw2200.c

Fix misspelling of firmware in ipw2200.c

Signed-off-by: Nick Andrew <[email protected]>
---

drivers/net/wireless/ipw2x00/ipw2200.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/drivers/net/wireless/ipw2x00/ipw2200.c b/drivers/net/wireless/ipw2x00/ipw2200.c
index 625f2cf..492f5b7 100644
--- a/drivers/net/wireless/ipw2x00/ipw2200.c
+++ b/drivers/net/wireless/ipw2x00/ipw2200.c
@@ -8827,7 +8827,7 @@ static int ipw_wx_set_mode(struct net_device *dev,
#endif /* CONFIG_IPW2200_MONITOR */

/* Free the existing firmware and reset the fw_loaded
- * flag so ipw_load() will bring in the new firmawre */
+ * flag so ipw_load() will bring in the new firmware */
free_firmware();

priv->ieee->iw_mode = wrqu->mode;

2009-01-26 02:04:27

by Nick Andrew

[permalink] [raw]
Subject: [TRIVIAL PATCH 09/20] Fix misspelling of firmware in cmd.c

Fix misspelling of firmware in cmd.c

Signed-off-by: Nick Andrew <[email protected]>
---

drivers/net/wireless/libertas/cmd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/drivers/net/wireless/libertas/cmd.c b/drivers/net/wireless/libertas/cmd.c
index 639dd02..8c3605c 100644
--- a/drivers/net/wireless/libertas/cmd.c
+++ b/drivers/net/wireless/libertas/cmd.c
@@ -1649,7 +1649,7 @@ static struct cmd_ctrl_node *lbs_get_cmd_ctrl_node(struct lbs_private *priv)

/**
* @brief This function executes next command in command
- * pending queue. It will put fimware back to PS mode
+ * pending queue. It will put firmware back to PS mode
* if applicable.
*
* @param priv A pointer to struct lbs_private structure

2009-01-26 02:04:58

by Nick Andrew

[permalink] [raw]
Subject: [TRIVIAL PATCH 10/20] Fix misspelling of firmware in pci.c

Fix misspelling of firmware in pci.c

Signed-off-by: Nick Andrew <[email protected]>
---

drivers/pci/pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index e491fde..ab2aa4a 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -544,7 +544,7 @@ void pci_update_current_state(struct pci_dev *dev, pci_power_t state)
* @dev: PCI device to handle.
* @state: PCI power state (D0, D1, D2, D3hot) to put the device into.
*
- * Transition a device to a new power state, using the platform formware and/or
+ * Transition a device to a new power state, using the platform firmware and/or
* the device's PCI PM registers.
*
* RETURN VALUE:

2009-01-26 02:05:31

by Nick Andrew

[permalink] [raw]
Subject: [TRIVIAL PATCH 11/20] Fix misspelling of firmware in ueagle-atm.c

Fix misspelling of firmware in ueagle-atm.c

Signed-off-by: Nick Andrew <[email protected]>
---

drivers/usb/atm/ueagle-atm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c
index b6483dd..9cf9ff6 100644
--- a/drivers/usb/atm/ueagle-atm.c
+++ b/drivers/usb/atm/ueagle-atm.c
@@ -626,7 +626,7 @@ static void uea_upload_pre_firmware(const struct firmware *fw_entry, void *conte
goto err_fw_corrupted;

/*
- * Start to upload formware : send reset
+ * Start to upload firmware : send reset
*/
value = 1;
ret = uea_send_modem_cmd(usb, F8051_USBCS, sizeof(value), &value);

2009-01-26 02:05:59

by Nick Andrew

[permalink] [raw]
Subject: [TRIVIAL PATCH 12/20] Fix misspelling of firmware in ChangeLog.history

Fix misspelling of firmware in ChangeLog.history

Signed-off-by: Nick Andrew <[email protected]>
---

drivers/usb/serial/ChangeLog.history | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/drivers/usb/serial/ChangeLog.history b/drivers/usb/serial/ChangeLog.history
index c1b2799..f13fd48 100644
--- a/drivers/usb/serial/ChangeLog.history
+++ b/drivers/usb/serial/ChangeLog.history
@@ -715,7 +715,7 @@ io_edgeport.c Change Log comments:

0.2 (01/30/2000) greg kroah-hartman
Milestone 1 release.
- Device is found by USB subsystem, enumerated, fimware is downloaded
+ Device is found by USB subsystem, enumerated, firmware is downloaded
and the descriptors are printed to the debug log, config is set, and
green light starts to blink. Open port works, and data can be sent
and received at the default settings of the UART. Loopback connector

2009-01-26 02:06:31

by Nick Andrew

[permalink] [raw]
Subject: [TRIVIAL PATCH 13/20] Fix misspelling of firmware in libata.h

Fix misspelling of firmware in libata.h

Signed-off-by: Nick Andrew <[email protected]>
---

include/linux/libata.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/include/linux/libata.h b/include/linux/libata.h
index 2c6bd66..76bc61f 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -377,7 +377,7 @@ enum {
ATA_HORKAGE_BRIDGE_OK = (1 << 10), /* no bridge limits */
ATA_HORKAGE_ATAPI_MOD16_DMA = (1 << 11), /* use ATAPI DMA for commands
not multiple of 16 bytes */
- ATA_HORKAGE_FIRMWARE_WARN = (1 << 12), /* firwmare update warning */
+ ATA_HORKAGE_FIRMWARE_WARN = (1 << 12), /* firmware update warning */

/* DMA mask for user DMA control: User visible values; DO NOT
renumber */

2009-01-26 02:06:59

by Nick Andrew

[permalink] [raw]
Subject: [TRIVIAL PATCH 01/20] Fix misspelling of "firmware" in ia64-kvm.txt

Fix misspelling of "firmware" in ia64-kvm.txt

Signed-off-by: Nick Andrew <[email protected]>
---

Documentation/ia64/kvm.txt | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/Documentation/ia64/kvm.txt b/Documentation/ia64/kvm.txt
index 84f7cb3..ffb5c80 100644
--- a/Documentation/ia64/kvm.txt
+++ b/Documentation/ia64/kvm.txt
@@ -42,7 +42,7 @@ Note: For step 2, please make sure that host page size == TARGET_PAGE_SIZE of qe
hg clone http://xenbits.xensource.com/ext/efi-vfirmware.hg
you can get the firmware's binary in the directory of efi-vfirmware.hg/binaries.

- (3) Rename the firware you owned to Flash.fd, and copy it to /usr/local/share/qemu
+ (3) Rename the firmware you owned to Flash.fd, and copy it to /usr/local/share/qemu

4. Boot up Linux or Windows guests:
4.1 Create or install a image for guest boot. If you have xen experience, it should be easy.

2009-01-26 02:07:25

by Nick Andrew

[permalink] [raw]
Subject: [TRIVIAL PATCH 14/20] Fix misspelling of firmware in disk.c

Fix misspelling of firmware in disk.c

Signed-off-by: Nick Andrew <[email protected]>
---

kernel/power/disk.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)


diff --git a/kernel/power/disk.c b/kernel/power/disk.c
index 45e8541..760e863 100644
--- a/kernel/power/disk.c
+++ b/kernel/power/disk.c
@@ -249,7 +249,7 @@ static int create_image(int platform_mode)
* hibernation_snapshot - quiesce devices and create the hibernation
* snapshot image.
* @platform_mode - if set, use the platform driver, if available, to
- * prepare the platform frimware for the power transition.
+ * prepare the platform firmware for the power transition.
*
* Must be called with pm_mutex held
*/
@@ -360,7 +360,7 @@ static int resume_target_kernel(void)
* hibernation_restore - quiesce devices and restore the hibernation
* snapshot image. If successful, control returns in hibernation_snaphot()
* @platform_mode - if set, use the platform driver, if available, to
- * prepare the platform frimware for the transition.
+ * prepare the platform firmware for the transition.
*
* Must be called with pm_mutex held
*/

2009-01-26 02:07:49

by Nick Andrew

[permalink] [raw]
Subject: [TRIVIAL PATCH 02/20] Fix misspelling of "firmware" in firmware.txt

Fix misspelling of "firmware" in firmware.txt

Signed-off-by: Nick Andrew <[email protected]>
---

.../dts-bindings/fsl/cpm_qe/qe/firmware.txt | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/Documentation/powerpc/dts-bindings/fsl/cpm_qe/qe/firmware.txt b/Documentation/powerpc/dts-bindings/fsl/cpm_qe/qe/firmware.txt
index 6c238f5..249db3a 100644
--- a/Documentation/powerpc/dts-bindings/fsl/cpm_qe/qe/firmware.txt
+++ b/Documentation/powerpc/dts-bindings/fsl/cpm_qe/qe/firmware.txt
@@ -1,6 +1,6 @@
* Uploaded QE firmware

- If a new firwmare has been uploaded to the QE (usually by the
+ If a new firmware has been uploaded to the QE (usually by the
boot loader), then a 'firmware' child node should be added to the QE
node. This node provides information on the uploaded firmware that
device drivers may need.

2009-01-26 02:08:09

by Nick Andrew

[permalink] [raw]
Subject: [TRIVIAL PATCH 15/20] Fix misspelling of firmware in pss.c

Fix misspelling of firmware in pss.c

Signed-off-by: Nick Andrew <[email protected]>
---

sound/oss/pss.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/sound/oss/pss.c b/sound/oss/pss.c
index 16ed069..902b39e 100644
--- a/sound/oss/pss.c
+++ b/sound/oss/pss.c
@@ -46,7 +46,7 @@
* load the driver as it did in previous versions.
* 04-07-1999: Anthony Barbachan <[email protected]>
* Added module parameter pss_firmware to allow the user to tell
- * the driver where the fireware file is located. The default
+ * the driver where the firmware file is located. The default
* setting is the previous hardcoded setting "/etc/sound/pss_synth".
* 00-03-03: Christoph Hellwig <[email protected]>
* Adapted to module_init/module_exit

2009-01-26 02:08:34

by Nick Andrew

[permalink] [raw]
Subject: [TRIVIAL PATCH 16/20] Fix misspelling of firmware in aica.c

Fix misspelling of firmware in aica.c

Signed-off-by: Nick Andrew <[email protected]>
---

sound/sh/aica.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/sound/sh/aica.c b/sound/sh/aica.c
index 7c920f3..b1a5229 100644
--- a/sound/sh/aica.c
+++ b/sound/sh/aica.c
@@ -565,7 +565,7 @@ static int load_aica_firmware(void)
err = request_firmware(&fw_entry, "aica_firmware.bin", &pd->dev);
if (unlikely(err))
return err;
- /* write firware into memory */
+ /* write firmware into memory */
spu_disable();
spu_memload(0, fw_entry->data, fw_entry->size);
spu_enable();

2009-01-26 02:08:53

by Nick Andrew

[permalink] [raw]
Subject: [TRIVIAL PATCH 17/20] Fix misspelling of firmware in head_64.S

Fix misspelling of firmware in head_64.S

Signed-off-by: Nick Andrew <[email protected]>
---

arch/sparc/kernel/head_64.S | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/arch/sparc/kernel/head_64.S b/arch/sparc/kernel/head_64.S
index 8ffee71..fcd0810 100644
--- a/arch/sparc/kernel/head_64.S
+++ b/arch/sparc/kernel/head_64.S
@@ -686,7 +686,7 @@ tlb_fixup_done:
* point.
*
* There used to be enormous complexity wrt. transferring
- * over from the firwmare's trap table to the Linux kernel's.
+ * over from the firmware's trap table to the Linux kernel's.
* For example, there was a chicken & egg problem wrt. building
* the OBP page tables, yet needing to be on the Linux kernel
* trap table (to translate PAGE_OFFSET addresses) in order to

2009-01-26 02:09:19

by Nick Andrew

[permalink] [raw]
Subject: [TRIVIAL PATCH 18/20] Fix misspelling of firmware in hpmain.c

Fix misspelling of firmware in hpmain.c

Signed-off-by: Nick Andrew <[email protected]>
---

drivers/staging/otus/hal/hpmain.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/drivers/staging/otus/hal/hpmain.c b/drivers/staging/otus/hal/hpmain.c
index 2e65c46..dab2783 100644
--- a/drivers/staging/otus/hal/hpmain.c
+++ b/drivers/staging/otus/hal/hpmain.c
@@ -152,7 +152,7 @@ u16_t zfHpInit(zdev_t* dev, u32_t frequency)
else
{
#ifndef ZM_OTUS_LINUX_PHASE_2
- /* donwload the normal frimware */
+ /* download the normal firmware */
if ((ret = zfFirmwareDownload(dev, (u32_t*)zcFwImage,
(u32_t)zcFwImageSize, ZM_FIRMWARE_WLAN_ADDR)) != ZM_SUCCESS)
{

2009-01-26 02:09:44

by Nick Andrew

[permalink] [raw]
Subject: [TRIVIAL PATCH 19/20] Fix misspelling of firmware in iwl3945-base.c

Fix misspelling of firmware in iwl3945-base.c

Signed-off-by: Nick Andrew <[email protected]>
---

drivers/net/wireless/iwlwifi/iwl3945-base.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/net/wireless/iwlwifi/iwl3945-base.c
index d645808..85e465f 100644
--- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
+++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
@@ -5361,7 +5361,7 @@ static int iwl3945_read_ucode(struct iwl3945_priv *priv)

/* api_ver should match the api version forming part of the
* firmware filename ... but we don't check for that and only rely
- * on the API version read from firware header from here on forward */
+ * on the API version read from firmware header from here on forward */

if (api_ver < api_min || api_ver > api_max) {
IWL_ERROR("Driver unable to support your firmware API. "

2009-01-26 02:10:22

by Nick Andrew

[permalink] [raw]
Subject: [TRIVIAL PATCH 20/20] Fix misspelling of firmware in iwl-agn.c

Fix misspelling of firmware in iwl-agn.c

Signed-off-by: Nick Andrew <[email protected]>
---

drivers/net/wireless/iwlwifi/iwl-agn.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
index 5da6b35..9740b6d 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
@@ -1623,7 +1623,7 @@ static int iwl_read_ucode(struct iwl_priv *priv)

/* api_ver should match the api version forming part of the
* firmware filename ... but we don't check for that and only rely
- * on the API version read from firware header from here on forward */
+ * on the API version read from firmware header from here on forward */

if (api_ver < api_min || api_ver > api_max) {
IWL_ERROR("Driver unable to support your firmware API. "

2009-01-26 04:02:35

by Alexey Dobriyan

[permalink] [raw]
Subject: Re: [TRIVIAL PATCH 00/20] Fix misspelling of "firmware"

On Mon, Jan 26, 2009 at 12:59:22PM +1100, Nick Andrew wrote:
> Fix more misspellings of "firmware" which I noticed in v2.6.29-rc2. All are
> comment changes.
>
> Nick.
> ---
>
> Nick Andrew (20):
> Fix misspelling of firmware in iwl-agn.c
> Fix misspelling of firmware in iwl3945-base.c
> Fix misspelling of firmware in hpmain.c
> Fix misspelling of firmware in head_64.S
> Fix misspelling of firmware in aica.c
> Fix misspelling of firmware in pss.c
> Fix misspelling of firmware in disk.c
> Fix misspelling of firmware in libata.h
> Fix misspelling of firmware in ChangeLog.history
> Fix misspelling of firmware in ueagle-atm.c
> Fix misspelling of firmware in pci.c
> Fix misspelling of firmware in cmd.c
> Fix misspelling of firmware in ipw2200.c
> Fix misspelling of firmware in ipw2100.c
> Fix misspelling of firmware in tg3.c
> Fix misspelling of firmware in sb1250-mac.c
> Fix misspelling of firmware in thinkpad_acpi.c
> Fix misspelling of "firmware" in ip27-smp.c
> Fix misspelling of "firmware" in firmware.txt
> Fix misspelling of "firmware" in ia64-kvm.txt

Please send one patch next time, nobody wants to see 20 trivial emails.

2009-01-26 10:00:42

by Jiri Kosina

[permalink] [raw]
Subject: Re: [TRIVIAL PATCH 00/20] Fix misspelling of "firmware"

On Mon, 26 Jan 2009, Nick Andrew wrote:

> Fix more misspellings of "firmware" which I noticed in v2.6.29-rc2. All are
> comment changes.
> Nick.
> ---
>
> Nick Andrew (20):
> Fix misspelling of firmware in iwl-agn.c
> Fix misspelling of firmware in iwl3945-base.c
> Fix misspelling of firmware in hpmain.c
> Fix misspelling of firmware in head_64.S
> Fix misspelling of firmware in aica.c
> Fix misspelling of firmware in pss.c
> Fix misspelling of firmware in disk.c
> Fix misspelling of firmware in libata.h
> Fix misspelling of firmware in ChangeLog.history
> Fix misspelling of firmware in ueagle-atm.c
> Fix misspelling of firmware in pci.c
> Fix misspelling of firmware in cmd.c
> Fix misspelling of firmware in ipw2200.c
> Fix misspelling of firmware in ipw2100.c
> Fix misspelling of firmware in tg3.c
> Fix misspelling of firmware in sb1250-mac.c
> Fix misspelling of firmware in thinkpad_acpi.c
> Fix misspelling of "firmware" in ip27-smp.c
> Fix misspelling of "firmware" in firmware.txt
> Fix misspelling of "firmware" in ia64-kvm.txt

I will fold all this into single patch and apply.

Thanks,

--
Jiri Kosina
SUSE Labs

2009-01-26 14:39:30

by Tarkan Erimer

[permalink] [raw]
Subject: Re: [TRIVIAL PATCH 00/20] Fix misspelling of "firmware"

On 01/26/2009 12:00 PM, Jiri Kosina wrote:
> On Mon, 26 Jan 2009, Nick Andrew wrote:
>
>
>> Fix more misspellings of "firmware" which I noticed in v2.6.29-rc2. All are
>> comment changes.
>> Nick.
>> ---
>>
>> Nick Andrew (20):
>> Fix misspelling of firmware in iwl-agn.c
>> Fix misspelling of firmware in iwl3945-base.c
>> Fix misspelling of firmware in hpmain.c
>> Fix misspelling of firmware in head_64.S
>> Fix misspelling of firmware in aica.c
>> Fix misspelling of firmware in pss.c
>> Fix misspelling of firmware in disk.c
>> Fix misspelling of firmware in libata.h
>> Fix misspelling of firmware in ChangeLog.history
>> Fix misspelling of firmware in ueagle-atm.c
>> Fix misspelling of firmware in pci.c
>> Fix misspelling of firmware in cmd.c
>> Fix misspelling of firmware in ipw2200.c
>> Fix misspelling of firmware in ipw2100.c
>> Fix misspelling of firmware in tg3.c
>> Fix misspelling of firmware in sb1250-mac.c
>> Fix misspelling of firmware in thinkpad_acpi.c
>> Fix misspelling of "firmware" in ip27-smp.c
>> Fix misspelling of "firmware" in firmware.txt
>> Fix misspelling of "firmware" in ia64-kvm.txt
>>
>
> I will fold all this into single patch and apply.
>
> Thanks,
>
>
"Fix misspelling of firmware in tg3.c" didn't help me to solve tg3
firmware issue which I submitted via "[BUG] tg3 module problem on
Linux-2.6.29-rc1-2" subjected email at 21st of Jan. I re-compiled
2.6.29-rc2 with this patch and still having the same error message :

Using mkinitramfs-kpkg to build the ramdisk.
W: Possible missing firmware
/lib/firmware/2.6.29-rc2-git1/tigon/tg3_tso5.bin for module tg3
W: Possible missing firmware
/lib/firmware/2.6.29-rc2-git1/tigon/tg3_tso.bin for module tg3
W: Possible missing firmware /lib/firmware/2.6.29-rc2-git1/tigon/tg3.bin
for module tg3


Tarkan ERIMER

2009-01-26 17:08:00

by Jiri Kosina

[permalink] [raw]
Subject: Re: [TRIVIAL PATCH 00/20] Fix misspelling of "firmware"

On Mon, 26 Jan 2009, Tarkan Erimer wrote:

> "Fix misspelling of firmware in tg3.c" didn't help me to solve tg3
> firmware issue which I submitted via "[BUG] tg3 module problem on
> Linux-2.6.29-rc1-2" subjected email at 21st of Jan. I re-compiled
> 2.6.29-rc2 with this patch and still having the same error message :
> Using mkinitramfs-kpkg to build the ramdisk.
> W: Possible missing firmware /lib/firmware/2.6.29-rc2-git1/tigon/tg3_tso5.bin
> for module tg3
> W: Possible missing firmware /lib/firmware/2.6.29-rc2-git1/tigon/tg3_tso.bin
> for module tg3
> W: Possible missing firmware /lib/firmware/2.6.29-rc2-git1/tigon/tg3.bin for
> module tg3

Yes, Nick's patch is not supposed to fix this, it's just a fix of a
comment in the source code, that has no effect on the behavior of the
driver. So this is completely separate issue, that you should report to
the proper place, which is

BROADCOM TG3 GIGABIT ETHERNET DRIVER
P: Michael Chan
M: [email protected]
L: [email protected]
S: Supported

--
Jiri Kosina
SUSE Labs

2009-01-27 06:35:40

by Jaswinder Singh

[permalink] [raw]
Subject: Re: [TRIVIAL PATCH 00/20] Fix misspelling of "firmware"

On Mon, Jan 26, 2009 at 8:09 PM, Tarkan Erimer
<[email protected]> wrote:
> On 01/26/2009 12:00 PM, Jiri Kosina wrote:
>>
>> On Mon, 26 Jan 2009, Nick Andrew wrote:
>>
>>
>>>
>>> Fix more misspellings of "firmware" which I noticed in v2.6.29-rc2. All
>>> are
>>> comment changes.
>>> Nick.
>>> ---
>>>
>>> Nick Andrew (20):
>>> Fix misspelling of firmware in iwl-agn.c
>>> Fix misspelling of firmware in iwl3945-base.c
>>> Fix misspelling of firmware in hpmain.c
>>> Fix misspelling of firmware in head_64.S
>>> Fix misspelling of firmware in aica.c
>>> Fix misspelling of firmware in pss.c
>>> Fix misspelling of firmware in disk.c
>>> Fix misspelling of firmware in libata.h
>>> Fix misspelling of firmware in ChangeLog.history
>>> Fix misspelling of firmware in ueagle-atm.c
>>> Fix misspelling of firmware in pci.c
>>> Fix misspelling of firmware in cmd.c
>>> Fix misspelling of firmware in ipw2200.c
>>> Fix misspelling of firmware in ipw2100.c
>>> Fix misspelling of firmware in tg3.c
>>> Fix misspelling of firmware in sb1250-mac.c
>>> Fix misspelling of firmware in thinkpad_acpi.c
>>> Fix misspelling of "firmware" in ip27-smp.c
>>> Fix misspelling of "firmware" in firmware.txt
>>> Fix misspelling of "firmware" in ia64-kvm.txt
>>>
>>
>> I will fold all this into single patch and apply.
>>
>> Thanks,
>>
>>
>
> "Fix misspelling of firmware in tg3.c" didn't help me to solve tg3 firmware
> issue which I submitted via "[BUG] tg3 module problem on Linux-2.6.29-rc1-2"
> subjected email at 21st of Jan. I re-compiled 2.6.29-rc2 with this patch and
> still having the same error message :
>
> Using mkinitramfs-kpkg to build the ramdisk.
> W: Possible missing firmware
> /lib/firmware/2.6.29-rc2-git1/tigon/tg3_tso5.bin for module tg3
> W: Possible missing firmware /lib/firmware/2.6.29-rc2-git1/tigon/tg3_tso.bin
> for module tg3
> W: Possible missing firmware /lib/firmware/2.6.29-rc2-git1/tigon/tg3.bin for
> module tg3
>
>

I send post to your original thread and also also CC to concern persons.

--
JSR

2009-01-27 07:39:33

by Tarkan Erimer

[permalink] [raw]
Subject: Re: [TRIVIAL PATCH 00/20] Fix misspelling of "firmware"

Jiri Kosina wrote:
> Yes, Nick's patch is not supposed to fix this, it's just a fix of a
> comment in the source code, that has no effect on the behavior of the
> driver. So this is completely separate issue, that you should report to
> the proper place, which is
>
> BROADCOM TG3 GIGABIT ETHERNET DRIVER
> P: Michael Chan
> M: [email protected]
> L: [email protected]
> S: Supported
>
>
Arrrgghhh! I got it. Sorry for the noise :-)
Ok, thanks for pointing. I'll report it to the proper place/people.

Tarkan ERIMER

2009-01-27 07:40:28

by Nick Andrew

[permalink] [raw]
Subject: Re: [TRIVIAL PATCH 00/20] Fix misspelling of "firmware"

On Mon, Jan 26, 2009 at 11:00:32AM +0100, Jiri Kosina wrote:
> I will fold all this into single patch and apply.

Ok Jiri. Just to note - last time I submitted a single patch like this
("fix use of loose" in April 2008) to trivial@, the patch frequently
failed to merge due to some of the files being modified, renamed
etc in the meantime, and the patch got dropped. When I split it into
one patch per file and sent them to subsystem maintainers, about 90%
of the patches were merged.

So my impression is that multiple single file patches are more
successful. It should be easier for you to drop any patches which
fail to merge due to other work. But if you think a single patch
is best, I'll submit a single patch.

Nick.

2009-01-27 07:55:32

by Tarkan Erimer

[permalink] [raw]
Subject: Re: [TRIVIAL PATCH 00/20] Fix misspelling of "firmware"

Jaswinder Singh Rajput wrote:
> I send post to your original thread and also also CC to concern persons.
>
> --
> JSR
>
Thanks. I already replied it.

Tarkan ERIMER