2010-02-21 15:32:28

by Jaswinder Singh Rajput

Subject: How to disable configfs_example modules

Hello Randy,

I am trying to build no modules but unfortunately I am getting 3 modules
with http://userweb.kernel.org/~jaswinder/Corei7/config-i7-64.txt :

INSTALL Documentation/filesystems/configfs/configfs_example_explicit.ko
INSTALL Documentation/filesystems/configfs/configfs_example_macros.ko
INSTALL drivers/scsi/scsi_wait_scan.ko

How can I get rid of configfs_example modules.

What is the magic in 'ifneq ($(CONFIG_CONFIGFS_FS),)' :

Documentation/filesystems/configfs/Makefile :
ifneq ($(CONFIG_CONFIGFS_FS),)
obj-m += configfs_example_explicit.o configfs_example_macros.o
endif

Thanks,
--
Jaswinder Singh.

2010-02-21 18:10:59

by Randy Dunlap

Subject: [PATCH] Re: How to disable configfs_example modules

On 02/21/10 07:18, Jaswinder Singh Rajput wrote:
> Hello Randy,

Hi Jaswinder,

> I am trying to build no modules but unfortunately I am getting 3 modules
> with http://userweb.kernel.org/~jaswinder/Corei7/config-i7-64.txt :
>
> INSTALL Documentation/filesystems/configfs/configfs_example_explicit.ko
> INSTALL Documentation/filesystems/configfs/configfs_example_macros.ko
> INSTALL drivers/scsi/scsi_wait_scan.ko
>
> How can I get rid of configfs_example modules.
>
> What is the magic in 'ifneq ($(CONFIG_CONFIGFS_FS),)' :

That just says: if CONFIG_CONFIGFS_FS neq empty_string
[where the empty_string is between the ",)"]

> Documentation/filesystems/configfs/Makefile :
> ifneq ($(CONFIG_CONFIGFS_FS),)
> obj-m += configfs_example_explicit.o configfs_example_macros.o
> endif


I think that this patch will do it. Please let me know if it
does not work.

---
From: Randy Dunlap <[email protected]>

Documentation/ source files that are kernel modules should
not be built when CONFIG_MODULES is not enabled, so change
the Makefile to enforce that.

Signed-off-by: Randy Dunlap <[email protected]>
---
Documentation/filesystems/configfs/Makefile | 2 ++
1 file changed, 2 insertions(+)

--- lnx-2633-rc8.orig/Documentation/filesystems/configfs/Makefile
+++ lnx-2633-rc8/Documentation/filesystems/configfs/Makefile
@@ -1,3 +1,5 @@
+ifeq ($(CONFIG_MODULES),1)
ifneq ($(CONFIG_CONFIGFS_FS),)
obj-m += configfs_example_explicit.o configfs_example_macros.o
endif
+endif

2010-02-21 18:52:25

by Jaswinder Singh

Subject: Re: [PATCH] Re: How to disable configfs_example modules

Hello Randy,

On Sun, Feb 21, 2010 at 11:39 PM, Randy Dunlap <[email protected]> wrote:
> On 02/21/10 07:18, Jaswinder Singh Rajput wrote:
>> I am trying to build no modules but unfortunately I am getting 3 modules
>> with http://userweb.kernel.org/~jaswinder/Corei7/config-i7-64.txt :
>>
>> ? INSTALL Documentation/filesystems/configfs/configfs_example_explicit.ko
>> ? INSTALL Documentation/filesystems/configfs/configfs_example_macros.ko
>> ? INSTALL drivers/scsi/scsi_wait_scan.ko
>>
>> How can I get rid of configfs_example modules.
>>
>> What is the magic in 'ifneq ($(CONFIG_CONFIGFS_FS),)' :
>
> That just says: if CONFIG_CONFIGFS_FS neq empty_string
> ?[where the empty_string is between the ",)"]
>

Thanks for the explanation by disabling CONFIG_CONFIGFS_FS, I get rid
of configfs_example modules. Patch is not required.

Thanks for your help,
--
Jaswinder Singh.