2019-07-31 07:49:45

by Yue Haibing

[permalink] [raw]
Subject: [PATCH -next] RDMA/hns: remove set but not used variable 'irq_num'

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/infiniband/hw/hns/hns_roce_hw_v2.c: In function hns_roce_v2_cleanup_eq_table:
drivers/infiniband/hw/hns/hns_roce_hw_v2.c:5920:6:
warning: variable irq_num set but not used [-Wunused-but-set-variable]

It is not used since
commit 33db6f94847c ("RDMA/hns: Refactor eq table init for hip08")

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: YueHaibing <[email protected]>
---
drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
index 83c58be..59f88bf0 100644
--- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
+++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
@@ -5917,12 +5917,10 @@ static int hns_roce_v2_init_eq_table(struct hns_roce_dev *hr_dev)
static void hns_roce_v2_cleanup_eq_table(struct hns_roce_dev *hr_dev)
{
struct hns_roce_eq_table *eq_table = &hr_dev->eq_table;
- int irq_num;
int eq_num;
int i;

eq_num = hr_dev->caps.num_comp_vectors + hr_dev->caps.num_aeq_vectors;
- irq_num = eq_num + hr_dev->caps.num_other_vectors;

/* Disable irq */
hns_roce_v2_int_mask_enable(hr_dev, eq_num, EQ_DISABLE);
--
2.7.4



2019-08-01 10:13:02

by Leon Romanovsky

[permalink] [raw]
Subject: Re: [PATCH -next] RDMA/hns: remove set but not used variable 'irq_num'

On Wed, Jul 31, 2019 at 03:37:48PM +0800, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/infiniband/hw/hns/hns_roce_hw_v2.c: In function hns_roce_v2_cleanup_eq_table:
> drivers/infiniband/hw/hns/hns_roce_hw_v2.c:5920:6:
> warning: variable irq_num set but not used [-Wunused-but-set-variable]
>
> It is not used since
> commit 33db6f94847c ("RDMA/hns: Refactor eq table init for hip08")
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 --
> 1 file changed, 2 deletions(-)
>

I'm hitting this error too.

Thanks,
Reviewed-by: Leon Romanovsky <[email protected]>

2019-08-01 17:36:40

by Doug Ledford

[permalink] [raw]
Subject: Re: [PATCH -next] RDMA/hns: remove set but not used variable 'irq_num'

On Thu, 2019-08-01 at 13:10 +0300, Leon Romanovsky wrote:
> On Wed, Jul 31, 2019 at 03:37:48PM +0800, YueHaibing wrote:
> > Fixes gcc '-Wunused-but-set-variable' warning:
> >
> > drivers/infiniband/hw/hns/hns_roce_hw_v2.c: In function
> > hns_roce_v2_cleanup_eq_table:
> > drivers/infiniband/hw/hns/hns_roce_hw_v2.c:5920:6:
> > warning: variable irq_num set but not used [-Wunused-but-set-
> > variable]
> >
> > It is not used since
> > commit 33db6f94847c ("RDMA/hns: Refactor eq table init for hip08")
> >
> > Reported-by: Hulk Robot <[email protected]>
> > Signed-off-by: YueHaibing <[email protected]>
> > ---
> > drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
>
> I'm hitting this error too.
>
> Thanks,
> Reviewed-by: Leon Romanovsky <[email protected]>

Applied to for-next, thanks.

--
Doug Ledford <[email protected]>
GPG KeyID: B826A3330E572FDD
Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD


Attachments:
signature.asc (849.00 B)
This is a digitally signed message part