2023-12-18 14:07:49

by Colin Ian King

Subject: [PATCH][next] selftests/net: Fix various spelling mistakes in TCP-AO tests

There are a handful of spelling mistakes in test messages in the
TCP-AIO selftests. Fix these.

Signed-off-by: Colin Ian King <[email protected]>
---
tools/testing/selftests/net/tcp_ao/connect-deny.c | 2 +-
tools/testing/selftests/net/tcp_ao/lib/proc.c | 4 ++--
tools/testing/selftests/net/tcp_ao/setsockopt-closed.c | 2 +-
tools/testing/selftests/net/tcp_ao/unsigned-md5.c | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/tools/testing/selftests/net/tcp_ao/connect-deny.c b/tools/testing/selftests/net/tcp_ao/connect-deny.c
index 1ca78040d8b7..185a2f6e5ff3 100644
--- a/tools/testing/selftests/net/tcp_ao/connect-deny.c
+++ b/tools/testing/selftests/net/tcp_ao/connect-deny.c
@@ -55,7 +55,7 @@ static void try_accept(const char *tst_name, unsigned int port, const char *pwd,
err = test_wait_fd(lsk, timeout, 0);
if (err == -ETIMEDOUT) {
if (!fault(TIMEOUT))
- test_fail("timeouted for accept()");
+ test_fail("timed out for accept()");
} else if (err < 0) {
test_error("test_wait_fd()");
} else {
diff --git a/tools/testing/selftests/net/tcp_ao/lib/proc.c b/tools/testing/selftests/net/tcp_ao/lib/proc.c
index 2322f4d4676d..2fb6dd8adba6 100644
--- a/tools/testing/selftests/net/tcp_ao/lib/proc.c
+++ b/tools/testing/selftests/net/tcp_ao/lib/proc.c
@@ -227,7 +227,7 @@ void netstat_print_diff(struct netstat *nsa, struct netstat *nsb)
}

if (nsb->counters_nr < nsa->counters_nr)
- test_error("Unexpected: some counters dissapeared!");
+ test_error("Unexpected: some counters disappeared!");

for (j = 0, i = 0; i < nsb->counters_nr; i++) {
if (strcmp(nsb->counters[i].name, nsa->counters[j].name)) {
@@ -244,7 +244,7 @@ void netstat_print_diff(struct netstat *nsa, struct netstat *nsb)
j++;
}
if (j != nsa->counters_nr)
- test_error("Unexpected: some counters dissapeared!");
+ test_error("Unexpected: some counters disappeared!");

nsb = nsb->next;
nsa = nsa->next;
diff --git a/tools/testing/selftests/net/tcp_ao/setsockopt-closed.c b/tools/testing/selftests/net/tcp_ao/setsockopt-closed.c
index 7e4601b3f6a3..a329f42f40ce 100644
--- a/tools/testing/selftests/net/tcp_ao/setsockopt-closed.c
+++ b/tools/testing/selftests/net/tcp_ao/setsockopt-closed.c
@@ -427,7 +427,7 @@ static void test_einval_del_key(void)

sk = prepare_defs(TCP_AO_DEL_KEY, &del);
del.set_current = 1;
- setsockopt_checked(sk, TCP_AO_DEL_KEY, &del, ENOENT, "set non-exising current key");
+ setsockopt_checked(sk, TCP_AO_DEL_KEY, &del, ENOENT, "set non-existing current key");

sk = prepare_defs(TCP_AO_DEL_KEY, &del);
del.set_rnext = 1;
diff --git a/tools/testing/selftests/net/tcp_ao/unsigned-md5.c b/tools/testing/selftests/net/tcp_ao/unsigned-md5.c
index 7cffde02d2be..14addfd46468 100644
--- a/tools/testing/selftests/net/tcp_ao/unsigned-md5.c
+++ b/tools/testing/selftests/net/tcp_ao/unsigned-md5.c
@@ -72,7 +72,7 @@ static void try_accept(const char *tst_name, unsigned int port,
err = test_wait_fd(lsk, timeout, 0);
if (err == -ETIMEDOUT) {
if (!fault(TIMEOUT))
- test_fail("timeouted for accept()");
+ test_fail("timed out for accept()");
} else if (err < 0) {
test_error("test_wait_fd()");
} else {
--
2.39.2

2023-12-18 17:59:47

by Dmitry Safonov

Subject: Re: [PATCH][next] selftests/net: Fix various spelling mistakes in TCP-AO tests

On 12/18/23 13:30, Colin Ian King wrote:
> There are a handful of spelling mistakes in test messages in the
> TCP-AIO selftests. Fix these.
>
> Signed-off-by: Colin Ian King <[email protected]>

Thank you, Colin.

The patch looks good to me, my grammar and typos - not so much :-)

Reviewed-by: Dmitry Safonov <[email protected]>

> ---
> tools/testing/selftests/net/tcp_ao/connect-deny.c | 2 +-
> tools/testing/selftests/net/tcp_ao/lib/proc.c | 4 ++--
> tools/testing/selftests/net/tcp_ao/setsockopt-closed.c | 2 +-
> tools/testing/selftests/net/tcp_ao/unsigned-md5.c | 2 +-
> 4 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tools/testing/selftests/net/tcp_ao/connect-deny.c b/tools/testing/selftests/net/tcp_ao/connect-deny.c
> index 1ca78040d8b7..185a2f6e5ff3 100644
> --- a/tools/testing/selftests/net/tcp_ao/connect-deny.c
> +++ b/tools/testing/selftests/net/tcp_ao/connect-deny.c
> @@ -55,7 +55,7 @@ static void try_accept(const char *tst_name, unsigned int port, const char *pwd,
> err = test_wait_fd(lsk, timeout, 0);
> if (err == -ETIMEDOUT) {
> if (!fault(TIMEOUT))
> - test_fail("timeouted for accept()");
> + test_fail("timed out for accept()");
> } else if (err < 0) {
> test_error("test_wait_fd()");
> } else {
> diff --git a/tools/testing/selftests/net/tcp_ao/lib/proc.c b/tools/testing/selftests/net/tcp_ao/lib/proc.c
> index 2322f4d4676d..2fb6dd8adba6 100644
> --- a/tools/testing/selftests/net/tcp_ao/lib/proc.c
> +++ b/tools/testing/selftests/net/tcp_ao/lib/proc.c
> @@ -227,7 +227,7 @@ void netstat_print_diff(struct netstat *nsa, struct netstat *nsb)
> }
>
> if (nsb->counters_nr < nsa->counters_nr)
> - test_error("Unexpected: some counters dissapeared!");
> + test_error("Unexpected: some counters disappeared!");
>
> for (j = 0, i = 0; i < nsb->counters_nr; i++) {
> if (strcmp(nsb->counters[i].name, nsa->counters[j].name)) {
> @@ -244,7 +244,7 @@ void netstat_print_diff(struct netstat *nsa, struct netstat *nsb)
> j++;
> }
> if (j != nsa->counters_nr)
> - test_error("Unexpected: some counters dissapeared!");
> + test_error("Unexpected: some counters disappeared!");
>
> nsb = nsb->next;
> nsa = nsa->next;
> diff --git a/tools/testing/selftests/net/tcp_ao/setsockopt-closed.c b/tools/testing/selftests/net/tcp_ao/setsockopt-closed.c
> index 7e4601b3f6a3..a329f42f40ce 100644
> --- a/tools/testing/selftests/net/tcp_ao/setsockopt-closed.c
> +++ b/tools/testing/selftests/net/tcp_ao/setsockopt-closed.c
> @@ -427,7 +427,7 @@ static void test_einval_del_key(void)
>
> sk = prepare_defs(TCP_AO_DEL_KEY, &del);
> del.set_current = 1;
> - setsockopt_checked(sk, TCP_AO_DEL_KEY, &del, ENOENT, "set non-exising current key");
> + setsockopt_checked(sk, TCP_AO_DEL_KEY, &del, ENOENT, "set non-existing current key");
>
> sk = prepare_defs(TCP_AO_DEL_KEY, &del);
> del.set_rnext = 1;
> diff --git a/tools/testing/selftests/net/tcp_ao/unsigned-md5.c b/tools/testing/selftests/net/tcp_ao/unsigned-md5.c
> index 7cffde02d2be..14addfd46468 100644
> --- a/tools/testing/selftests/net/tcp_ao/unsigned-md5.c
> +++ b/tools/testing/selftests/net/tcp_ao/unsigned-md5.c
> @@ -72,7 +72,7 @@ static void try_accept(const char *tst_name, unsigned int port,
> err = test_wait_fd(lsk, timeout, 0);
> if (err == -ETIMEDOUT) {
> if (!fault(TIMEOUT))
> - test_fail("timeouted for accept()");
> + test_fail("timed out for accept()");
> } else if (err < 0) {
> test_error("test_wait_fd()");
> } else {

Thanks,
Dmitry

2023-12-18 19:27:14

by Randy Dunlap

Subject: Re: [PATCH][next] selftests/net: Fix various spelling mistakes in TCP-AO tests

On 12/18/23 05:30, Colin Ian King wrote:
> There are a handful of spelling mistakes in test messages in the
> TCP-AIO selftests. Fix these.
>
> Signed-off-by: Colin Ian King <[email protected]>

Reviewed-by: Randy Dunlap <[email protected]>

Thanks.

> ---
> tools/testing/selftests/net/tcp_ao/connect-deny.c | 2 +-
> tools/testing/selftests/net/tcp_ao/lib/proc.c | 4 ++--
> tools/testing/selftests/net/tcp_ao/setsockopt-closed.c | 2 +-
> tools/testing/selftests/net/tcp_ao/unsigned-md5.c | 2 +-
> 4 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tools/testing/selftests/net/tcp_ao/connect-deny.c b/tools/testing/selftests/net/tcp_ao/connect-deny.c
> index 1ca78040d8b7..185a2f6e5ff3 100644
> --- a/tools/testing/selftests/net/tcp_ao/connect-deny.c
> +++ b/tools/testing/selftests/net/tcp_ao/connect-deny.c
> @@ -55,7 +55,7 @@ static void try_accept(const char *tst_name, unsigned int port, const char *pwd,
> err = test_wait_fd(lsk, timeout, 0);
> if (err == -ETIMEDOUT) {
> if (!fault(TIMEOUT))
> - test_fail("timeouted for accept()");
> + test_fail("timed out for accept()");
> } else if (err < 0) {
> test_error("test_wait_fd()");
> } else {
> diff --git a/tools/testing/selftests/net/tcp_ao/lib/proc.c b/tools/testing/selftests/net/tcp_ao/lib/proc.c
> index 2322f4d4676d..2fb6dd8adba6 100644
> --- a/tools/testing/selftests/net/tcp_ao/lib/proc.c
> +++ b/tools/testing/selftests/net/tcp_ao/lib/proc.c
> @@ -227,7 +227,7 @@ void netstat_print_diff(struct netstat *nsa, struct netstat *nsb)
> }
>
> if (nsb->counters_nr < nsa->counters_nr)
> - test_error("Unexpected: some counters dissapeared!");
> + test_error("Unexpected: some counters disappeared!");
>
> for (j = 0, i = 0; i < nsb->counters_nr; i++) {
> if (strcmp(nsb->counters[i].name, nsa->counters[j].name)) {
> @@ -244,7 +244,7 @@ void netstat_print_diff(struct netstat *nsa, struct netstat *nsb)
> j++;
> }
> if (j != nsa->counters_nr)
> - test_error("Unexpected: some counters dissapeared!");
> + test_error("Unexpected: some counters disappeared!");
>
> nsb = nsb->next;
> nsa = nsa->next;
> diff --git a/tools/testing/selftests/net/tcp_ao/setsockopt-closed.c b/tools/testing/selftests/net/tcp_ao/setsockopt-closed.c
> index 7e4601b3f6a3..a329f42f40ce 100644
> --- a/tools/testing/selftests/net/tcp_ao/setsockopt-closed.c
> +++ b/tools/testing/selftests/net/tcp_ao/setsockopt-closed.c
> @@ -427,7 +427,7 @@ static void test_einval_del_key(void)
>
> sk = prepare_defs(TCP_AO_DEL_KEY, &del);
> del.set_current = 1;
> - setsockopt_checked(sk, TCP_AO_DEL_KEY, &del, ENOENT, "set non-exising current key");
> + setsockopt_checked(sk, TCP_AO_DEL_KEY, &del, ENOENT, "set non-existing current key");
>
> sk = prepare_defs(TCP_AO_DEL_KEY, &del);
> del.set_rnext = 1;
> diff --git a/tools/testing/selftests/net/tcp_ao/unsigned-md5.c b/tools/testing/selftests/net/tcp_ao/unsigned-md5.c
> index 7cffde02d2be..14addfd46468 100644
> --- a/tools/testing/selftests/net/tcp_ao/unsigned-md5.c
> +++ b/tools/testing/selftests/net/tcp_ao/unsigned-md5.c
> @@ -72,7 +72,7 @@ static void try_accept(const char *tst_name, unsigned int port,
> err = test_wait_fd(lsk, timeout, 0);
> if (err == -ETIMEDOUT) {
> if (!fault(TIMEOUT))
> - test_fail("timeouted for accept()");
> + test_fail("timed out for accept()");
> } else if (err < 0) {
> test_error("test_wait_fd()");
> } else {

--
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html

2023-12-22 22:20:42

by patchwork-bot+netdevbpf

Subject: Re: [PATCH][next] selftests/net: Fix various spelling mistakes in TCP-AO tests

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <[email protected]>:

On Mon, 18 Dec 2023 13:30:22 +0000 you wrote:
> There are a handful of spelling mistakes in test messages in the
> TCP-AIO selftests. Fix these.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> tools/testing/selftests/net/tcp_ao/connect-deny.c | 2 +-
> tools/testing/selftests/net/tcp_ao/lib/proc.c | 4 ++--
> tools/testing/selftests/net/tcp_ao/setsockopt-closed.c | 2 +-
> tools/testing/selftests/net/tcp_ao/unsigned-md5.c | 2 +-
> 4 files changed, 5 insertions(+), 5 deletions(-)

Here is the summary with links:
- [next] selftests/net: Fix various spelling mistakes in TCP-AO tests
https://git.kernel.org/netdev/net-next/c/67f440c05dd2

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html