2017-03-10 10:38:31

by Christophe Leroy

Subject: [PATCH] powerpc/8xx: fix mpc8xx_get_irq() return on no irq

IRQ 0 is a valid HW interrupt. So get_irq() shall return 0 when
there is no irq, instead of returning irq_linear_revmap(... ,0)

Fixes: f2a0bd3753dad ("[POWERPC] 8xx: powerpc port of core CPM PIC")
Signed-off-by: Christophe Leroy <[email protected]>
---
arch/powerpc/sysdev/mpc8xx_pic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/sysdev/mpc8xx_pic.c b/arch/powerpc/sysdev/mpc8xx_pic.c
index 3e828b20c21e..2842f9d63d21 100644
--- a/arch/powerpc/sysdev/mpc8xx_pic.c
+++ b/arch/powerpc/sysdev/mpc8xx_pic.c
@@ -79,7 +79,7 @@ unsigned int mpc8xx_get_irq(void)
irq = in_be32(&siu_reg->sc_sivec) >> 26;

if (irq == PIC_VEC_SPURRIOUS)
- irq = 0;
+ return 0;

return irq_linear_revmap(mpc8xx_pic_host, irq);

--
2.12.0

2017-06-05 10:22:58

by Michael Ellerman

Subject: Re: powerpc/8xx: fix mpc8xx_get_irq() return on no irq

On Fri, 2017-03-10 at 10:37:01 UTC, Christophe Leroy wrote:
> IRQ 0 is a valid HW interrupt. So get_irq() shall return 0 when
> there is no irq, instead of returning irq_linear_revmap(... ,0)
>
> Fixes: f2a0bd3753dad ("[POWERPC] 8xx: powerpc port of core CPM PIC")
> Signed-off-by: Christophe Leroy <[email protected]>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/3c29b6038828c1f4c9ecbfec14d4fc

cheers