Hi all,
After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
drivers/scsi/ibmvscsi/ibmvscsi.c: In function 'ibmvscsi_work':
drivers/scsi/ibmvscsi/ibmvscsi.c:2151:5: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized]
if (rc) {
^
drivers/scsi/ibmvscsi/ibmvscsi.c:2121:6: note: 'rc' was declared here
int rc;
^~
Introduced by commit
035a3c4046b5 ("scsi: ibmvscsi: redo driver work thread to use enum action states")
--
Cheers,
Stephen Rothwell
On 05/30/2019 08:36 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the scsi tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> drivers/scsi/ibmvscsi/ibmvscsi.c: In function 'ibmvscsi_work':
> drivers/scsi/ibmvscsi/ibmvscsi.c:2151:5: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized]
> if (rc) {
> ^
> drivers/scsi/ibmvscsi/ibmvscsi.c:2121:6: note: 'rc' was declared here
> int rc;
> ^~
>
> Introduced by commit
>
> 035a3c4046b5 ("scsi: ibmvscsi: redo driver work thread to use enum action states")
>
Oof, looks like I didn't compile with pedantic enough options, or just didn't
notice the warning. Declaration should be "int rc = 0;". I can send a follow on
patch.
-Tyrel
On 05/30/2019 08:36 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the scsi tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> drivers/scsi/ibmvscsi/ibmvscsi.c: In function 'ibmvscsi_work':
> drivers/scsi/ibmvscsi/ibmvscsi.c:2151:5: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized]
> if (rc) {
> ^
> drivers/scsi/ibmvscsi/ibmvscsi.c:2121:6: note: 'rc' was declared here
> int rc;
> ^~
>
> Introduced by commit
>
> 035a3c4046b5 ("scsi: ibmvscsi: redo driver work thread to use enum action states")
>
Looks like somebody else noticed the warning and a proposed fix was already sent
out.
-Tyrel