2004-03-18 09:46:52

by Eric Valette

[permalink] [raw]
Subject: 2.6.5-rc1-mm2 : Badness in elv_requeue_request at drivers/block/elevator.c:157

Linux version 2.6.5-rc1-mm2 (root@tri-yann) (gcc version 3.3.3 (Debian 20040314)) #2 Thu Mar 18 09:48:18 CET 2004
BIOS-provided physical RAM map:
BIOS-e820: 0000000000000000 - 000000000009ec00 (usable)
BIOS-e820: 000000000009ec00 - 00000000000a0000 (reserved)
BIOS-e820: 00000000000f0000 - 0000000000100000 (reserved)
BIOS-e820: 0000000000100000 - 000000001ffec000 (usable)
BIOS-e820: 000000001ffec000 - 000000001ffef000 (ACPI data)
BIOS-e820: 000000001ffef000 - 000000001ffff000 (reserved)
BIOS-e820: 000000001ffff000 - 0000000020000000 (ACPI NVS)
BIOS-e820: 00000000ffff0000 - 0000000100000000 (reserved)
511MB LOWMEM available.
zapping low mappings.
On node 0 totalpages: 131052
DMA zone: 4096 pages, LIFO batch:1
Normal zone: 126956 pages, LIFO batch:16
HighMem zone: 0 pages, LIFO batch:1
DMI 2.3 present.
ACPI: RSDP (v000 ASUS ) @ 0x000f6a90
ACPI: RSDT (v001 ASUS A7V 0x30303031 MSFT 0x31313031) @ 0x1ffec000
ACPI: FADT (v001 ASUS A7V 0x30303031 MSFT 0x31313031) @ 0x1ffec080
ACPI: BOOT (v001 ASUS A7V 0x30303031 MSFT 0x31313031) @ 0x1ffec040
ACPI: DSDT (v001 ASUS A7V 0x00001000 MSFT 0x0100000b) @ 0x00000000
Built 1 zonelists
Local APIC disabled by BIOS -- reenabling.
Found and enabled local APIC!
Initializing CPU#0
Kernel command line: BOOT_IMAGE=Linux root=2101 acpi=force
CPU 0 irqstacks, hard=c05f7000 soft=c05f6000
PID hash table entries: 2048 (order 11: 16384 bytes)
Detected 1009.004 MHz processor.
Using tsc for high-res timesource
Console: colour dummy device 80x25
Memory: 513896k/524208k available (3461k kernel code, 9560k reserved, 1135k data, 452k init, 0k highmem)
Calibrating delay loop... 1986.56 BogoMIPS
Dentry cache hash table entries: 65536 (order: 6, 262144 bytes)
Inode-cache hash table entries: 32768 (order: 5, 131072 bytes)
Mount-cache hash table entries: 512 (order: 0, 4096 bytes)
CPU: After generic identify, caps: 0183fbff c1c7fbff 00000000 00000000
CPU: After vendor identify, caps: 0183fbff c1c7fbff 00000000 00000000
CPU: L1 I Cache: 64K (64 bytes/line), D cache 64K (64 bytes/line)
CPU: L2 Cache: 256K (64 bytes/line)
CPU: After all inits, caps: 0183fbff c1c7fbff 00000000 00000020
Intel machine check architecture supported.
Intel machine check reporting enabled on CPU#0.
CPU: AMD Athlon(tm) Processor stepping 02
Enabling fast FPU save and restore... done.
Checking 'hlt' instruction... OK.
POSIX conformance testing by UNIFIX
enabled ExtINT on CPU#0
ESR value before enabling vector: 00000000
ESR value after enabling vector: 00000000
Using local APIC timer interrupts.
calibrating APIC timer ...
..... CPU clock speed is 1008.0822 MHz.
..... host bus clock speed is 201.0764 MHz.
NET: Registered protocol family 16
spurious 8259A interrupt: IRQ7.
PCI: PCI BIOS revision 2.10 entry at 0xf1180, last bus=1
PCI: Using configuration type 1
mtrr: v2.0 (20020519)
ACPI: Subsystem revision 20040311
ACPI: IRQ9 SCI: Level Trigger.
ACPI: Interpreter enabled
ACPI: Using PIC for interrupt routing
ACPI: PCI Interrupt Link [LNKA] (IRQs 3 4 5 6 7 9 10 *11 12 14 15)
ACPI: PCI Interrupt Link [LNKB] (IRQs 3 4 5 6 7 9 *10 11 12 14 15)
ACPI: PCI Interrupt Link [LNKC] (IRQs 3 4 5 6 7 9 10 11 12 14 15)
ACPI: PCI Interrupt Link [LNKD] (IRQs 3 4 5 6 7 *9 10 11 12 14 15)
ACPI: PCI Root Bridge [PCI0] (00:00)
PCI: Probing PCI hardware (bus 00)
ACPI: PCI Interrupt Routing Table [\_SB_.PCI0._PRT]
SCSI subsystem initialized
drivers/usb/core/usb.c: registered new driver usbfs
drivers/usb/core/usb.c: registered new driver hub
ACPI: PCI Interrupt Link [LNKD] enabled at IRQ 9
ACPI: PCI Interrupt Link [LNKC] enabled at IRQ 11
ACPI: PCI Interrupt Link [LNKB] enabled at IRQ 10
ACPI: PCI Interrupt Link [LNKA] enabled at IRQ 11
PCI: Using ACPI for IRQ routing
PCI: if you experience problems, try using option 'pci=noacpi' or even 'acpi=off'
rivafb: nVidia device/chipset 10DE0150
rivafb: RIVA MTRR set to ON
rivafb: PCI nVidia NV10 framebuffer ver 0.9.5b (nVidiaGeForce2-G, 32MB @ 0xD8000000)
Simple Boot Flag at 0x3a set to 0x1
ikconfig 0.7 with /proc/config*
devfs: 2004-01-31 Richard Gooch ([email protected])
devfs: boot_options: 0x1
Installing knfsd (copyright (C) 1996 [email protected]).
NTFS driver 2.1.6 [Flags: R/O].
udf: registering filesystem
PCI: Disabling Via external APIC routing
ACPI: Power Button (FF) [PWRF]
ACPI: Processor [CPU0] (supports C1 C2, 16 throttling states)
Console: switching to colour frame buffer device 80x30
lp: driver loaded but no devices found
Real Time Clock Driver v1.12
Linux agpgart interface v0.100 (c) Dave Jones
agpgart: Detected VIA Twister-K/KT133x/KM133 chipset
agpgart: Maximum main memory to use for agp memory: 439M
agpgart: AGP aperture is 32M @ 0xe6000000
Serial: 8250/16550 driver $Revision: 1.90 $ 8 ports, IRQ sharing disabled
ttyS0 at I/O 0x3f8 (irq = 4) is a 16550A
ttyS1 at I/O 0x2f8 (irq = 3) is a 16550A
parport0: PC-style at 0x378 (0x778) [PCSPP,TRISTATE]
parport0: cpp_mux: aa55f00f52ad51(80)
parport0: cpp_daisy: aa5500ff(80)
parport0: assign_addrs: aa5500ff(80)
parport0: cpp_mux: aa55f00f52ad51(80)
parport0: cpp_daisy: aa5500ff(80)
parport0: assign_addrs: aa5500ff(80)
lp0: using parport0 (polling).
parport_pc: Via 686A parallel port: io=0x378
Using anticipatory io scheduler
Floppy drive(s): fd0 is 1.44M
FDC 0 is a post-1991 82077
RAMDISK driver initialized: 16 RAM disks of 4096K size 1024 blocksize
loop: loaded (max 8 devices)
PPP generic driver version 2.4.2
PPP Deflate Compression module registered
PPP BSD Compression module registered
NET: Registered protocol family 24
Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2
ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx
VP_IDE: IDE controller at PCI slot 0000:00:04.1
VP_IDE: chipset revision 16
VP_IDE: not 100% native mode: will probe irqs later
VP_IDE: VIA vt82c686a (rev 22) IDE UDMA66 controller on pci0000:00:04.1
ide0: BM-DMA at 0xd800-0xd807, BIOS settings: hda:DMA, hdb:DMA
ide1: BM-DMA at 0xd808-0xd80f, BIOS settings: hdc:pio, hdd:pio
hda: Maxtor 91360U4, ATA DISK drive
hdb: LITE-ON LTR-48126S, ATAPI CD/DVD-ROM drive
ide0 at 0x1f0-0x1f7,0x3f6 on irq 14
PDC20265: IDE controller at PCI slot 0000:00:11.0
PDC20265: chipset revision 2
PDC20265: 100% native mode on irq 10
PDC20265: (U)DMA Burst Bit ENABLED Primary PCI Mode Secondary PCI Mode.
ide2: BM-DMA at 0x7800-0x7807, BIOS settings: hde:DMA, hdf:pio
ide3: BM-DMA at 0x7808-0x780f, BIOS settings: hdg:pio, hdh:DMA
hde: ST380011A, ATA DISK drive
ide2 at 0x9000-0x9007,0x8802 on irq 10
hda: max request size: 128KiB
hda: 26588016 sectors (13613 MB) w/2048KiB Cache, CHS=26377/16/63, UDMA(66)
/dev/ide/host0/bus0/target0/lun0: p1 p2 < p5 p6 p7 >
hde: max request size: 1024KiB
hde: 156301488 sectors (80026 MB) w/2048KiB Cache, CHS=16383/255/63, UDMA(100)
/dev/ide/host2/bus0/target0/lun0: p1 p2 p3 p4 < p5 p6 p7 p8 p9 >
scsi0 : Adaptec AIC7XXX EISA/VLB/PCI SCSI HBA DRIVER, Rev 6.2.36
<Adaptec 2940 Ultra SCSI adapter>
aic7880: Ultra Wide Channel A, SCSI Id=7, 16/253 SCBs

Badness in elv_requeue_request at drivers/block/elevator.c:157
Call Trace:
[<c02b268d>] elv_requeue_request+0x8d/0xa0
[<c02ede33>] scsi_request_fn+0x283/0x3b0
[<c02b26d0>] __elv_add_request+0x30/0x50
[<c02b4d09>] blk_insert_request+0xd9/0x100
[<c02eca3a>] scsi_insert_special_req+0x3a/0x40
[<c02ecc89>] scsi_wait_req+0x69/0xb0
[<c02ecb90>] scsi_wait_done+0x0/0x90
[<c02eeaeb>] scsi_probe_lun+0x7b/0x200
[<c02ef0fc>] scsi_probe_and_add_lun+0xac/0x1d0
[<c02ef864>] scsi_scan_target+0xa4/0x120
[<c02ef95a>] scsi_scan_channel+0x7a/0x90
[<c02efa31>] scsi_scan_host_selected+0xc1/0xd0
[<c02efa6f>] scsi_scan_host+0x2f/0x40
[<c030854c>] ahc_linux_register_host+0x27c/0x2f0
[<c02afbdd>] bus_add_driver+0x8d/0xa0
[<c02b001f>] driver_register+0x2f/0x40
[<c02b001f>] driver_register+0x2f/0x40
[<c0307383>] ahc_linux_detect+0x33/0x60
[<c059c03f>] ahc_linux_init+0xf/0x30
[<c057f80c>] do_initcalls+0x2c/0xc0
[<c012e51f>] init_workqueues+0xf/0x30
[<c01030a0>] init+0x0/0x160
[<c01030d5>] init+0x35/0x160
[<c010728c>] kernel_thread_helper+0x0/0x14
[<c0107291>] kernel_thread_helper+0x5/0x14

(scsi0:A:3): 5.000MB/s transfers (5.000MHz, offset 15)
Vendor: HP Model: C1533A Rev: A907
Type: Sequential-Access ANSI SCSI revision: 02
scsi1 : Adaptec AIC7XXX EISA/VLB/PCI SCSI HBA DRIVER, Rev 6.2.36
<Adaptec 29160 Ultra160 SCSI adapter>
aic7892: Ultra160 Wide Channel A, SCSI Id=7, 32/253 SCBs

Badness in elv_requeue_request at drivers/block/elevator.c:157
Call Trace:
[<c02b268d>] elv_requeue_request+0x8d/0xa0
[<c02ede33>] scsi_request_fn+0x283/0x3b0
[<c02b26d0>] __elv_add_request+0x30/0x50
[<c02b4d09>] blk_insert_request+0xd9/0x100
[<c02eca3a>] scsi_insert_special_req+0x3a/0x40
[<c02ecc89>] scsi_wait_req+0x69/0xb0
[<c02ecb90>] scsi_wait_done+0x0/0x90
[<c0256887>] snprintf+0x27/0x30
[<c02eeaeb>] scsi_probe_lun+0x7b/0x200
[<c02e882e>] scsi_allocate_request+0x2e/0x70
[<c02ef0fc>] scsi_probe_and_add_lun+0xac/0x1d0
[<c02ef864>] scsi_scan_target+0xa4/0x120
[<c02ef95a>] scsi_scan_channel+0x7a/0x90
[<c02efa31>] scsi_scan_host_selected+0xc1/0xd0
[<c02efa6f>] scsi_scan_host+0x2f/0x40
[<c030854c>] ahc_linux_register_host+0x27c/0x2f0
[<c02afbdd>] bus_add_driver+0x8d/0xa0
[<c02b001f>] driver_register+0x2f/0x40
[<c02b001f>] driver_register+0x2f/0x40
[<c0307383>] ahc_linux_detect+0x33/0x60
[<c059c03f>] ahc_linux_init+0xf/0x30
[<c057f80c>] do_initcalls+0x2c/0xc0
[<c012e51f>] init_workqueues+0xf/0x30
[<c01030a0>] init+0x0/0x160
[<c01030d5>] init+0x35/0x160
[<c010728c>] kernel_thread_helper+0x0/0x14
[<c0107291>] kernel_thread_helper+0x5/0x14

(scsi1:A:6): 160.000MB/s transfers (80.000MHz DT, offset 127, 16bit)
Vendor: QUANTUM Model: ATLAS10K3_36_WLS Rev: 020W
Type: Direct-Access ANSI SCSI revision: 03
scsi1:A:6:0: Tagged Queuing enabled. Depth 64
ide-scsi is deprecated for cd burning! Use ide-cd and give dev=/dev/hdX as device
scsi2 : SCSI host adapter emulation for IDE ATAPI devices
Vendor: LITE-ON Model: LTR-48126S Rev: 2S07
Type: CD-ROM ANSI SCSI revision: 02
st: Version 20040318, fixed bufsize 32768, s/g segs 256
Attached scsi tape st0 at scsi0, channel 0, id 3, lun 0
st0: try direct i/o: yes (alignment 512 B), max page reachable by HBA 1048575
SCSI device sda: 71833096 512-byte hdwr sectors (36779 MB)
SCSI device sda: drive cache: write back
/dev/scsi/host1/bus0/target6/lun0: p1 p2 < p5 p6 p7 p8 > p3
Attached scsi disk sda at scsi1, channel 0, id 6, lun 0
Attached scsi generic sg0 at scsi0, channel 0, id 3, lun 0, type 1
Attached scsi generic sg1 at scsi1, channel 0, id 6, lun 0, type 0
Attached scsi generic sg2 at scsi2, channel 0, id 0, lun 0, type 5
ohci1394: $Rev: 1172 $ Ben Collins <[email protected]>
PCI: Enabling device 0000:00:0c.0 (0014 -> 0016)
ohci1394: fw-host0: OHCI-1394 1.0 (PCI): IRQ=[11] MMIO=[d4800000-d48007ff] Max Packet=[2048]
video1394: Installed video1394 module
ieee1394: raw1394: /dev/raw1394 device initialized
sbp2: $Rev: 1170 $ Ben Collins <[email protected]>
USB Universal Host Controller Interface driver v2.2
uhci_hcd 0000:00:04.2: VIA Technologies, Inc. USB
uhci_hcd 0000:00:04.2: irq 9, io base 0000d400
uhci_hcd 0000:00:04.2: new USB bus registered, assigned bus number 1
hub 1-0:1.0: USB hub found
hub 1-0:1.0: 2 ports detected
uhci_hcd 0000:00:04.3: VIA Technologies, Inc. USB (#2)
uhci_hcd 0000:00:04.3: irq 9, io base 0000d000
uhci_hcd 0000:00:04.3: new USB bus registered, assigned bus number 2
hub 2-0:1.0: USB hub found
hub 2-0:1.0: 2 ports detected
Initializing USB Mass Storage driver...
drivers/usb/core/usb.c: registered new driver usb-storage
USB Mass Storage support registered.
drivers/usb/core/usb.c: registered new driver usbkbd
drivers/usb/input/usbkbd.c: :USB HID Boot Protocol keyboard driver
drivers/usb/core/usb.c: registered new driver usbmouse
drivers/usb/input/usbmouse.c: v1.6:USB HID Boot Protocol mouse driver
drivers/usb/net/rtl8150.c: rtl8150 based usb-ethernet driver v0.5.7 (2002/12/31)
drivers/usb/core/usb.c: registered new driver rtl8150
mice: PS/2 mouse device common for all mice
serio: i8042 AUX port at 0x60,0x64 irq 12
input: PS2++ Logitech Mouse on isa0060/serio1
serio: i8042 KBD port at 0x60,0x64 irq 1
input: AT Translated Set 2 keyboard on isa0060/serio0
I2O Core - (C) Copyright 1999 Red Hat Software
I2O: Event thread created as pid 19
i2o: Checking for PCI I2O controllers...
I2O configuration manager v 0.04.
(C) Copyright 1999 Red Hat Software
I2O Block Storage OSM v0.9
(c) Copyright 1999-2001 Red Hat Software.
i2o_block: Checking for Boot device...
i2o_block: Checking for I2O Block devices...
i2c /dev entries driver
Advanced Linux Sound Architecture Driver Version 1.0.3 (Mon Mar 01 10:12:14 2004 UTC).
PCI: Enabling device 0000:00:0a.0 (0004 -> 0005)
ALSA device list:
#0: Sound Blaster Live! (rev.7) at 0xa400, irq 11
NET: Registered protocol family 2
IP: routing cache hash table of 4096 buckets, 32Kbytes
TCP: Hash tables configured (established 32768 bind 65536)
ip_conntrack version 2.1 (4095 buckets, 32760 max) - 296 bytes per conntrack
usb 2-2: new full speed USB device using address 2
ip_tables: (C) 2000-2002 Netfilter core team
hub 2-2:1.0: USB hub found
hub 2-2:1.0: 4 ports detected
arp_tables: (C) 2002 David S. Miller
NET: Registered protocol family 1
NET: Registered protocol family 17
NET: Registered protocol family 8
NET: Registered protocol family 20
lec.c: Mar 18 2004 09:41:53 initialized
ACPI: (supports S0 S1 S4 S5)
BIOS EDD facility v0.13 2004-Mar-09, 3 devices found
Please report your BIOS at http://linux.dell.com/edd/results.html
VFS: Mounted root (ext2 filesystem) readonly.
Mounted devfs on /dev
Freeing unused kernel memory: 452k freed
usb 1-2: new full speed USB device using address 2
hub 1-2:1.0: USB hub found
hub 1-2:1.0: 4 ports detected
ieee1394: Host added: ID:BUS[0-00:1023] GUID[003095231000ad1f]
usb 1-2.4: new full speed USB device using address 3
drivers/usb/net/rtl8150.c: eth%d: rtl8150 is detected
Adding 1228936k swap on /dev/sda1. Priority:-1 extents:1
atkbd.c: Unknown key released (translated set 2, code 0x7a on isa0060/serio0).
atkbd.c: This is an XFree86 bug. It shouldn't access hardware directly.
atkbd.c: Unknown key released (translated set 2, code 0x7a on isa0060/serio0).
atkbd.c: This is an XFree86 bug. It shouldn't access hardware directly.


Attachments:
.config (27.97 kB)
dmesg (14.13 kB)
Download all attachments

2004-03-18 10:02:31

by Jens Axboe

[permalink] [raw]
Subject: Re: 2.6.5-rc1-mm2 : Badness in elv_requeue_request at drivers/block/elevator.c:157

On Thu, Mar 18 2004, Eric Valette wrote:
> I have this message two times as I have two adaptec controllers...
>
> Attached my .config and the dmesg output
>
> ksymoops 2.4.9 on i686 2.6.5-rc1-mm2. Options used
> -V (default)
> -k /proc/ksyms (default)
> -l /proc/modules (default)
> -o /lib/modules/2.6.5-rc1-mm2/ (default)
> -m /System.map (specified)
>
> Error (regular_file): read_ksyms stat /proc/ksyms failed
> No modules in ksyms, skipping objects
> No ksyms, skipping lsmod
> CPU 0 irqstacks, hard=c05f7000 soft=c05f6000
> Call Trace:
> [<c02b268d>] elv_requeue_request+0x8d/0xa0

Ah damn, requeue through blk_insert_request... Let me think about this
a bit, I'll post a fix for you.

--
Jens Axboe

2004-03-18 10:06:26

by Jens Axboe

[permalink] [raw]
Subject: Re: 2.6.5-rc1-mm2 : Badness in elv_requeue_request at drivers/block/elevator.c:157

On Thu, Mar 18 2004, Jens Axboe wrote:
> On Thu, Mar 18 2004, Eric Valette wrote:
> > I have this message two times as I have two adaptec controllers...
> >
> > Attached my .config and the dmesg output
> >
> > ksymoops 2.4.9 on i686 2.6.5-rc1-mm2. Options used
> > -V (default)
> > -k /proc/ksyms (default)
> > -l /proc/modules (default)
> > -o /lib/modules/2.6.5-rc1-mm2/ (default)
> > -m /System.map (specified)
> >
> > Error (regular_file): read_ksyms stat /proc/ksyms failed
> > No modules in ksyms, skipping objects
> > No ksyms, skipping lsmod
> > CPU 0 irqstacks, hard=c05f7000 soft=c05f6000
> > Call Trace:
> > [<c02b268d>] elv_requeue_request+0x8d/0xa0
>
> Ah damn, requeue through blk_insert_request... Let me think about this
> a bit, I'll post a fix for you.

Does this work for you?

--- drivers/block/elevator.c~ 2004-03-18 10:56:34.494431670 +0100
+++ drivers/block/elevator.c 2004-03-18 11:05:00.115063157 +0100
@@ -153,7 +153,7 @@
* it already went through dequeue, we need to decrement the
* in_flight count again
*/
- if (blk_rq_started(rq)) {
+ if (blk_account_rq(rq)) {
WARN_ON(q->in_flight == 0);
q->in_flight--;
}
@@ -244,7 +244,7 @@
* driver has seen (REQ_STARTED set), to avoid false accounting
* for request-request merges
*/
- if (blk_rq_started(rq)) {
+ if (blk_account_rq(rq)) {
q->in_flight++;
WARN_ON(q->in_flight > 2 * q->nr_requests);
}
@@ -341,7 +341,7 @@
/*
* request is released from the driver, io must be done
*/
- if (blk_rq_started(rq)) {
+ if (blk_account_rq(rq)) {
WARN_ON(q->in_flight == 0);
q->in_flight--;
}
--- include/linux/blkdev.h~ 2004-03-18 11:03:59.431584757 +0100
+++ include/linux/blkdev.h 2004-03-18 11:05:16.980250506 +0100
@@ -381,6 +381,8 @@
#define blk_noretry_request(rq) ((rq)->flags & REQ_FAILFAST)
#define blk_rq_started(rq) ((rq)->flags & REQ_STARTED)

+#define blk_account_rq(rq) (blk_rq_started(rq) && blk_fs_request(rq))
+
#define blk_pm_suspend_request(rq) ((rq)->flags & REQ_PM_SUSPEND)
#define blk_pm_resume_request(rq) ((rq)->flags & REQ_PM_RESUME)
#define blk_pm_request(rq) \

--
Jens Axboe

2004-03-18 10:35:22

by Eric Valette

[permalink] [raw]
Subject: Re: 2.6.5-rc1-mm2 : Badness in elv_requeue_request at drivers/block/elevator.c:157

Jens Axboe wrote:

>>Ah damn, requeue through blk_insert_request... Let me think about this
>>a bit, I'll post a fix for you.
>
>
> Does this work for you?

At least it does avoid the message at boot time :-) Thanks for your
quick reply. Who still thinks OSS is not supported?

Thanks a lot and have a nice day,

--
__
/ ` Eric Valette
/-- __ o _. 6 rue Paul Le Flem
(___, / (_(_(__ 35740 Pace

Tel: +33 (0)2 99 85 26 76 Fax: +33 (0)2 99 85 26 76
E-mail: [email protected]



2004-03-18 11:07:17

by Jens Axboe

[permalink] [raw]
Subject: Re: 2.6.5-rc1-mm2 : Badness in elv_requeue_request at drivers/block/elevator.c:157

On Thu, Mar 18 2004, Eric Valette wrote:
> Jens Axboe wrote:
>
> >>Ah damn, requeue through blk_insert_request... Let me think about this
> >>a bit, I'll post a fix for you.
> >
> >
> >Does this work for you?
>
> At least it does avoid the message at boot time :-) Thanks for your
> quick reply. Who still thinks OSS is not supported?

Great, thanks for testing.

--
Jens Axboe

2004-03-19 00:22:08

by J.A. Magallon

[permalink] [raw]
Subject: Re: 2.6.5-rc1-mm2 : Badness in elv_requeue_request at drivers/block/elevator.c:157


On 03.18, Jens Axboe wrote:
> On Thu, Mar 18 2004, Jens Axboe wrote:
> > On Thu, Mar 18 2004, Eric Valette wrote:
> > > I have this message two times as I have two adaptec controllers...
> > >

I have a similar but different place oops. My box was dog slow with -mm2,
and syslog was flooded with:

Mar 18 20:00:00 werewolf kernel: Badness in elv_remove_request at drivers/block/elevator.c:249
Mar 18 20:00:00 werewolf kernel: Call Trace:
Mar 18 20:00:00 werewolf kernel: [elv_remove_request+156/160] elv_remove_request+0x9c/0xa0
Mar 18 20:00:00 werewolf kernel: [<c020001c>] elv_remove_request+0x9c/0xa0
Mar 18 20:00:00 werewolf kernel: [scsi_request_fn+826/1088] scsi_request_fn+0x33a/0x440
Mar 18 20:00:00 werewolf kernel: [<c022af8a>] scsi_request_fn+0x33a/0x440
Mar 18 20:00:00 werewolf kernel: [generic_unplug_device+94/112] generic_unplug_device+0x5e/0x70
Mar 18 20:00:00 werewolf kernel: [<c0201a2e>] generic_unplug_device+0x5e/0x70
Mar 18 20:00:00 werewolf kernel: [blk_backing_dev_unplug+18/32] blk_backing_dev_unplug+0x12/0x20
Mar 18 20:00:00 werewolf kernel: [<c0201a62>] blk_backing_dev_unplug+0x12/0x20
Mar 18 20:00:00 werewolf kernel: [block_sync_page+34/48] block_sync_page+0x22/0x30
Mar 18 20:00:00 werewolf kernel: [<c015fe22>] block_sync_page+0x22/0x30
Mar 18 20:00:00 werewolf kernel: [wait_on_page_bit+195/208] wait_on_page_bit+0xc3/0xd0
Mar 18 20:00:00 werewolf kernel: [<c013be13>] wait_on_page_bit+0xc3/0xd0
Mar 18 20:00:00 werewolf kernel: [autoremove_wake_function+0/64] autoremove_wake_function+0x0/0x40
Mar 18 20:00:00 werewolf kernel: [<c011ede0>] autoremove_wake_function+0x0/0x40
Mar 18 20:00:00 werewolf kernel: [autoremove_wake_function+0/64] autoremove_wake_function+0x0/0x40
Mar 18 20:00:00 werewolf kernel: [<c011ede0>] autoremove_wake_function+0x0/0x40
Mar 18 20:00:00 werewolf kernel: [mpage_bio_submit+25/32] mpage_bio_submit+0x19/0x20
Mar 18 20:00:00 werewolf kernel: [<c017da69>] mpage_bio_submit+0x19/0x20
Mar 18 20:00:00 werewolf kernel: [do_generic_mapping_read+840/976] do_generic_mapping_read+0x348/0x3d0
Mar 18 20:00:00 werewolf kernel: [<c013c7a8>] do_generic_mapping_read+0x348/0x3d0
Mar 18 20:00:00 werewolf kernel: [file_read_actor+0/240] file_read_actor+0x0/0xf0
Mar 18 20:00:00 werewolf kernel: [<c013c830>] file_read_actor+0x0/0xf0
Mar 18 20:00:00 werewolf kernel: [__generic_file_aio_read+450/560] __generic_file_aio_read+0x1c2/0x230
Mar 18 20:00:00 werewolf kernel: [<c013cae2>] __generic_file_aio_read+0x1c2/0x230
Mar 18 20:00:00 werewolf kernel: [file_read_actor+0/240] file_read_actor+0x0/0xf0
Mar 18 20:00:00 werewolf kernel: [<c013c830>] file_read_actor+0x0/0xf0
Mar 18 20:00:00 werewolf kernel: [recalc_task_prio+219/464] recalc_task_prio+0xdb/0x1d0
Mar 18 20:00:00 werewolf kernel: [<c0119a4b>] recalc_task_prio+0xdb/0x1d0
Mar 18 20:00:00 werewolf kernel: [generic_file_aio_read+71/112] generic_file_aio_read+0x47/0x70
Mar 18 20:00:00 werewolf kernel: [<c013cb97>] generic_file_aio_read+0x47/0x70
Mar 18 20:00:00 werewolf kernel: [do_sync_read+133/224] do_sync_read+0x85/0xe0
Mar 18 20:00:00 werewolf kernel: [<c015ac65>] do_sync_read+0x85/0xe0
Mar 18 20:00:00 werewolf kernel: [schedule+535/1984] schedule+0x217/0x7c0
Mar 18 20:00:00 werewolf kernel: [<c011c2c7>] schedule+0x217/0x7c0
Mar 18 20:00:00 werewolf kernel: [inode_update_time+179/192] inode_update_time+0xb3/0xc0
Mar 18 20:00:00 werewolf kernel: [<c0176893>] inode_update_time+0xb3/0xc0
Mar 18 20:00:00 werewolf kernel: [pipe_writev+603/864] pipe_writev+0x25b/0x360
Mar 18 20:00:00 werewolf kernel: [<c016803b>] pipe_writev+0x25b/0x360
Mar 18 20:00:00 werewolf kernel: [vfs_read+254/304] vfs_read+0xfe/0x130
Mar 18 20:00:00 werewolf kernel: [<c015adbe>] vfs_read+0xfe/0x130
Mar 18 20:00:00 werewolf kernel: [vfs_write+165/304] vfs_write+0xa5/0x130
Mar 18 20:00:00 werewolf kernel: [<c015af75>] vfs_write+0xa5/0x130
Mar 18 20:00:00 werewolf kernel: [sys_pread64+76/112] sys_pread64+0x4c/0x70
Mar 18 20:00:00 werewolf kernel: [<c015b10c>] sys_pread64+0x4c/0x70
Mar 18 20:00:00 werewolf kernel: [sysenter_past_esp+67/101] sysenter_past_esp+0x43/0x65
Mar 18 20:00:00 werewolf kernel: [<c02ba022>] sysenter_past_esp+0x43/0x65

Just to check it is caused by the same bug or to give some other clue...

TIA

--
J.A. Magallon <jamagallon()able!es> \ Software is like sex:
werewolf!able!es \ It's better when it's free
Mandrake Linux release 10.0 (Community) for i586
Linux 2.6.5-rc1-jam1 (gcc 3.4.0 (Mandrake Linux 10.0 3.4.0-0.4mdk))

2004-03-19 07:37:24

by Jens Axboe

[permalink] [raw]
Subject: Re: 2.6.5-rc1-mm2 : Badness in elv_requeue_request at drivers/block/elevator.c:157

On Fri, Mar 19 2004, J.A. Magallon wrote:
>
> On 03.18, Jens Axboe wrote:
> > On Thu, Mar 18 2004, Jens Axboe wrote:
> > > On Thu, Mar 18 2004, Eric Valette wrote:
> > > > I have this message two times as I have two adaptec controllers...
> > > >
>
> I have a similar but different place oops. My box was dog slow with -mm2,
> and syslog was flooded with:
>
> Mar 18 20:00:00 werewolf kernel: Badness in elv_remove_request at drivers/block/elevator.c:249
> Mar 18 20:00:00 werewolf kernel: Call Trace:
> Mar 18 20:00:00 werewolf kernel: [elv_remove_request+156/160] elv_remove_request+0x9c/0xa0

Tell me a bit about your io setup please, ide/scsi, raid, what?

--
Jens Axboe

2004-03-19 23:26:02

by J.A. Magallon

[permalink] [raw]
Subject: Re: 2.6.5-rc1-mm2 : Badness in elv_requeue_request at drivers/block/elevator.c:157


On 03.19, Jens Axboe wrote:
> On Fri, Mar 19 2004, J.A. Magallon wrote:
> >
> > On 03.18, Jens Axboe wrote:
> > > On Thu, Mar 18 2004, Jens Axboe wrote:
> > > > On Thu, Mar 18 2004, Eric Valette wrote:
> > > > > I have this message two times as I have two adaptec controllers...
> > > > >
> >
> > I have a similar but different place oops. My box was dog slow with -mm2,
> > and syslog was flooded with:
> >
> > Mar 18 20:00:00 werewolf kernel: Badness in elv_remove_request at drivers/block/elevator.c:249
> > Mar 18 20:00:00 werewolf kernel: Call Trace:
> > Mar 18 20:00:00 werewolf kernel: [elv_remove_request+156/160] elv_remove_request+0x9c/0xa0
>
> Tell me a bit about your io setup please, ide/scsi, raid, what?
>

Simple scsi (no raid, no md), on an 2940.
Anyways, the patch you posted made everything work fine again.
Thanks.

--
J.A. Magallon <jamagallon()able!es> \ Software is like sex:
werewolf!able!es \ It's better when it's free
Mandrake Linux release 10.0 (Community) for i586
Linux 2.6.5-rc1-jam2 (gcc 3.4.0 (Mandrake Linux 10.0 3.4.0-0.4mdk))

2004-03-20 10:05:32

by Jens Axboe

[permalink] [raw]
Subject: Re: 2.6.5-rc1-mm2 : Badness in elv_requeue_request at drivers/block/elevator.c:157

On Sat, Mar 20 2004, J.A. Magallon wrote:
>
> On 03.19, Jens Axboe wrote:
> > On Fri, Mar 19 2004, J.A. Magallon wrote:
> > >
> > > On 03.18, Jens Axboe wrote:
> > > > On Thu, Mar 18 2004, Jens Axboe wrote:
> > > > > On Thu, Mar 18 2004, Eric Valette wrote:
> > > > > > I have this message two times as I have two adaptec controllers...
> > > > > >
> > >
> > > I have a similar but different place oops. My box was dog slow with -mm2,
> > > and syslog was flooded with:
> > >
> > > Mar 18 20:00:00 werewolf kernel: Badness in elv_remove_request at drivers/block/elevator.c:249
> > > Mar 18 20:00:00 werewolf kernel: Call Trace:
> > > Mar 18 20:00:00 werewolf kernel: [elv_remove_request+156/160] elv_remove_request+0x9c/0xa0
> >
> > Tell me a bit about your io setup please, ide/scsi, raid, what?
> >
>
> Simple scsi (no raid, no md), on an 2940.
> Anyways, the patch you posted made everything work fine again.
> Thanks.

Super, thanks for confirming.

--
Jens Axboe