2004-03-18 18:07:57

by Sergey Vlasov

[permalink] [raw]

Subject: vmalloc fix buggy again?

---

Hello!

> # ChangeSet
> # 2004/03/14 13:16:58-03:00 mlord...
> # [PATCH] Yet another vmalloc() fixup
> #
> diff -Nru a/mm/vmalloc.c b/mm/vmalloc.c
> --- a/mm/vmalloc.c Thu Mar 18 09:44:53 2004
> +++ b/mm/vmalloc.c Thu Mar 18 09:44:53 2004
> @@ -184,7 +184,7 @@
> spin_unlock(&init_mm.page_table_lock);
> flush_cache_all();
> if (address > start)
> - vmfree_area_pages((address - start), address - start);
> + vmfree_area_pages(address, address - start);
> return -ENOMEM;
> }
>

Looks like this should be

vmfree_area_pages(start, address - start);

--
Sergey Vlasov

---

Attachments:

(No filename) (588.00 B)
(No filename) (189.00 B)
Download all attachments

2004-03-18 21:15:51

by Mark Lord

[permalink] [raw]

Subject: Re: vmalloc fix buggy again?

---

Yup.

Thanks, Sergey. I'm suffering severe brain-impairment on this one.
Please pass this on to Marcelo.

Cheers
--
Mark Lord
Real-Time Remedies Inc.
[email protected]

Sergey Vlasov wrote:
> Hello!
>
>
>># ChangeSet
>># 2004/03/14 13:16:58-03:00 mlord...
>># [PATCH] Yet another vmalloc() fixup
>>#
>>diff -Nru a/mm/vmalloc.c b/mm/vmalloc.c
>>--- a/mm/vmalloc.c Thu Mar 18 09:44:53 2004
>>+++ b/mm/vmalloc.c Thu Mar 18 09:44:53 2004
>>@@ -184,7 +184,7 @@
>> spin_unlock(&init_mm.page_table_lock);
>> flush_cache_all();
>> if (address > start)
>>- vmfree_area_pages((address - start), address - start);
>>+ vmfree_area_pages(address, address - start);
>> return -ENOMEM;
>> }
>>
>
>
> Looks like this should be
>
> vmfree_area_pages(start, address - start);
>