2004-04-09 21:05:58

by Brian King

[permalink] [raw]
Subject: Re: [PATCH] call_usermodehelper hang

Greg KH wrote:
> On Fri, Apr 09, 2004 at 03:42:56PM -0500, Brian King wrote:
>
>>Would you prefer a fix in call_usermodehelper itself? It could certainly
>>be argued that calling call_usermodehelper with wait=0 should be allowed
>>even when holding locks. Although, fixing it here is less obvious to me
>>how to do because of the arguments to call_usermodehelper. I would imagine
>>it would consist of creating a kernel_thread to preserve the caller's stack.
>
>
> Yes, I think call_usermodehelper should be changed to create a new
> kernel thread for every call. That would solve this problem, and any
> future races that might happen. Care to work on that?

I'll give it a shot.

-Brian


--
Brian King
eServer Storage I/O
IBM Linux Technology Center