2004-04-24 23:50:00

by Brian Gerst

[permalink] [raw]

Subject: [PATCH] Fix warning in prefetch_range

---

diff -urN linux-2.6.5-rc1-bk/include/linux/prefetch.h linux/include/linux/prefetch.h
--- linux-2.6.5-rc1-bk/include/linux/prefetch.h 2004-04-14 23:53:11.000000000 -0400
+++ linux/include/linux/prefetch.h 2004-04-16 11:12:25.840194048 -0400
@@ -59,7 +59,7 @@
{
#ifdef ARCH_HAS_PREFETCH
char *cp;
- char *end = addr + len;
+ char *end = (char *)addr + len;

for (cp = addr; cp < end; cp += PREFETCH_STRIDE)
prefetch(cp);

---

Attachments:

prefetch-1 (429.00 B)

2004-04-26 05:08:55

by Andrew Morton

[permalink] [raw]

Subject: Re: [PATCH] Fix warning in prefetch_range

---

Brian Gerst <[email protected]> wrote:
>
> Fix this warning:
> include/linux/prefetch.h: In function `prefetch_range':
> include/linux/prefetch.h:62: warning: pointer of type `void *' used in
> arithmetic
>

eh? That's a gcc extension which has worked silently since forever.

What compiler version is generating the warning?

2004-04-26 12:29:33

by Brian Gerst

[permalink] [raw]

Subject: Re: [PATCH] Fix warning in prefetch_range

---

Andrew Morton wrote:
> Brian Gerst <[email protected]> wrote:
>
>>Fix this warning:
>>include/linux/prefetch.h: In function `prefetch_range':
>>include/linux/prefetch.h:62: warning: pointer of type `void *' used in
>>arithmetic
>>
>
>
> eh? That's a gcc extension which has worked silently since forever.
>
> What compiler version is generating the warning?
>

gcc (GCC) 3.3.3 20040412 (Red Hat Linux 3.3.3-7)

I saw the warning when compiling the nvidia driver, which uses
-Wpointer-arith. I'll drop that switch instead.

--
Brian Gerst