2004-06-01 04:18:36

by NeilBrown

[permalink] [raw]
Subject: Re: [PATCH] iso9660 inodes beyond 4GB

On Monday May 31, [email protected] wrote:
> This is my third attempt to patch the isofs code. It is a completely
> different patch from the previous two. I do not think there are any
> trade-offs with this patch.
snip
>
> Lastly, the current code uses the default export_operations to handle
> accessing the file system through NFS. The problem with this is that
> the default NFS operations assume that iget() works which is no longer
> the case because of the necessary switch to iget5_locked(). So, I had
> to implement the NFS operations too.
>
> I did not, however, implement the NFS get_parent() method. So, the
> default method which just returns an error is used. This is not a
> reduction in functionality because the current code also uses the
> default method. If someone can explain what I need to do to trigger
> this error, I will gladly try to implement the method.
>

The easiest way to trigger the error is:
export the filesystem and mount it on some client.
On the client, cd into some subdirectory.
On the server, unexport, unmount, remount, reexport
(i.e. simulate a reboot).
On the client "ls -l"

That should cause the server to try to call get_parent to find the
path back up to the root of the filesystem.

A quick glance at the rest of the export related code suggests that it
is all ok.

NeilBrown


2004-06-01 13:43:41

by Paul Serice

[permalink] [raw]
Subject: Re: [PATCH] iso9660 inodes beyond 4GB

> The easiest way to trigger the error is:
> export the filesystem and mount it on some client.
> On the client, cd into some subdirectory.
> On the server, unexport, unmount, remount, reexport
> (i.e. simulate a reboot).
> On the client "ls -l"
>
> That should cause the server to try to call get_parent to find the
> path back up to the root of the filesystem.

Thanks, that definitely triggers an error.


> A quick glance at the rest of the export related code suggests that
> it is all ok.

I'm not sure who I have to thank, but the code in fs/exportfs made it
much easier than expected.


Paul Serice