2004-06-02 22:58:36

by Nathan Lynch

[permalink] [raw]
Subject: [PATCH] ppc64 gives up too quickly on hotplugged cpu

Hi-

On some systems it can take a hotplugged cpu much longer to come up than
it would at boot. If the cpu comes up after we've given up on it, it
tends to die in its first attempt to kmem_cache_alloc (uninitialized
percpu data, I imagine).

In my experimentation I haven't seen a processor take more than one
second to become available; the patch waits five seconds just to be safe.

Patch is against 2.6.7-rc2; please apply.

Signed-off-by: Nathan Lynch <[email protected]>


Attachments:
ppc64_cpu_up_be_more_patient.patch (910.00 B)

2004-06-10 19:52:50

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH] ppc64 gives up too quickly on hotplugged cpu

Hi!

> On some systems it can take a hotplugged cpu much longer to come up
> than it would at boot. If the cpu comes up after we've given up on
> it, it tends to die in its first attempt to kmem_cache_alloc
> (uninitialized percpu data, I imagine).

Should not CPU check if system given up on it, and go to infinite
loop if it did to prevent data corruption?

Ouch and please inline patches.
--
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms