2004-06-16 20:48:10

by Marcelo Tosatti

[permalink] [raw]
Subject: Linux 2.4.27-pre6


Hi,

Here goes -pre6. It contains a significant amount of USB fixes, JFS update,
netfilter/sctp fixes, CDROM driver update, tg3 update, SPARC/Alpha fixes.

And more importantly the FPU x86/x86-64 crash fix.

Read the detailed changelog for more details.

Summary of changes from v2.4.27-pre5 to v2.4.27-pre6
============================================

<andrej.filipcic:ijs.si>:
o USB: pl2303 & input overruns

<chaapala:cisco.com>:
o [CRYPTO]: Fix digest.c kmapping sg entries > page in length

<hadi:zynx.com>:
o [NETFILTER]: Small interface cleanup for {ipt,ip6t,arpt}_find_target

<jan:ccsinfo.com>:
o USB ftdi device ids for 2.4

<jhh:lucent.com>:
o [SCTP] Fix to not setup a new association if the endpoint is in SHUTDOWN_ACK_SENT state and recognizes that the peer has restarted.
o [SCTP] Fix to not start a new association on a 1-many style sendmsg() with MSG_EOF/MSG_ABORT flag and no data.

<juhl-lkml:dif.dk>:
o [NET]: Remove junk from packet_mmap.txt

<kumar.gala:freescale.com>:
o Simple build fix for PPC 826x

<martin.lubich:gmx.at>:
o USB: add Clie TH55 Support in visor kernel module

<nickpiggin:yahoo.com.au>:
o rwsem race fixes backported from 2.6

<raven:themaw.net>:
o minor autofs4 fs/namei.c fix, URL update

<shurick:sectorb.msk.ru>:
o i2c-matroxfb and i2c initialization order

Andi Kleen:
o Fix argument parsing in x86-64 machine check handler
o Fix LDT/TSS limit on x86-64
o Fix compilation without CONFIG_SWIOTLB on x86-64
o Fix boot loader warnings on x86-64
o Add missing memory clobber to i386
o Fix K8 machine check decoding
o Fix FPU delayed exceptions on x86-64 too

Andreas Dilger:
o [IPV4]: Fix bug in arp_tables.c fix

Bartlomiej Zolnierkiewicz:
o clarify help entries for Promise IDE drivers a bit
o ide: add new nForce IDE/SATA device IDs to amd74xx.c

Ben Collins:
o video1394: Bugfix for low res format7 images
o sbp2: Default sbp2_serialize_io to 1
o pcilynx: Disable LCtrl bit with IRM contender

Dave Kleikamp:
o JFS: Handle out of space errors more gracefully
o JFS: Better RAS when btstack is overrun
o JFS: Don't allow reading beyond the inode map's EOF
o JFS: Fix compilation error

David Brownell:
o EHCI fixes (byteswap, BIOS)
o EHCI fixes (byteswap, BIOS)

David S. Miller:
o [TG3]: Use HOST TXDs always
o [IPV4]: Fix unaligned accesses in arp_tables.c
o [TG3]: Chip support update and a power-save bug fix
o [TG3]: Update driver version and reldate
o [SPARC]: Report si_addr in SIGINFO more accurately

Greg Kroah-Hartman:
o USB: fix empty write issue in pl2303 driver

Harald Welte:
o [NETFILTER]: Don't assign new helper after NAT when there are already expectations present

Herbert Xu:
o Fix /proc/ide/hpt366 crash

Hideaki Yoshifuji:
o [UDPv4]: Pass correct socket to ip_mc_sf_allow

Ivan Kokshaysky:
o Alpha: don't put IDE disks in standby mode on halt
o Alpha: fix PCI bridge swizzle on takara and eiger

Jamal Hadi Salim:
o [NET]: Add ARPHRD_NONE and use it in tun driver

Jens Axboe:
o DVD-RW write support
o cdrom hardware defect mgt header length

Marcelo Tosatti:
o Cset exclude: [email protected]|ChangeSet|20040606231521|43962
o Thomas Winischhofer: sisfb update
o Alexander Nyberg/Andi/Sergey: Fix x86 "clear_cpu()" macro
o Changed EXTRAVERSION to -pre6
o Michael Reinelt: Add support for NetMos 9835 serial cards
o John Carlson: Remove bogus ";" from USB gadgets's usb_descriptor_fillbuf

Mike Miller:
o cciss update

Neil Brown:
o Fix hard-to-hit BUG in raid5 resync code

Nuno Monteiro:
o Fix rwsem-fix typo
o Complete rwsem typo fix

Pete Zaitcev:
o Fix USB serial race
o USB: Update mct_u232
o USB: unusual_dev.h add Sony Handycam HC-85

Sridhar Samudrala:
o [SCTP] Fix the use of cached non-zero vtag in an INIT that is resent after a stale cookie error.
o [SCTP] Fix missing VTAG validation on certain incoming packets
o [SCTP] Fix to wakeup blocking connect() after max INIT retries failed
o [SCTP] Fix poll() on a 1-1 style socket so that it returns when the association is aborted by peer.


2004-06-17 09:40:41

by Eyal Lebedinsky

[permalink] [raw]
Subject: Re: Linux 2.4.27-pre6: visor.c

Marcelo Tosatti wrote:

> <martin.lubich:gmx.at>:
> o USB: add Clie TH55 Support in visor kernel module

A declaration at the wrong place.

gcc -D__KERNEL__ -I/data2/usr/local/src/linux-2.4-pre/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=i686 -malign-functions=4 -DMODULE -DMODVERSIONS -include /data2/usr/local/src/linux-2.4-pre/include/linux/modversions.h -nostdinc -iwithprefix include -DKBUILD_BASENAME=visor -c -o visor.o visor.c
visor.c: In function `clie_5_startup':
visor.c:899: parse error before `struct'
visor.c:901: `connection_info' undeclared (first use in this function)
visor.c:901: (Each undeclared identifier is reported only once
visor.c:901: for each function it appears in.)
make[3]: *** [visor.o] Error 1
make[3]: Leaving directory `/data2/usr/local/src/linux-2.4-pre/drivers/usb/serial'
make[2]: *** [_modsubdir_serial] Error 2

--
Eyal Lebedinsky ([email protected])

2004-06-17 09:48:38

by Eyal Lebedinsky

[permalink] [raw]
Subject: Re: Linux 2.4.27-pre6: visor.c (patch)

--- linux/drivers/usb/serial/visor.c.orig Thu Jun 17 19:18:58 2004
+++ linux/drivers/usb/serial/visor.c Thu Jun 17 19:19:34 2004
@@ -890,13 +890,12 @@
{
int response;
unsigned char *transfer_buffer;
+ struct palm_ext_connection_info *connection_info;

dbg("%s", __FUNCTION__);

dbg("%s - Set config to 1", __FUNCTION__);
usb_set_configuration(serial->dev, 1);
-
- struct palm_ext_connection_info *connection_info;

transfer_buffer = kmalloc(sizeof (*connection_info),
GFP_KERNEL);


Attachments:
2.4.27-pre6-visor.patch (503.00 B)

2004-06-17 10:06:28

by Geert Uytterhoeven

[permalink] [raw]
Subject: ip6_tables warning (was: Re: Linux 2.4.27-pre6)


This is not a new problem, but I never bothered to report it before:

| ip6_tables.c: In function `tcp_match':
| ip6_tables.c:1596: warning: implicit declaration of function `ipv6_skip_exthdr'
It needs to include <net/ipv6.h> to kill the warning.

Sorry, no patch, since my development machine is offline.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2004-06-17 10:11:41

by Geert Uytterhoeven

[permalink] [raw]
Subject: rwsem-spinlock error (was: Re: Linux 2.4.27-pre6)

On Wed, 16 Jun 2004, Marcelo Tosatti wrote:
> <nickpiggin:yahoo.com.au>:
> o rwsem race fixes backported from 2.6

> Nuno Monteiro:
> o Fix rwsem-fix typo
> o Complete rwsem typo fix

| rwsem-spinlock.c: In function `__rwsem_wake_one_writer':
| rwsem-spinlock.c:111: `tsk' undeclared (first use in this function)
| rwsem-spinlock.c:111: (Each undeclared identifier is reported only once
| rwsem-spinlock.c:111: for each function it appears in.)

How can this ever compile on any architecture?

| static inline struct rw_semaphore *__rwsem_wake_one_writer(struct rw_semaphore *sem)
| {
| struct rwsem_waiter *waiter;
|
| sem->activity = -1;
|
| waiter = list_entry(sem->wait_list.next,struct rwsem_waiter,list);
| list_del(&waiter->list);
|
| tsk = waiter->task;
| mb();
| waiter->task = NULL;
| wake_up_process(tsk);
| free_task_struct(tsk);
| return sem;
| }

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2004-06-17 10:13:17

by YOSHIFUJI Hideaki

[permalink] [raw]
Subject: Re: ip6_tables warning

In article <[email protected]> (at Thu, 17 Jun 2004 12:06:17 +0200 (MEST)), Geert Uytterhoeven <[email protected]> says:

> This is not a new problem, but I never bothered to report it before:
>
> | ip6_tables.c: In function `tcp_match':
> | ip6_tables.c:1596: warning: implicit declaration of function `ipv6_skip_exthdr'
> It needs to include <net/ipv6.h> to kill the warning.

Here it is.

===== net/ipv6/netfilter/ip6_tables.c 1.17 vs edited =====
--- 1.17/net/ipv6/netfilter/ip6_tables.c 2004-06-07 12:13:18 +09:00
+++ edited/net/ipv6/netfilter/ip6_tables.c 2004-06-17 19:11:08 +09:00
@@ -20,6 +20,7 @@
#include <linux/udp.h>
#include <linux/icmpv6.h>
#include <net/ip.h>
+#include <net/ipv6.h>
#include <asm/uaccess.h>
#include <asm/semaphore.h>
#include <linux/proc_fs.h>

--
Hideaki YOSHIFUJI @ USAGI Project <[email protected]>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA

2004-06-17 10:35:46

by Nick Piggin

[permalink] [raw]
Subject: Re: rwsem-spinlock error

Geert Uytterhoeven wrote:
> On Wed, 16 Jun 2004, Marcelo Tosatti wrote:
>
>><nickpiggin:yahoo.com.au>:
>> o rwsem race fixes backported from 2.6
>
>
>>Nuno Monteiro:
>> o Fix rwsem-fix typo
>> o Complete rwsem typo fix
>
>
> | rwsem-spinlock.c: In function `__rwsem_wake_one_writer':
> | rwsem-spinlock.c:111: `tsk' undeclared (first use in this function)
> | rwsem-spinlock.c:111: (Each undeclared identifier is reported only once
> | rwsem-spinlock.c:111: for each function it appears in.)
>
> How can this ever compile on any architecture?
>

Dangit. rwsem-spinlock.c isn't compiled for many architectures.

It should just require a

struct task_struct *tsk;

sorry.

2004-06-17 13:01:31

by Andreas Haumer

[permalink] [raw]
Subject: Re: Linux 2.4.27-pre6

--- linux-2.4.27pre6/drivers/hotplug/Config.in.orig 2004-06-17 14:16:42.000000000 +0200
+++ linux-2.4.27pre6/drivers/hotplug/Config.in 2004-06-17 14:40:02.000000000 +0200
@@ -17,7 +17,7 @@
dep_tristate ' SHPC PCI Hotplug driver' CONFIG_HOTPLUG_PCI_SHPC $CONFIG_HOTPLUG_PCI
dep_mbool ' Use polling mechanism for hot-plug events (for testing purpose)' CONFIG_HOTPLUG_PCI_SHPC_POLL_EVENT_MODE $CONFIG_HOTPLUG_PCI_SHPC
if [ "$CONFIG_ACPI" = "n" ]; then
-dep_mbool ' For AMD SHPC only: Use $HRT for resource/configuration' CONFIG_HOTPLUG_PCI_SHPC_PHPRM_LEGACY $CONFIG_HOTPLUG_PCI_SHPC
+dep_mbool ' For AMD SHPC only: Use HRT for resource/configuration' CONFIG_HOTPLUG_PCI_SHPC_PHPRM_LEGACY $CONFIG_HOTPLUG_PCI_SHPC
fi
dep_tristate ' PCI Express Hotplug driver' CONFIG_HOTPLUG_PCI_PCIE $CONFIG_HOTPLUG_PCI
dep_mbool ' Use polling mechanism for hot-plug events (for testing purpose)' CONFIG_HOTPLUG_PCI_PCIE_POLL_EVENT_MODE $CONFIG_HOTPLUG_PCI_PCIE


Attachments:
hotplug_xconfig_HRT.patch (964.00 B)

2004-06-17 13:19:48

by Nuno Monteiro

[permalink] [raw]
Subject: Re: rwsem-spinlock error

On 2004.06.17 11:35, Nick Piggin wrote:
> Geert Uytterhoeven wrote:
>> On Wed, 16 Jun 2004, Marcelo Tosatti wrote:
>>
>>> <nickpiggin:yahoo.com.au>:
>>> o rwsem race fixes backported from 2.6
>>
>>
>>> Nuno Monteiro:
>>> o Fix rwsem-fix typo
>>> o Complete rwsem typo fix
>>
>>
>> | rwsem-spinlock.c: In function `__rwsem_wake_one_writer':
>> | rwsem-spinlock.c:111: `tsk' undeclared (first use in this function)
>> | rwsem-spinlock.c:111: (Each undeclared identifier is reported only
>> once
>> | rwsem-spinlock.c:111: for each function it appears in.)
>>
>> How can this ever compile on any architecture?
>>
>
> Dangit. rwsem-spinlock.c isn't compiled for many architectures.
>
> It should just require a
>
> struct task_struct *tsk;
>


Yeah, m68k being one of those that need it, hence why Geert noticed
immediately. I only tested on x86, ppc32 and alpha, none of which
needs it. This should do the trick, then.



--- linux-2.4/lib/rwsem-spinlock.c~fix-rwsem-race-fix-3 2004-06-16 21:50:49.000000000 +0100
+++ linux-2.4/lib/rwsem-spinlock.c 2004-06-17 13:58:19.833211128 +0100
@@ -101,6 +101,7 @@ static inline struct rw_semaphore *__rws
static inline struct rw_semaphore *__rwsem_wake_one_writer(struct rw_semaphore *sem)
{
struct rwsem_waiter *waiter;
+ struct task_struct *tsk;

sem->activity = -1;



2004-06-17 17:12:43

by David Miller

[permalink] [raw]
Subject: Re: ip6_tables warning


Applied, thanks Yoshfuji.

I've seen this too, just was too lazy to fix it :)

2004-06-17 19:06:14

by Geert Uytterhoeven

[permalink] [raw]
Subject: igmp warning (was: Re: Linux 2.4.27-pre6)


And this is a new one (compared to -pre3):

| igmp.c: In function `igmpv3_newpack':
| igmp.c:279: warning: `skb' might be used uninitialized in this function

And it seems to be a real bug, not a compiler glitch:

| static struct sk_buff *igmpv3_newpack(struct net_device *dev, int size)
| {
| struct sk_buff *skb;
^^^
| struct rtable *rt;
| struct iphdr *pip;
| struct igmpv3_report *pig;
| u32 dst;
|
| dst = IGMPV3_ALL_MCR;
| if (ip_route_output(&rt, dst, 0, 0, dev->ifindex))
| return 0;
| if (rt->rt_src == 0) {
| kfree_skb(skb);
^^^
| ip_rt_put(rt);
| return 0;
| }


Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2004-06-17 19:12:24

by David Miller

[permalink] [raw]
Subject: Re: igmp warning (was: Re: Linux 2.4.27-pre6)


Indeed, a 2.6.x bugfix got put into 2.4.x but it was not relevant
there at all.

Will fix this, thanks Geert.